[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 2: (5 comments) Overall looks good to me, just some nits in the commit messag

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 2: (22 comments) http://gerrit.cloudera.org:8080/#/c/7599/2/src/kudu/rpc/connectio

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7662/2/src/kudu/security/

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-14 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7662 to look at the new patch set (#3). Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu ...

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [build-support] added IWYU filter script .. Patch Set 8: > Thanks. Maybe Dan wants to take a look, since he's reviewing your > other IWYU patches? Yes, I would

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7662/1/src/kudu/rpc/rpc-t

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [build-support] added IWYU filter script .. Patch Set 8: Code-Review+2 Thanks. Maybe Dan wants to take a look, since he's reviewing your other IWYU patches? -- T

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [build-support] added IWYU filter script .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7604/7/build-support/release/rat_exclude_files.txt File bu

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7604 to look at the new patch set (#8). Change subject: [build-support] added IWYU filter script .. [build-support] adde

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7604 to look at the new patch set (#7). Change subject: [build-support] added IWYU filter script .. [build-support] adde

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [build-support] added IWYU filter script .. Patch Set 6: (1 comment) I moved the IWYU license into the header of corresponding boost mapping files. http://gerr

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [build-support] added IWYU filter script .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7604/6/build-support/iwyu/mappings/gflags.imp File build-s

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [build-support] added IWYU filter script .. Patch Set 6: (4 comments) > (4 comments) > > For the imported mapping files: > - Please add a file-level comment

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7604 to look at the new patch set (#6). Change subject: [build-support] added IWYU filter script .. [build-support] adde

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: separate DataDirManager from BlockManagers .. Patch Set 6: (34 comments) http://gerrit.cloudera.org:8080/#/c/7602/6//COMMIT_MSG Commit Message: PS6, Line 23: dire

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 10: Code-Review+1 (1 comment) Todd and/or Mike should take another look. http://gerrit.cloudera.

[kudu-CR] Add tablet state summary metrics and fix KUDU-2044

2017-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add tablet state summary metrics and fix KUDU-2044 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7618/2//COMMIT_MSG Commit Message: PS2, Line 1

[kudu-CR] disk failure: add persistent disk states

2017-08-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/7270/11/src/kudu/fs/block_manager_util.cc File src/kudu

[kudu-CR] disk failure: add persistent disk states

2017-08-14 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#12). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] Run the gradle build as a part of the gerrit tests

2017-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Run the gradle build as a part of the gerrit tests .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7651/5/build-support/jenkins/build-and-test.sh F

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [build-support] added IWYU filter script .. Patch Set 5: (4 comments) For the imported mapping files: - Please add a file-level comment pointing to the source URL

[kudu-CR] [thirdparty]: added include-what-you-use

2017-08-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [thirdparty]: added include-what-you-use .. Patch Set 6: Verified+1 Unrelated flake in org.apache.kudu.client.TestScannerMultiTablet.org.apache.kudu.client.Test

[kudu-CR] [thirdparty]: added include-what-you-use

2017-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [thirdparty]: added include-what-you-use .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7593 To unsubscribe, visit http://gerrit.c

[kudu-CR] WIP: [iwyu] first pass

2017-08-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#14). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++ s

[kudu-CR] [thirdparty]: added include-what-you-use

2017-08-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7593 to look at the new patch set (#6). Change subject: [thirdparty]: added include-what-you-use .. [thirdparty]: added

[kudu-CR] Add tablet state summary metrics and fix KUDU-2044

2017-08-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add tablet state summary metrics and fix KUDU-2044 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7618/2//COMMIT_MSG Commit Message: PS2, Lin

[kudu-CR] WIP: [iwyu] first pass

2017-08-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#13). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++ s

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7604 to look at the new patch set (#4). Change subject: [build-support] added IWYU filter script .. [build-support] adde

[kudu-CR] WIP: [iwyu] first pass

2017-08-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 12: (21 comments) http://gerrit.cloudera.org:8080/#/c/4738/11/src/kudu/benchmarks/rle.cc File src/kudu/benchmarks/rle.cc: L

[kudu-CR] [WIP] Add BlockDeletionTransaction to Block Manager

2017-08-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [WIP] Add BlockDeletionTransaction to Block Manager .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/7656/2/src/kudu/fs/block_manager.h File src/k

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/7207/14/src/kudu/fs/file_block_manager.cc File

[kudu-CR] disk failure: add persistent disk states

2017-08-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/7270/10/src/kudu/fs/block_manager_util.cc File src/kudu

[kudu-CR] disk failure: add persistent disk states

2017-08-14 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#11). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-14 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#10). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 9: (13 comments) http://gerrit.cloudera.org:8080/#/c/6968/9/src/kudu/consensus/consensus_meta.

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-14 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#10). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. KUDU-17

[kudu-CR] Run the gradle build as a part of the gerrit tests

2017-08-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: Run the gradle build as a part of the gerrit tests .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7651/5/build-support/jenkins/build-and-test.sh

[kudu-CR] [java] Update outdated dependencies

2017-08-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: [java] Update outdated dependencies .. Patch Set 5: Yeah, they are absolutely legitimate test errors. It looks like another issue with shading order since it clai

[kudu-CR] WIP: [iwyu] first pass

2017-08-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#12). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++ source files in accordance with include-what-you-use recommendations: * remove unused header files

[kudu-CR] [build-support] added IWYU filter script

2017-08-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7604 to look at the new patch set (#3). Change subject: [build-support] added IWYU filter script .. [build-support] adde

[kudu-CR] [thirdparty]: added include-what-you-use

2017-08-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7593 to look at the new patch set (#4). Change subject: [thirdparty]: added include-what-you-use .. [thirdparty]: added