[kudu-CR] Bump test timeout for flex partitioning-itest

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Bump test timeout for flex_partitioning-itest .. Bump test timeout for flex_partitioning-itest In precommit runs, this test is sharded 8 ways so it never

[kudu-CR] Bump test timeout for flex partitioning-itest

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Bump test timeout for flex_partitioning-itest .. Patch Set 3: Verified+1 Release build hit KUDU-2089 (java test retry left tmp files, causing the build to fail)

[kudu-CR] [java] Reuse JVM across tests

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] Reuse JVM across tests .. Patch Set 1: > Having the Java tests run in dist-test would be really nice. We can't > parallelize the unit tests locally because

[kudu-CR] [java] Reuse JVM across tests

2017-08-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: [java] Reuse JVM across tests .. Patch Set 1: Having the Java tests run in dist-test would be really nice. We can't parallelize the unit tests locally because the

[kudu-CR] [java] Reuse JVM across tests

2017-08-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: [java] Reuse JVM across tests .. Patch Set 1: Yeah, I agree with "guaranteed isolation" being more reliable. This patch came as a result of the gradle patch where

[kudu-CR] [java] Reuse JVM across tests

2017-08-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: [java] Reuse JVM across tests .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7825/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestTi

[kudu-CR] [java] Reuse JVM across tests

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] Reuse JVM across tests .. Patch Set 1: Not sure how I feel about this change. In my experience these kinds of things usually cause more hard-to-diagnose bu

[kudu-CR] [java] Reuse JVM across tests

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java] Reuse JVM across tests .. Patch Set 1: (1 comment) Just passing through with a question. http://gerrit.cloudera.org:8080/#/c/7825/1//COMMIT_MSG Commit Mess

[kudu-CR] catalog manager: don't log deleted tables/tablets at startup

2017-08-24 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7826 to review the following change. Change subject: catalog_manager: don't log deleted tables/tablets at startup ...

[kudu-CR] [java] Reuse JVM across tests

2017-08-24 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7825 Change subject: [java] Reuse JVM across tests .. [java] Reuse JVM across tests Currently each java test is run in a separate JVM.This is e

[kudu-CR] java-client: improve error messages when failing to connect to secure cluster

2017-08-24 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7824 to review the following change. Change subject: java-client: improve error messages when failing to connect to secure cluster ..

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. KUDU-1943: Add BlockTransaction to Block Manager This adds a new layer of abstraction 'BlockTransaction

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. KUDU-1726: Avoid fsync-per-block in tablet copy This patch incorporates BlockTransaction API into tablet

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 34: Verified+1 We can't let IWYU get in the way of progress. -- To view, visit http://gerrit.clouder

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. Patch Set 7: Verified+1 Just say no to IWYU. -- To view, visit http://gerrit.cloudera.org:8080/7701 To unsubscr

[kudu-CR] Fix flaky ts recovery-itest TestChangeMaxCellSize

2017-08-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Fix flaky ts_recovery-itest TestChangeMaxCellSize .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7820/1/src/kudu/tserver/ts_tablet_manager.cc Fil

[kudu-CR] Fix flaky ts recovery-itest TestChangeMaxCellSize

2017-08-24 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7820 to look at the new patch set (#2). Change subject: Fix flaky ts_recovery-itest TestChangeMaxCellSize .. Fix flaky t

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7701 To unsubscribe, visit http://g

[kudu-CR] Fix flaky ts recovery-itest TestChangeMaxCellSize

2017-08-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Fix flaky ts_recovery-itest TestChangeMaxCellSize .. Patch Set 1: (1 comment) Yeah, that DCHECK is not useful. http://gerrit.cloudera.org:8080/#/c/7820/1/src/kudu

[kudu-CR] [tests] fix flakiness in catalog manager tsk-itest

2017-08-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7823 Change subject: [tests] fix flakiness in catalog_manager_tsk-itest .. [tests] fix flakiness in catalog_manager_tsk-itest After recent up

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7701/6//COMMIT_MSG Commit Message: Line 17: has its o

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-24 Thread Hao Hao (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7701 to look at the new patch set (#7). Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. K

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 34: Not sure why IWYU is complaining about including ext/alloc_traits.h for log_block_manager.cc, etc?

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 34: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http:/

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Hao Hao (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#34). Change subject: KUDU-1943: Add BlockTransaction to Block Manager ..

[kudu-CR] gradle: target JRE 7 compatibility

2017-08-24 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: gradle: target JRE 7 compatibility .. gradle: target JRE 7 compatibility Change-Id: Ib836a748f0f000b07460dd3141940655dbfb7a29 Reviewed-on: http://gerrit.c

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7821 To unsubscrib

[kudu-CR] gradle: target JRE 7 compatibility

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: gradle: target JRE 7 compatibility .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7785 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2017-08-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7821/1/src/kudu/security/tls_cont

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2017-08-24 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#2). Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. rpc: allow setting --rpc_tls_min_protocol on older RHEL versions Change-Id: Ic61f31788d63072fae60

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7821/1/src/kudu/security/tls_conte

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2017-08-24 Thread Dan Burkert (Code Review)
Hello Henry Robinson, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7821 to review the following change. Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions ..

[kudu-CR] Add more trace counters and timings

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add more trace counters and timings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7819/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.

[kudu-CR] Add more trace counters and timings

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add more trace counters and timings .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7819/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posi

[kudu-CR] Bump test timeout for flex partitioning-itest

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Bump test timeout for flex_partitioning-itest .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7814 To unsubscribe, visit http://ger

[kudu-CR] Add more trace counters and timings

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add more trace counters and timings .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/7819/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_b

[kudu-CR] Fix flaky ts recovery-itest TestChangeMaxCellSize

2017-08-24 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7820 Change subject: Fix flaky ts_recovery-itest TestChangeMaxCellSize .. Fix flaky ts_recovery-itest TestChangeMaxCellSize In TSTabletManager:

[kudu-CR] Bump test timeout for flex partitioning-itest

2017-08-24 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7814 to look at the new patch set (#3). Change subject: Bump test timeout for flex_partitioning-itest .. Bum

[kudu-CR] Bump test timeout for flex partitioning-itest

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Bump test timeout for flex_partitioning-itest .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7814/2/CMakeLists.txt File CMakeLists.txt: Line 673

[kudu-CR] Add more trace counters and timings

2017-08-24 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7819 to review the following change. Change subject: Add more trace counters and timings .. Add more trace counters and timi

[kudu-CR] Bump test timeout for flex partitioning-itest

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Bump test timeout for flex_partitioning-itest .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7814/2/CMakeLists.txt File CMakeLists.txt: Line 673:

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7701/6//COMMIT_MSG Commit Message: Line 17: has a

[kudu-CR] [security] avoid kerberos ticket renewal and only reacquire

2017-08-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [security] avoid kerberos ticket renewal and only reacquire .. Patch Set 1: > I think there is mention of 'renew' in init.h. Also I think we can > remove the re

[kudu-CR] Bump test timeout for flex partitioning-itest

2017-08-24 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7814 to look at the new patch set (#2). Change subject: Bump test timeout for flex_partitioning-itest .. Bump test timeo

[kudu-CR] Bump test timeout for flex partitioning-itest

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Bump test timeout for flex_partitioning-itest .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7814/1/CMakeLists.txt File CMakeLists.txt: Line 67

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7701/1//COMMIT_MSG Commit Message: PS1, Line 13: to k

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/7701/5/src/kudu/fs/file_block_manager.cc File src/kud

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-24 Thread Hao Hao (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7701 to look at the new patch set (#6). Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. K

[kudu-CR] KUDU-2098. Drop Spark 1 Support

2017-08-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: KUDU-2098. Drop Spark 1 Support .. Patch Set 1: Yeah, I think that makes sense. -- To view, visit http://gerrit.cloudera.org:8080/7690 To unsubscribe, visit http

[kudu-CR] gradle: target JRE 7 compatibility

2017-08-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: gradle: target JRE 7 compatibility .. Patch Set 2: Would +2 if I could. :D -- To view, visit http://gerrit.cloudera.org:8080/7785 To unsubscribe, visit http://ge

[kudu-CR] gradle: target JRE 7 compatibility

2017-08-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: gradle: target JRE 7 compatibility .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7785 To unsubscribe, visit http://gerrit.cloude

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 33: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http:/

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 33: (3 comments) http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/block_manager.cc File src/kudu/

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Hao Hao (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#33). Change subject: KUDU-1943: Add BlockTransaction to Block Manager ..

[kudu-CR] Bump test timeout for flex partitioning-itest

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Bump test timeout for flex_partitioning-itest .. Patch Set 1: (3 comments) Test failure is weird; perhaps an oom kill on the Gradle daemon? http://gerrit.cloudera

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 32: (1 comment) http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/block_manager.h File src/kud

[kudu-CR] [security] avoid kerberos ticket renewal and only reacquire

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] avoid kerberos ticket renewal and only reacquire .. Patch Set 1: I think there is mention of 'renew' in init.h. Also I think we can remove the renew_li

[kudu-CR] [java] KUDU-2103 Canonicalize hostnames in client

2017-08-24 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. Change subject: [java] KUDU-2103 Canonicalize hostnames in client .. Patch Set 6: You're welcome, thanks for merging it in. I've backported it to 1.3.x and 1.4.x, tested it loca

[kudu-CR] Fix flakiness of kudu-admin-test TestMoveTablet

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix flakiness of kudu-admin-test TestMoveTablet .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7808 To unsubscribe, visit http://g

[kudu-CR](branch-1.3.x) [java] KUDU-2103 Canonicalize hostnames in client

2017-08-24 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded a new change for review. http://gerrit.cloudera.org:8080/7815 Change subject: [java] KUDU-2103 Canonicalize hostnames in client .. [java] KUDU-2103 Canonicalize hostnames in client When Kerberos is u

[kudu-CR] Fix flakiness of kudu-admin-test TestMoveTablet

2017-08-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix flakiness of kudu-admin-test TestMoveTablet .. Patch Set 2: > Going to ignore IWYU since I dont think I touched anything that > should affect includes. You

[kudu-CR] Fix flakiness of kudu-admin-test TestMoveTablet

2017-08-24 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Will Berkeley, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7808 to look at the new patch set (#2). Change subject: Fix flakiness of kudu-admin-test TestMoveTablet ..

[kudu-CR] Fix flakiness of kudu-admin-test TestMoveTablet

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix flakiness of kudu-admin-test TestMoveTablet .. Patch Set 1: Verified+1 Going to ignore IWYU since I dont think I touched anything that should affect includes.

[kudu-CR] Bump test timeout for flex partitioning-itest

2017-08-24 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7814 to review the following change. Change subject: Bump test timeout for flex_partitioning-itest .. Bump test timeout for

[kudu-CR] [rpc] faster generation of KRPC call ID

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [rpc] faster generation of KRPC call ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7813/2//COMMIT_MSG Commit Message: PS2, Line 48: const

[kudu-CR] [rpc] faster generation of KRPC call ID

2017-08-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [rpc] faster generation of KRPC call ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7813/2//COMMIT_MSG Commit Message: PS2, Line 48: cons

[kudu-CR] [rpc] faster generation of KRPC call ID

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [rpc] faster generation of KRPC call ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7813/2//COMMIT_MSG Commit Message: PS2, Line 48: const

[kudu-CR] [rpc] faster generation of KRPC call ID

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [rpc] faster generation of KRPC call ID .. Patch Set 2: Code-Review-1 (1 comment) don't think this is a worthwhile optimization since this isn't a hot code path

[kudu-CR] [rpc] faster generation of KRPC call ID

2017-08-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [rpc] faster generation of KRPC call ID .. [rpc] faster generation of KRPC call ID Updated the way how the KRPC call identifiers are generated. To compare, I used

[kudu-CR] [rpc] faster generation of KRPC call ID

2017-08-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7813 Change subject: [rpc] faster generation of KRPC call ID .. [rpc] faster generation of KRPC call ID Updated the way how the KRPC call ide

[kudu-CR] [iwyu] another catch-up update

2017-08-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] another catch-up update .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7802/3/src/kudu/rpc/periodic.cc File src/kudu/rpc/periodic.cc: L

[kudu-CR](branch-1.4.x) [java] KUDU-2103 Canonicalize hostnames in client

2017-08-24 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded a new change for review. http://gerrit.cloudera.org:8080/7812 Change subject: [java] KUDU-2103 Canonicalize hostnames in client .. [java] KUDU-2103 Canonicalize hostnames in client When Kerberos is u

[kudu-CR] Fix flakiness of kudu-admin-test TestMoveTablet

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix flakiness of kudu-admin-test TestMoveTablet .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7808/1//COMMIT_MSG Commit Message: PS1, Line 36:

[kudu-CR] [iwyu] another catch-up update

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [iwyu] another catch-up update .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7802/3/src/kudu/rpc/periodic.cc File src/kudu/rpc/periodic.cc: Line

[kudu-CR] [iwyu] another catch-up update

2017-08-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [iwyu] another catch-up update .. [iwyu] another catch-up update This is just another catch-up patch after recent updates: since the IWYU gerrit was not

[kudu-CR] [iwyu] another catch-up update

2017-08-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] another catch-up update .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7802/3/src/kudu/rpc/periodic.cc File src/kudu/rpc/periodic.cc: L

[kudu-CR] [security] avoid kerberos ticket renewal and only reacquire

2017-08-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7810 Change subject: [security] avoid kerberos ticket renewal and only reacquire .. [security] avoid kerberos ticket renewal and only reacquir

[kudu-CR] Fix flakiness of kudu-admin-test TestMoveTablet

2017-08-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Fix flakiness of kudu-admin-test TestMoveTablet .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7808 To unsubscribe, visit http:

[kudu-CR] Fix flakiness of kudu-admin-test TestMoveTablet

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix flakiness of kudu-admin-test TestMoveTablet .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7808/1//COMMIT_MSG Commit Message: P

[kudu-CR] [iwyu] another catch-up update

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [iwyu] another catch-up update .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7802/3/src/kudu/rpc/periodic.cc File src/kudu/rpc/peri

[kudu-CR] KUDU-2098. Drop Spark 1 Support

2017-08-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2098. Drop Spark 1 Support .. Patch Set 1: So is the plan that this can merge after 1.5 branches? -- To view, visit http://gerrit.cloudera.org:8080/7690 To

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 32: (2 comments) http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/block_manager.h File src/kud

[kudu-CR] gradle: target JRE 7 compatibility

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: gradle: target JRE 7 compatibility .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7785 To unsubscribe, visit http://gerrit.cloude

[kudu-CR] [security] avoid tickets with NULL 'renew till'

2017-08-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: [security] avoid tickets with NULL 'renew_till' .. Abandoned Turns out that this patch makes the issue mentioned in the commit message less severe, but still hits it occ

[kudu-CR] [security] avoid tickets with NULL 'renew till'

2017-08-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [security] avoid tickets with NULL 'renew_till' .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7770/2/src/kudu/security/init.cc File src/kudu/s

[kudu-CR] Fix flakiness of kudu-admin-test TestMoveTablet

2017-08-24 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7808 to review the following change. Change subject: Fix flakiness of kudu-admin-test TestMoveTablet .. Fix f

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 4: This looks good to me, but obviously this code is extremely fragile. We should figure out a way to

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/block_manager.h File src/kudu/f

[kudu-CR] gradle: target JRE 7 compatibility

2017-08-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: gradle: target JRE 7 compatibility .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7785/1/java/gradle/compile.gradle File java/gradle/compile.grad

[kudu-CR] gradle: target JRE 7 compatibility

2017-08-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7785 to look at the new patch set (#2). Change subject: gradle: target JRE 7 compatibility .. gradle: target JRE 7 compa

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7765/4/java/kudu-client/src/main/java/org/apache/k

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 32: (1 comment) http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/block_manager.h File src/kud

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 32: (1 comment) http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/log_block_manager.cc File src

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7765/4/java/kudu-client/src/main/java/org/apache/kud

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 32: (1 comment) http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/log_block_manager.cc File src/ku

[kudu-CR] [java] KUDU-2103 Canonicalize hostnames in client

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] KUDU-2103 Canonicalize hostnames in client .. Patch Set 6: Thanks for the fix, Attila. I think we should cherry pick this back to branch-1.4.x and branch-1

[kudu-CR] [java] KUDU-2103 Canonicalize hostnames in client

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] KUDU-2103 Canonicalize hostnames in client .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7757 To unsubscribe, visit http:

[kudu-CR] [java] KUDU-2103 Canonicalize hostnames in client

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [java] KUDU-2103 Canonicalize hostnames in client .. [java] KUDU-2103 Canonicalize hostnames in client When Kerberos is used the service principal contain

[kudu-CR](branch-1.2.x) log block manager: use unsigned int for next block id

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: log block manager: use unsigned int for next_block_id_ .. log block manager: use unsigned int for next_block_id_ KUDU-1538 introduced 'next_block_id_' to

[kudu-CR](branch-1.3.x) log block manager: use unsigned int for next block id

2017-08-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: log block manager: use unsigned int for next_block_id_ .. log block manager: use unsigned int for next_block_id_ KUDU-1538 introduced 'next_block_id_' to

  1   2   >