[kudu-CR] Add tablet state summary metrics

2017-09-13 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7980 to look at the new patch set (#9). Change subject: Add tablet state summary metrics .. Add tablet state

[kudu-CR] Add tablet state summary metrics

2017-09-13 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7980/8/src/kudu/tserver/ts_tablet_manager_metrics.h File src/ku

[kudu-CR] KUDU-2135 (part 2): check integrity of new on-disk format

2017-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2135 (part 2): check integrity of new on-disk format .. Patch Set 28: (5 comments) Note: another significant portion of this patch has been pushed into anoth

[kudu-CR] KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients

2017-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8026/1/java/kudu-client/s

[kudu-CR] KUDU-2135 (part 1): add persistent disk states

2017-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2135 (part 1): add persistent disk states .. Patch Set 2: Ah, Adar mentioned it'd be a good idea to decompose DataDirManager::Open() since it's so long. I'll

[kudu-CR] KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients

2017-09-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8026/2//COMMIT_MS

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/8016/10/src/kudu/integration-tests/clus

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-13 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7985 to look at the new patch set (#9). Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession ..

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval

2017-09-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/8041/1/src/kudu/util/sorted

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8058 to review the following change. Change subject: Add backdated announcement blog post for 1.5 ..

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-13 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8016 to look at the new patch set (#12). Change subject: KUDU-2125: Tablet copy client does not retry on failures

[kudu-CR] Update instructions for publishing changes to the live site

2017-09-13 Thread Mike Percy (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8059 to review the following change. Change subject: Update instructions for publishing changes to the live site .. Update

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8016/4/src/kudu/integration-tests/tablet_

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#2). Change subject: Add backdated announcement blog post for 1.5 .. Add backdated announcement blog post for 1.5 Change-Id: I301db21a8c5e75b2cbe47b3992094d7b1eca7731 --- A _posts/2017-0

[kudu-CR] Add tablet state summary metrics

2017-09-13 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7980 To unsubscribe, visit http://gerrit.cloudera.

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-09-13 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7985 To

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval

2017-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/8041/1/src/kudu/util/sorted_d

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add backdated announcement blog post for 1.5 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8058/2/_posts/2017-09-08-apache-kudu-1-5-0-released

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#3). Change subject: Add backdated announcement blog post for 1.5 .. Add backdated announcement blog post for 1.5 Change-Id: I301db21a8c5e75b2cbe47b3992094d7b1eca7731 --- A _posts/2017-0

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add backdated announcement blog post for 1.5 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8058/2/_posts/2017-09-08-apache-kudu-1-5-0-released.m

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add backdated announcement blog post for 1.5 .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/8058/3/_posts/2017-09-08-apache-kudu-

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add backdated announcement blog post for 1.5 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8058/3/_posts/2017-09-08-apache-kudu-1-5-0-released.m

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8058 to look at the new patch set (#4). Change subject: Add backdated announcement blog post for 1.5 .. Add backdated a

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add backdated announcement blog post for 1.5 .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8058 To unsubscribe, visit http://g

[kudu-CR] rename suicide on eio flag to crash on eio

2017-09-13 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7994 to look at the new patch set (#3). Change subject: rename suicide_on_eio flag to crash_on_eio .

[kudu-CR] rename suicide on eio flag to crash on eio

2017-09-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rename suicide_on_eio flag to crash_on_eio .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7994 To unsubscribe, visit http://gerrit

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-13 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/8016/10/src/kudu/tserver/tablet_copy_clie

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/8016/10/src/kudu/tserver/tablet_copy_cli

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/8016/10/src/kudu/tserver/tablet_copy_cli

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-13 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8016 to look at the new patch set (#13). Change subject: KUDU-2125: Tablet copy client does not retry on failures

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-13 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8016 to look at the new patch set (#14). Change subject: KUDU-2125: Tablet copy client does not retry on failures

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add backdated announcement blog post for 1.5 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8058 To unsubscribe, visit htt

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add backdated announcement blog post for 1.5 .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8058 To unsubscribe, visit http:/

[kudu-CR](gh-pages) Add backdated announcement blog post for 1.5

2017-09-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add backdated announcement blog post for 1.5 .. Add backdated announcement blog post for 1.5 Change-Id: I301db21a8c5e75b2cbe47b3992094d7b1eca7731 R

[kudu-CR] Update instructions for publishing changes to the live site

2017-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Update instructions for publishing changes to the live site .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8059/1/README.adoc File README.adoc:

[kudu-CR] parse metrics log: merge metrics across entities of same type

2017-09-13 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8062 to review the following change. Change subject: parse_metrics_log: merge metrics across entities of same type .. parse_

[kudu-CR] KUDU-2135 (part 1): add persistent disk states

2017-09-13 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8048 to look at the new patch set (#4). Change subject: KUDU-2135 (part 1): add persistent disk states .. KUDU-2135 (par

[kudu-CR] KUDU-2135 (part 1): add persistent disk states

2017-09-13 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8048 to look at the new patch set (#5). Change subject: KUDU-2135 (part 1): add persistent disk states .. KUDU-2135 (par

[kudu-CR] Add tablet state summary metrics

2017-09-13 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: Add tablet state summary metrics .. Add tablet state summary metrics This patch adds metrics for the number of tablets in each state (i.e. the number of

[kudu-CR] rename suicide on eio flag to crash on eio

2017-09-13 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: rename suicide_on_eio flag to crash_on_eio .. rename suicide_on_eio flag to crash_on_eio The name `suicide_on_eio` seems a bit controversial/insensitive. A

[kudu-CR] docs: split disk failure from disk config changes

2017-09-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: split disk failure from disk config changes .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7984/4//COMMIT_MSG Commit Message: PS4, Line 9:

[kudu-CR] parse metrics log: merge metrics across entities of same type

2017-09-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: parse_metrics_log: merge metrics across entities of same type .. Patch Set 1: (4 comments) First time looking at this so mostly a scan, but since it's a standalone

[kudu-CR] KUDU-2144. Add metrics for Reactor load

2017-09-13 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Michael Ho, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8064 to review the following change. Change subject: KUDU-2144. Add metrics for Reactor load .. KUDU-2144. Add m

[kudu-CR] docs: split disk failure from disk config changes

2017-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: docs: split disk failure from disk config changes .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7984/4//COMMIT_MSG Commit Message: PS4, Line 9:

[kudu-CR] docs: split disk failure from disk config changes

2017-09-13 Thread Andrew Wong (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7984 to look at the new patch set (#5). Change subject: docs: split disk failure from disk config changes ..

[kudu-CR] docs: split disk failure from disk config changes

2017-09-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: split disk failure from disk config changes .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7984 To unsubscribe, visit http:/

[kudu-CR] docs: split disk failure from disk config changes

2017-09-13 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: docs: split disk failure from disk config changes .. docs: split disk failure from disk config changes The administration notes commented on Kudu's handlin

[kudu-CR] [util] fix compilation breakage

2017-09-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/8065 Change subject: [util] fix compilation breakage .. [util] fix compilation breakage On some Linux systems (old ones), there isn't linux/s

[kudu-CR] [util] fix compilation breakage

2017-09-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] fix compilation breakage .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8065 To unsubscribe, visit http://gerrit.cloudera.o

[kudu-CR] [util] fix compilation breakage

2017-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [util] fix compilation breakage .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8065 To unsubscribe, visit http://gerrit.cloudera.

[kudu-CR] KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients

2017-09-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8026/2//COMMIT_MSG Commit

[kudu-CR] KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients

2017-09-13 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8026 to look at the new patch set (#3). Change subject: KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients ..

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-13 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8066 to review the following change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .

[kudu-CR] [util] fix compilation breakage

2017-09-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [util] fix compilation breakage .. [util] fix compilation breakage On some Linux systems (old ones), there isn't linux/sysinfo.h header file. IWYU migh

[kudu-CR] [util] fix compilation breakage

2017-09-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] fix compilation breakage .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8065/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.c