[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

2017-09-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/7656 ) Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 8: (3 comments) http://gerrit.cloude

[kudu-CR] periodic: prevent runaway callback loops

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8116 ) Change subject: periodic: prevent runaway callback loops .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8116/1/src/kudu

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-09-20 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8090 to look at the new patch set (#5). Change subject: KUDU-1125: issue one catalog write per tablet report .. KUDU-112

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-20 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#7). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. cata

[kudu-CR] periodic: prevent runaway callback loops

2017-09-20 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8116 to review the following change. Change subject: periodic: prevent runaway callback loops .. periodic: p

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. KUDU-2149: avoid election stacking by restoring failure monitor semantics Pri

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 8: (10 comments) http://gerrit.cloudera.org:8080/#/c/7656/8/src/kudu/fs/blo

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: fix to protobuf bump .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8115 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-20 Thread Adar Dembo (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8115 to review the following change. Change subject: thirdparty: fix to protobuf bump .. thirdparty: fix to protobuf bump

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8109/6/src/kudu/tserver/

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8109/6/src/kudu/master/c

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8107 To

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. consensus: KUDU-2147. Unknown leader should not be treated as valid UUID This

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/6/src/kudu/consensu

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8107 to look at the new patch set (#7). Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ..

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8109 To u

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8109 T

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8109/3/src/kudu/integrati

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8109 to look at the new patch set (#5). Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID ..

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8109/1/src/kudu/integ

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8109 To u

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8109 to look at the new patch set (#4). Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID ..

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8109 to look at the new patch set (#3). Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID ..

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

2017-09-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7656/7//COMMIT_MSG Commit M

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

2017-09-20 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7656 to look at the new patch set (#8). Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks ..

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/6/src/kudu

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8109/1/src/kudu/integrat

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8109/1/src/kudu/

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8107

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8107 to look at the new patch set (#6). Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ..

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/4/src/kudu/consensu

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8107 to look at the new patch set (#5). Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ..

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 2: Code-Review+2 Looks good to me but would be good to check in with David/Al

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8109/1/src/kudu/integ

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/4/src

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8109 to look at the new patch set (#2). Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID ...

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/8109/1/src/kudu/consensu

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8041/4/src/kudu/util/sort

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: Posting a transcript of a side chat, for posterity: ... [1:12 PM] David Alves: no, no other

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8107

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/integ

[kudu-CR] kudu-spark: change default master address to local fqdn

2017-09-20 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: kudu-spark: change default master address to local fqdn .. kudu-spark: change default master address to local fqdn The previous default was 'localhost', w

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/integrat

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/cons

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/integ

[kudu-CR] Add mustache template for /table

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add mustache template for /table .. Patch Set 7: Code-Review+1 I think Todd should take another look. -- To view, visit http://gerrit.cloudera.org:8080/8067 To un

[kudu-CR] Add mustache template for /table

2017-09-20 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8067 to look at the new patch set (#7). Change subject: Add mustache template for /table .. Add mustache template for /t

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/consens

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/conse

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8107/4/src/kudu/inte

[kudu-CR] Add mustache template for /table

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add mustache template for /table .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8067/5/src/kudu/master/master-path-handlers.cc File src/kudu/maste

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/consensu

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/conse

[kudu-CR] kudu-spark: change default master address to local fqdn

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: kudu-spark: change default master address to local fqdn .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8072/2/java/kudu-spark-tools

[kudu-CR] Add mustache template for /table

2017-09-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add mustache template for /table .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8067/5/src/kudu/master/master-path-handlers.cc File src/kudu/m

[kudu-CR] Add mustache template for /table

2017-09-20 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8067 to look at the new patch set (#6). Change subject: Add mustache template for /table .. Add mustache template for /t

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8107 To

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/consen

[kudu-CR] parse metrics log: merge metrics across entities of same type

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: parse_metrics_log: merge metrics across entities of same type .. parse_metrics_log: merge metrics across entities of same type This changes the tool so th

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: Thinking a bit more which constraint we actually want to enforce. I think we need to enforce

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/consens

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#4). Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. KUDU-2149: avoid election stacking by restoring failure monitor semantics Prior to commi

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: Right, that's definitely a valid concern: on-disk isn't the only place we can "persist" the data. Ri

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/mvcc.cc File src/ku

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: I like the changes in general (post specific comments in a few mins). One concern that I hav

[kudu-CR] Add mustache template for /table

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add mustache template for /table .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8067/5/src/kudu/master/master-path-handlers.cc File src/kudu/mast

[kudu-CR] [iwyu] update std::move

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [iwyu] update std::move .. [iwyu] update std::move Updated IWYU mappings to use for std::move() and std::swap() instead of . Unsorted micro-cleanups i

[kudu-CR] [iwyu] update std::move

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] update std::move .. Patch Set 5: Code-Review+1 The flakiness of the org.apache.kudu.client.TestAsyncKuduSession test is documented at: https://issues

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/consen

[kudu-CR] [iwyu] update std::move

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] update std::move .. Patch Set 5: -Code-Review Verified+1 The flakiness of the org.apache.kudu.client.TestAsyncKuduSession test is documented at: KUDU

[kudu-CR] Add more trace counters and timings

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add more trace counters and timings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7819/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.

[kudu-CR] parse metrics log: merge metrics across entities of same type

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: parse_metrics_log: merge metrics across entities of same type .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8062 To unsubscribe,

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: Verified+1 Overriding Jenkins, the two failures were in starting a TSAN t

[kudu-CR] Add more trace counters and timings

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add more trace counters and timings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7819/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix

[kudu-CR] [iwyu] update std::move

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [iwyu] update std::move .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8088/4/src/kudu/rpc/rpc_sidecar.h File src/kudu/rpc/rpc_sidecar.h: Line 23

[kudu-CR] [iwyu] update std::move

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [iwyu] update std::move .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8088 To unsubscribe, visit http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8068 To unsubscribe, visit http://gerrit.

[kudu-CR] parse metrics log: merge metrics across entities of same type

2017-09-20 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8062 to look at the new patch set (#2). Change subject: parse_metrics_log: merge metrics across entities of same type ..

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/8041/4//COMMIT_MSG Commit

[kudu-CR] parse metrics log: merge metrics across entities of same type

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: parse_metrics_log: merge metrics across entities of same type .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8062/1/src/kudu/scripts/parse_metri

[kudu-CR] [iwyu] update std::move

2017-09-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] update std::move .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8088/4/src/kudu/rpc/rpc_sidecar.h File src/kudu/rpc/rpc_sidecar.h: Line

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8068/4/src/kudu/master/master-path-handlers.cc File sr

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-20 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8068 to look at the new patch set (#5). Change subject: KUDU-501 Redirect to leader master web UI .. KUDU-501 Redirect t

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

2017-09-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/7656/7/src/kudu/fs/block_m

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8068/4/src/kudu/master/master-path-handlers.cc File src/k

[kudu-CR] Rename BlockTransaction to BlockCreationTransaction

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Rename BlockTransaction to BlockCreationTransaction .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8101 To unsubscribe, visit http

[kudu-CR] Rename BlockTransaction to BlockCreationTransaction

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Rename BlockTransaction to BlockCreationTransaction .. Rename BlockTransaction to BlockCreationTransaction This patch renames BlockTransaction to BlockCrea

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8068/3/src/kudu/master/master-path-handlers.cc File sr

[kudu-CR] Add mustache template for /table

2017-09-20 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8067 to look at the new patch set (#5). Change subject: Add mustache template for /table .. Add mustache template for /t

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-20 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8068 to look at the new patch set (#4). Change subject: KUDU-501 Redirect to leader master web UI .. KUDU-501 Redirect t

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8107/2/src/kudu/integra

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

2017-09-20 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8107 to look at the new patch set (#3). Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ..

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/7656/7//COMMIT_MSG Comm

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7656/6/src/kudu/fs/block

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/8109/1/src/kudu/integrat

[kudu-CR] [iwyu] update std::move

2017-09-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8088 to look at the new patch set (#5). Change subject: [iwyu] update std::move .. [iwyu] update std::move Updated IWYU

[kudu-CR] [iwyu] update std::move

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [iwyu] update std::move .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8088/4/src/kudu/rpc/rpc_sidecar.h File src/kudu/rpc/rpc_sidecar.h: Line 23

[kudu-CR] KUDU-501 Redirect to leader master web UI

2017-09-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8068/3/src/kudu/master/master-path-handlers.cc File src/k

  1   2   >