Adar Dembo has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks ......................................................................
Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/7656/7//COMMIT_MSG Commit Message: PS7, Line 14: hole holes http://gerrit.cloudera.org:8080/#/c/7656/7/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 284: BlockManager* bm = created_blocks_[0]->block_manager(); Since BlockDeletionTransaction can't infer the BlockManager from the deleted blocks themselves, let's make this consistent with it by supplying the BlockManager in the transaction's constructor. Line 309: void AddDeletedBlock(const BlockId& block) { BlockIds are small (64-bits each) so it's preferred to pass them by value and copy them. PS7, Line 317: // Returns the list of IDs, among the given blocks IDs, of block that can be : // successfully deleted. Why doesn't this have the same signature as CommitCreatedBlocks? Line 324: WARN_NOT_OK(s, strings::Substitute("Could not delete block $0", block.ToString())); Seems like an unusual place for a warning. I'd suggest an alternative: 1. Return a Status. 2. That Status should be the first failure seen. 3. Add to the Status a message including the total number of blocks that could NOT be deleted. -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
