[kudu-CR] tool: add cluster shell action

2017-10-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Patch Set 8: (11 comments) Just skimmed through. Will take a deeper look tomorrow.

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-10-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8090 ) Change subject: KUDU-1125: issue one catalog write per tablet report .. Patch Set 7: (9 comments) This is a big improvement, Adar. http:

[kudu-CR] WIP [consensus] adding/removing NON VOTER members

2017-10-02 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8138 to look at the new patch set (#6). Change subject: WIP [consensus] adding/removing NON_VOTER members

[kudu-CR] [tablet copy] end session before bootstrapping tablet

2017-10-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8133 ) Change subject: [tablet copy] end session before bootstrapping tablet .. Abandoned Abandoned in favor of http://gerrit.cloudera.org:8080/8197 --

[kudu-CR] [tablet copy] comment on TabletCopyClient lifecycle

2017-10-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8197 Change subject: [tablet copy] comment on TabletCopyClient lifecycle .. [tablet copy] comment on TabletCopyClient lifecycle Added an expl

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-10-02 Thread Adar Dembo (Code Review)
Hello Mike Percy, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8090 to look at the new patch set (#7). Change subject: KUDU-1125: issue one catalog write per tablet report ...

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8090 ) Change subject: KUDU-1125: issue one catalog write per tablet report .. Patch Set 6: (10 comments) http://gerrit.cloudera.org:8080/#/c/80

[kudu-CR] KUDU-2055 [part 5]: Incorporate BlockDeletionTransaction in block deletions

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8163 ) Change subject: KUDU-2055 [part 5]: Incorporate BlockDeletionTransaction in block deletions .. Patch Set 1: (1 comment) Anything worth t

[kudu-CR] KUDU-2055 [part 4]: Coalesce hole punch for LBM

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8162 ) Change subject: KUDU-2055 [part 4]: Coalesce hole punch for LBM .. Patch Set 3: (18 comments) http://gerrit.cloudera.org:8080/#/c/8162/3/

[kudu-CR] [tablet copy] end session before bootstrapping tablet

2017-10-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8133 ) Change subject: [tablet copy] end session before bootstrapping tablet .. Patch Set 1: > > Should this patch be abandoned? > > I think

[kudu-CR] [tablet copy] end session before bootstrapping tablet

2017-10-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8133 ) Change subject: [tablet copy] end session before bootstrapping tablet .. Patch Set 1: > Should this patch be abandoned? I think I need

[kudu-CR] [tests] fix flakes in delete table-itest

2017-10-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7972 ) Change subject: [tests] fix flakes in delete_table-itest .. Patch Set 3: Maybe we should just merge this patch the way it is to reduce the

[kudu-CR] KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries.

2017-10-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8037 ) Change subject: KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries. .. Patch Set 1: Are we planning on merging this

[kudu-CR] [tablet copy] end session before bootstrapping tablet

2017-10-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8133 ) Change subject: [tablet copy] end session before bootstrapping tablet .. Patch Set 1: Should this patch be abandoned? -- To view, visit

[kudu-CR] WIP [raft consensus-itest] fix flake in TestSlowLeader

2017-10-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7887 ) Change subject: WIP [raft_consensus-itest] fix flake in TestSlowLeader .. Patch Set 2: I think this change makes sense but I am wondering

[kudu-CR] KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 ) Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction .. Patch Set 5: (13 comments) http://

[kudu-CR] [catalog manager] introduce replica selector

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8161 ) Change subject: [catalog manager] introduce replica selector .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8161/3/src/k

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8141 ) Change subject: [webui] Allow custom response codes and headers .. Patch Set 6: (9 comments) I'm not an HTTP expert so it'd be good to fi

[kudu-CR] java: replace bespoke minicluster implementation with control shell

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8194 ) Change subject: java: replace bespoke minicluster implementation with control shell .. Removed reviewer Kudu Jenkins with the foll

[kudu-CR] java: replace bespoke minicluster implementation with control shell

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8194 ) Change subject: java: replace bespoke minicluster implementation with control shell .. Patch Set 1: Verified+1 Overriding Jenkins, the on

[kudu-CR] tool: add cluster shell action

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Patch Set 8: Verified+1 Overriding Jenkins, the 10 test failures were all due to an unsy

[kudu-CR] tool: add cluster shell action

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jen

[kudu-CR] KUDU-2044 Tombstoned tablets show up in /metrics

2017-10-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7981 ) Change subject: KUDU-2044 Tombstoned tablets show up in /metrics .. Patch Set 6: (6 comments) LGTM, just a couple nits http://gerrit.clo

[kudu-CR] java: replace bespoke minicluster implementation with control shell

2017-10-02 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8194 to review the following change. Change subject: java: replace bespoke minicluster implementation with control shell ..

[kudu-CR] tool: add cluster shell action

2017-10-02 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7853 to look at the new patch set (#8). Change subject: tool: add cluster shell action ...

[kudu-CR] subprocess: some cosmetic changes

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: some cosmetic changes .. subprocess: some cosmetic changes Change-Id: I9d81dee93817c560c1237114fb515fa

[kudu-CR] mini-cluster: new module for the mini cluster implementations

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8173 ) Change subject: mini-cluster: new module for the mini cluster implementations .. mini-cluster: new module for the mini cluster impl

[kudu-CR] KUDU-2132 Error dropping columns renamed to old key column names

2017-10-02 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8188 ) Change subject: KUDU-2132 Error dropping columns renamed to old key column names .. KUDU-2132 Error dropping columns renamed to

[kudu-CR] KUDU-2132 Error dropping columns renamed to old key column names

2017-10-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8188 ) Change subject: KUDU-2132 Error dropping columns renamed to old key column names .. Patch Set 2: Code-Review+2 -- To view, visit http://

[kudu-CR] tool: add cluster shell action

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 ) Change subject: tool: add cluster shell action .. Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/kud

[kudu-CR] KUDU-2132 Error dropping columns renamed to old key column names

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8188 ) Change subject: KUDU-2132 Error dropping columns renamed to old key column names .. Patch Set 2: Code-Review+1 Will defer to Dan. -- To

[kudu-CR] WIP [consensus] adding/removing NON VOTER members

2017-10-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8138 ) Change subject: WIP [consensus] adding/removing NON_VOTER members .. Patch Set 2: (2 comments) Thank you for the review! http://gerri

[kudu-CR] WIP [consensus] adding/removing NON VOTER members

2017-10-02 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8138 to look at the new patch set (#5). Change subject: WIP [consensus] adding/removing NON_VOTER members

[kudu-CR] WIP [consensus] adding/removing NON VOTER members

2017-10-02 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8138 to look at the new patch set (#4). Change subject: WIP [consensus] adding/removing NON_VOTER members

[kudu-CR](branch-1.3.x) KUDU-2032 (part 2): propagate master hostnames into client

2017-10-02 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8183 to look at the new patch set (#3). Change subject: KUDU-2032 (part 2): propagate master hostnames into client ..

[kudu-CR](branch-1.4.x) KUDU-2032 (part 2): propagate master hostnames into client

2017-10-02 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8186 to look at the new patch set (#3). Change subject: KUDU-2032 (part 2): propagate master hostnames into client ..

[kudu-CR](branch-1.3.x) KUDU-2032 (part 2): propagate master hostnames into client

2017-10-02 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8183 to look at the new patch set (#2). Change subject: KUDU-2032 (part 2): propagate master hostnames into client ..

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-10-02 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. ( http://gerrit.cloudera.org:8080/8193 ) Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. Abandoned Whoops. Wrong branch. -- To view, visit http://gerrit.cl

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-10-02 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8193 Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. KUDU-2032 (part 2): propagate master hostnames into client

[kudu-CR](branch-1.4.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-10-02 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8185 to look at the new patch set (#2). Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies ..

[kudu-CR] KUDU-2132 Error dropping columns renamed to old key column names

2017-10-02 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8188 to look at the new patch set (#2). Change subject: KUDU-2132 Error dropping columns renamed to old key column names .

[kudu-CR] KUDU-2132 Error dropping columns renamed to old key column names

2017-10-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8188 ) Change subject: KUDU-2132 Error dropping columns renamed to old key column names .. Patch Set 1: (3 comments) http://gerrit.cloudera.o

[kudu-CR] [webui] Allow custom response codes and headers

2017-10-02 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8141 to look at the new patch set (#6). Change subject: [webui] Allow custom response codes and headers ..

[kudu-CR] KUDU-2159 Add metric for upserts converted to updates

2017-10-02 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8177 ) Change subject: KUDU-2159 Add metric for upserts converted to updates .. KUDU-2159 Add metric for upserts converted to updates

[kudu-CR] KUDU-2159 Add metric for upserts converted to updates

2017-10-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8177 ) Change subject: KUDU-2159 Add metric for upserts converted to updates .. Patch Set 2: Code-Review+2 Forwarding Todd's +2 since the test

[kudu-CR] external mini cluster: don't pipe daemon subprocess stdout

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8187 ) Change subject: external_mini_cluster: don't pipe daemon subprocess stdout .. Removed reviewer Kudu Jenkins with the following vote

[kudu-CR] external mini cluster: don't pipe daemon subprocess stdout

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8187 ) Change subject: external_mini_cluster: don't pipe daemon subprocess stdout .. Patch Set 2: Verified+1 Overriding Jenkins, there was an unr

[kudu-CR] periodic: add one-shot timers

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. Patch Set 3: Verified+1 Overriding Jenkins, got clock synchronization errors in some of t

[kudu-CR] periodic: add one-shot timers

2017-10-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenk

[kudu-CR] subprocess: some cosmetic changes

2017-10-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: some cosmetic changes .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8157 T

[kudu-CR] mini-cluster: new module for the mini cluster implementations

2017-10-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8173 ) Change subject: mini-cluster: new module for the mini cluster implementations .. Patch Set 3: Code-Review+2 -- To view, visit http://ger