Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 )
Change subject: tool: add cluster shell action ...................................................................... Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/kudu-tool-test.cc@89 PS7, Line 89: #include "kudu/tools/tool_action_common.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/tool_action_common.h File src/kudu/tools/tool_action_common.h: http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/tool_action_common.h@39 PS7, Line 39: class faststring; > warning: invalid case style for class 'faststring' [readability-identifier- It's a forward declaration of an existing class... http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/tool_action_common.cc@38 PS7, Line 38: #include "kudu/client/client.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/tool_action_common.cc@148 PS7, Line 148: using tserver::TabletServerAdminServiceProxy; > warning: using decl 'TabletServerAdminServiceProxy' is unused [misc-unused- This is used in template specializations in this file. If I remove it, the build fails. http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/tool_action_common.cc@149 PS7, Line 149: using tserver::TabletServerServiceProxy; > warning: using decl 'TabletServerServiceProxy' is unused [misc-unused-using This is used in template specializations in this file. If I remove it, the build fails. http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/tool_action_test.cc File src/kudu/tools/tool_action_test.cc: http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/tool_action_test.cc@76 PS7, Line 76: using std::cin; > warning: using decl 'cin' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/tool_action_test.cc@77 PS7, Line 77: using std::cout; > warning: using decl 'cout' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/7853/7/src/kudu/tools/tool_action_test.cc@78 PS7, Line 78: using std::endl; > warning: using decl 'endl' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-Change-Number: 7853 Gerrit-PatchSet: 7 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 18:49:46 +0000 Gerrit-HasComments: Yes
