[kudu-CR] [location awareness] replica selection honors placement policy

2018-08-23 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11207 to look at the new patch set (#5). Change subject: [location_awareness] replica selection honors placement policy ...

[kudu-CR] [build] Move default sanitizer options into build from shell scripts

2018-08-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11176 ) Change subject: [build] Move default sanitizer options into build from shell scripts .. Patch Set 8: (3 comments) http://gerrit.cloude

[kudu-CR] [location awareness] replica selection honors placement policy

2018-08-23 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11207 to look at the new patch set (#4). Change subject: [location_awareness] replica selection honors placement policy ...

[kudu-CR] [location awareness] replica selection honors placement policy

2018-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 3: (30 comments) http://gerrit.cloudera.o

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-23 Thread Fengling Wang (Code Review)
Fengling Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11313 Change subject: [location_awareness] Add 'location' column in tserver list .. [location_awareness] Add 'location' column in tserver list

[kudu-CR] [cmake] add OpenSSL include path into -isystem

2018-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11311 ) Change subject: [cmake] add OpenSSL include path into -isystem .. [cmake] add OpenSSL include path into -isystem Prior to this

[kudu-CR] [cmake] add OpenSSL include path into -isystem

2018-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11311 ) Change subject: [cmake] add OpenSSL include path into -isystem .. Removed reviewer Kudu Jenkins with the following votes: * Ve

[kudu-CR] [cmake] add OpenSSL include path into -isystem

2018-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11311 ) Change subject: [cmake] add OpenSSL include path into -isystem .. Patch Set 2: Verified+1 Unrelated flake in: org.apache.kudu.spark.

[kudu-CR] deltafile-test: DeltaFileIterator fuzz test

2018-08-23 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11140 to look at the new patch set (#6). Change subject: deltafile-test: DeltaFileIterator fuzz test ...

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-23 Thread Greg Solovyev (Code Review)
Greg Solovyev has abandoned this change. ( http://gerrit.cloudera.org:8080/11312 ) Change subject: Add protobuf generated files to Eclipse project classpath. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/11312

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-23 Thread Greg Solovyev (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11310 to look at the new patch set (#3). Change subject: Add protobuf generated files to Eclipse project classpath. .

[kudu-CR] [cmake] add OpenSSL include path into -isystem

2018-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11311 ) Change subject: [cmake] add OpenSSL include path into -isystem .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-23 Thread Greg Solovyev (Code Review)
Hello Adar Dembo, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11312 to review the following change. Change subject: Add protobuf generated files to Eclipse project classpath. ...

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 ) Change subject: Add protobuf generated files to Eclipse project classpath. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] [cmake] add OpenSSL include path into -isystem

2018-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11311 ) Change subject: [cmake] add OpenSSL include path into -isystem .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11311

[kudu-CR] [cmake] add OpenSSL include path into -isystem

2018-08-23 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11311 to look at the new patch set (#2). Change subject: [cmake] add OpenSSL include path into -isystem .. [c

[kudu-CR] KUDU-428: Sentry integration scaffolding

2018-08-23 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11292 to look at the new patch set (#5). Change subject: KUDU-428: Sentry integration scaffolding ..

[kudu-CR] [cmake] add OpenSSL include path into -isystem

2018-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11311 ) Change subject: [cmake] add OpenSSL include path into -isystem .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11311/

[kudu-CR] [thirdparty] allow different URL prefix

2018-08-23 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11275 ) Change subject: [thirdparty] allow different URL prefix .. [thirdparty] allow different URL prefix This patch adds the option to all

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

2018-08-23 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11274 ) Change subject: [hms] update the HIVE/HADOOP package scripts .. [hms] update the HIVE/HADOOP package scripts This patch updates the

[kudu-CR] [cmake] add OpenSSL include path into -isystem

2018-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11311 ) Change subject: [cmake] add OpenSSL include path into -isystem .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11311/1/

[kudu-CR] [cmake] add OpenSSL include path into -isystem

2018-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11311 Change subject: [cmake] add OpenSSL include path into -isystem .. [cmake] add OpenSSL include path into -isystem Prior to this change,

[kudu-CR] [thirdparty] allow different URL prefix

2018-08-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11275 ) Change subject: [thirdparty] allow different URL prefix .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

2018-08-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 ) Change subject: [hms] update the HIVE/HADOOP package scripts .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] Enable iwyu on hms files

2018-08-23 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11301 ) Change subject: Enable iwyu on hms files .. Enable iwyu on hms files Change-Id: I7d4a5b23683b4fbec12fa86c24d997677ee3113a Review

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 ) Change subject: Add protobuf generated files to Eclipse project classpath. .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-23 Thread Greg Solovyev (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11310 to look at the new patch set (#2). Change subject: Add protobuf generated files to Eclipse project classpath. .

[kudu-CR] Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse

2018-08-23 Thread Greg Solovyev (Code Review)
Greg Solovyev has abandoned this change. ( http://gerrit.cloudera.org:8080/11307 ) Change subject: Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse ...

[kudu-CR] [build] Move default sanitizer options into build from shell scripts

2018-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11176 ) Change subject: [build] Move default sanitizer options into build from shell scripts .. Patch Set 8: (5 comments) http://gerrit.clouder

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-23 Thread Greg Solovyev (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11310 to review the following change. Change subject: Add protobuf generated files to Eclipse project classpath. .. Add pro

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

2018-08-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 ) Change subject: [hms] update the HIVE/HADOOP package scripts .. Patch Set 3: Remove -1 due to the flaky test. -- To view, visit http://ger

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

2018-08-23 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [hms] update the HIVE/HADOOP package scripts .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11274 To unsubscribe, visit ht

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

2018-08-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 ) Change subject: [hms] update the HIVE/HADOOP package scripts .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/1

[kudu-CR] Enable iwyu on hms files

2018-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11301 ) Change subject: Enable iwyu on hms files .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11301/1/src/kudu/

[kudu-CR] Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse

2018-08-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11307 ) Change subject: Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse

[kudu-CR] Enable iwyu on hms files

2018-08-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11301 ) Change subject: Enable iwyu on hms files .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11301/1/src/kudu/hms/hms_catal

[kudu-CR] Enable iwyu on hms files

2018-08-23 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11301 to look at the new patch set (#2). Change subject: Enable iwyu on hms files ..

[kudu-CR] Enable iwyu on hms files

2018-08-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11301 ) Change subject: Enable iwyu on hms files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11301/1/src/kudu/hms/hms_catal

[kudu-CR] Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse

2018-08-23 Thread Greg Solovyev (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11307 to review the following change. Change subject: Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run J

[kudu-CR] Enable iwyu on hms files

2018-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11301 ) Change subject: Enable iwyu on hms files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11301/1/src/kudu/hms/hms_catalo

[kudu-CR] [dist-test] Fix the descriptions of Java tests

2018-08-23 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11300 ) Change subject: [dist-test] Fix the descriptions of Java tests .. [dist-test] Fix the descriptions of Java tests Removes the ext

[kudu-CR] [dist-test] Fix the descriptions of Java tests

2018-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11300 ) Change subject: [dist-test] Fix the descriptions of Java tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] Enable iwyu on hms files

2018-08-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11301 ) Change subject: Enable iwyu on hms files .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11301 To unsubscri

[kudu-CR] Enable iwyu on hms files

2018-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11301 ) Change subject: Enable iwyu on hms files .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11301 To uns

[kudu-CR](gh-pages) [site] Add descriptions to the DOAP file

2018-08-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11287 ) Change subject: [site] Add descriptions to the DOAP file .. Patch Set 1: Verified+1 Code-Review+1 -- To view, visit http://gerrit.cloud

[kudu-CR](gh-pages) [site] Replace checksum links to sha512 in releases

2018-08-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11294 ) Change subject: [site] Replace checksum links to sha512 in releases .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://g

[kudu-CR] [WIP] KUDU-2245 Graceful leadership transfer

2018-08-23 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#4). Change subject: [WIP] KUDU-2245 Graceful leadership transfer

[kudu-CR] KUDU-2469 pt 1: add an IOContext

2018-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11248 ) Change subject: KUDU-2469 pt 1: add an IOContext .. Patch Set 2: Updated to pass the IOContext through args. -- To view, visit http://

[kudu-CR] bitmap: add equality method

2018-08-23 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: bitmap: add equality method .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11266 To unsubscribe, visit http://gerrit.c

[kudu-CR] bitmap: add equality method

2018-08-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 ) Change subject: bitmap: add equality method .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] WIP KUDU-2469 pt 2: fail replicas on CFile corruption

2018-08-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11249 to look at the new patch set (#3). Change subject: WIP KUDU-2469 pt 2: fail replicas on CFile corruption ..

[kudu-CR] WIP KUDU-2469 pt 2: fail replicas on CFile corruption

2018-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/11304 ) Change subject: WIP KUDU-2469 pt 2: fail replicas on CFile corruption .. Abandoned duplicate -- To view, visit http://gerrit.cloudera.org:8080/113

[kudu-CR] WIP KUDU-2469 pt 2: fail replicas on CFile corruption

2018-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11304 Change subject: WIP KUDU-2469 pt 2: fail replicas on CFile corruption .. WIP KUDU-2469 pt 2: fail replicas on CFile corruption wip: add t

[kudu-CR] error manager: rename error types

2018-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11303 Change subject: error_manager: rename error types .. error_manager: rename error types The previous ErrorHandlerType enum names weren't v

[kudu-CR] util: add once class based on std::call once

2018-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11302 Change subject: util: add once class based on std::call_once .. util: add once class based on std::call_once The existing KuduOnceDynamic

[kudu-CR] KUDU-2469 pt 1: add an IOContext

2018-08-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11248 to look at the new patch set (#2). Change subject: KUDU-2469 pt 1: add an IOContext ..

[kudu-CR] KUDU-428: Sentry integration scaffolding

2018-08-23 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11292 to look at the new patch set (#4). Change subject: KUDU-428: Sentry integration scaffolding ..

[kudu-CR] Enable iwyu on hms files

2018-08-23 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11301 to review the following change. Change subject: Enable iwyu on hms files .. Enable iwyu on hms files Chan

[kudu-CR] [dist-test] Fix the descriptions of Java tests

2018-08-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11300 ) Change subject: [dist-test] Fix the descriptions of Java tests .. Patch Set 1: You can see the effect of this patch here: http://dist-t

[kudu-CR] [build] Move default sanitizer options into build from shell scripts

2018-08-23 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11176 to look at the new patch set (#8). Change subject: [build] Move default sanitizer options into build from shell scripts ..

[kudu-CR] [dist-test] Fix the descriptions of Java tests

2018-08-23 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11300 Change subject: [dist-test] Fix the descriptions of Java tests .. [dist-test] Fix the descriptions of Java tests Removes the extra traili