[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. Patch Set 5: (4 comments) overall looks good, just a fe

[kudu-CR] Improve logging of maintenance ops

2018-08-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11367 ) Change subject: Improve logging of maintenance ops .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11367/2/src/kudu/tab

[kudu-CR] Improve logging of maintenance ops

2018-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11367 ) Change subject: Improve logging of maintenance ops .. Patch Set 2: (13 comments) looks good, just some nits http://gerrit.cloudera.o

[kudu-CR] Improve runtime of slow java client security test.

2018-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11365 ) Change subject: Improve runtime of slow java client security test. .. Patch Set 1: > Patch Set 1: > > (1 comment) > > This change would

[kudu-CR] Improve runtime of slow java client security test.

2018-08-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11365 ) Change subject: Improve runtime of slow java client security test. .. Patch Set 1: (1 comment) This change would be great to have as th

[kudu-CR] [tests] make master-stress-test more stable

2018-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11364 ) Change subject: [tests] make master-stress-test more stable .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11364/2/s

[kudu-CR] [tests] make master-stress-test more stable

2018-08-30 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11364 to look at the new patch set (#5). Change subject: [tests] make master-stress-test more stable ..

[kudu-CR] bitmap: add equality method

2018-08-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 ) Change subject: bitmap: add equality method .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11266 To un

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11361 ) Change subject: Add some additional info to ScanRequest traces .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11361/

[kudu-CR] bitmap: add equality method

2018-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 ) Change subject: bitmap: add equality method .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11266 To

[kudu-CR] [tests] make master-stress-test more stable

2018-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11364 ) Change subject: [tests] make master-stress-test more stable .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11364/2/

[kudu-CR] [tests] make master-stress-test more stable

2018-08-30 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11364 to look at the new patch set (#4). Change subject: [tests] make master-stress-test more stable ..

[kudu-CR] Improve logging of maintenance ops

2018-08-30 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11367 to look at the new patch set (#2). Change subject: Improve logging of maintenance ops ..

[kudu-CR] Improve logging of maintenance ops

2018-08-30 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11367 Change subject: Improve logging of maintenance ops .. Improve logging of maintenance ops MRS flushes and rowset compactions ===

[kudu-CR] bitmap: add equality method

2018-08-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 ) Change subject: bitmap: add equality method .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11266/4/src/kudu/util/bitmap

[kudu-CR] bitmap: add equality method

2018-08-30 Thread Adar Dembo (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11266 to look at the new patch set (#6). Change subject: bitmap: add equality method

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11361 ) Change subject: Add some additional info to ScanRequest traces .. Patch Set 4: Verified+1 Unrelated flake. -- To view, visit http://

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11361 ) Change subject: Add some additional info to ScanRequest traces .. Removed reviewer Kudu Jenkins with the following votes: * Ve

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11361 ) Change subject: Add some additional info to ScanRequest traces .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11361

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11361 ) Change subject: Add some additional info to ScanRequest traces .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11361

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11361 to look at the new patch set (#4). Change subject: Add some additional info to ScanRequest traces .

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11361 ) Change subject: Add some additional info to ScanRequest traces .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11361/

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11361 to look at the new patch set (#3). Change subject: Add some additional info to ScanRequest traces .

[kudu-CR] Improve runtime of slow java client security test.

2018-08-30 Thread Brian McDevitt (Code Review)
Brian McDevitt has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11365 Change subject: Improve runtime of slow java client security test. .. Improve runtime of slow java client security test. KUDU-2489 - S

[kudu-CR] [tests] make master-stress-test more stable

2018-08-30 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11364 to look at the new patch set (#3). Change subject: [tests] make master-stress-test more stable ..

[kudu-CR] bitmap: add equality method

2018-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 ) Change subject: bitmap: add equality method .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11266/4/src/kudu/util/bit

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11361 ) Change subject: Add some additional info to ScanRequest traces .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] [tests] make master-stress-test more stable

2018-08-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11364 ) Change subject: [tests] make master-stress-test more stable .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/11364/2//CO

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-30 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11313 to look at the new patch set (#5). Change subject: [location_awareness] Add 'location' column in tserver list .

[kudu-CR] [tests] make master-stress-test more stable

2018-08-30 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11364 to look at the new patch set (#2). Change subject: [tests] make master-stress-test more stable ..

[kudu-CR] [tests] make master-stress-test more stable

2018-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11364 Change subject: [tests] make master-stress-test more stable .. [tests] make master-stress-test more stable The master-stress-test has b

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 4: I like the article. One thing I think we should so is m

[kudu-CR] KUDU-2469 pt 2: fail replicas on CFile corruption

2018-08-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11249 ) Change subject: KUDU-2469 pt 2: fail replicas on CFile corruption .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/11249

[kudu-CR] update public api.

2018-08-30 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/11126 ) Change subject: update public api. .. Abandoned I'm guessing this has been superceded by https://gerrit.cloudera.org/c/11333/1; please reopen if I

[kudu-CR] KUDU-2529 add a "-tables=" flag to the "kudu table list".

2018-08-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11360 ) Change subject: KUDU-2529 add a "-tables=" flag to the "kudu table list". .. Patch Set 1: (4 comments) Can you add a new test to kudu-t

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-08-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11029 ) Change subject: deltamemstore: support iteration with snap_to_exclude .. Patch Set 11: Code-Review-2 Don't merge; I've found an issue wit

[kudu-CR] bitmap: add equality method

2018-08-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 ) Change subject: bitmap: add equality method .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11266/4/src/kudu/util/bitma

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11361 ) Change subject: Add some additional info to ScanRequest traces .. Patch Set 2: Code-Review+1 great idea, thanks for doing this -- To v

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Will Berkeley (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11361 to look at the new patch set (#2). Change subject: Add some additional info to ScanRequest traces ..

[kudu-CR] Add some additional info to ScanRequest traces

2018-08-30 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11361 Change subject: Add some additional info to ScanRequest traces .. Add some additional info to ScanRequest traces This patch makes two i

[kudu-CR] KUDU-428: add Sentry to thirdparty, mini-sentry

2018-08-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11347 ) Change subject: KUDU-428: add Sentry to thirdparty, mini-sentry .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11347/

[kudu-CR] KUDU-2469 pt 2: fail replicas on CFile corruption

2018-08-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11249 ) Change subject: KUDU-2469 pt 2: fail replicas on CFile corruption .. Patch Set 9: (10 comments) http://gerrit.cloudera.org:8080/#/c/1124

[kudu-CR] KUDU-2469 pt 2: fail replicas on CFile corruption

2018-08-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11249 ) Change subject: KUDU-2469 pt 2: fail replicas on CFile corruption .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/1124

[kudu-CR] KUDU-2469 pt 2: fail replicas on CFile corruption

2018-08-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11249 ) Change subject: KUDU-2469 pt 2: fail replicas on CFile corruption .. Patch Set 9: (5 comments) I did a quick first pass. The theme of m

[kudu-CR] KUDU-2529 add a "-tables=" flag to the "kudu table list".

2018-08-30 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11360 Change subject: KUDU-2529 add a "-tables=" flag to the "kudu table list". .. KUDU-2529 add a "-tables=" flag to the "kudu table list". Change