[kudu-CR] mini cluster: Add scripts to build binaries for testing use

2018-09-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11377 ) Change subject: mini cluster: Add scripts to build binaries for testing use .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-09-05 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11394 to review the following change. Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

[kudu-CR] deltafile-test: DeltaFileIterator fuzz test

2018-09-05 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11140 to look at the new patch set (#8). Change subject: deltafile-test: DeltaFileIterator fuzz test

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-09-05 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11395 to review the following change. Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

[kudu-CR] Add delete external catalogs flag to table delete tool

2018-09-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11197 ) Change subject: Add delete_external_catalogs flag to table delete tool .. Patch Set 3: (7 comments)

[kudu-CR] Add delete external catalogs flag to table delete tool

2018-09-05 Thread Hao Hao (Code Review)
Hello Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11197 to look at the new patch set (#3). Change subject: Add delete_external_catalogs flag to table delete tool

[kudu-CR] Add delete external catalogs flag to table delete tool

2018-09-05 Thread Hao Hao (Code Review)
Hello Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11197 to look at the new patch set (#2). Change subject: Add delete_external_catalogs flag to table delete tool

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 7: (20 comments)

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-05 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11207 to look at the new patch set (#8). Change subject: [location_awareness] replica selection honors placement policy

[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.

2018-09-05 Thread Ferenc Szabo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11391 to look at the new patch set (#3). Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.

[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.

2018-09-05 Thread Ferenc Szabo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11391 to look at the new patch set (#2). Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.

[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.

2018-09-05 Thread Ferenc Szabo (Code Review)
Ferenc Szabo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11391 Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer. .. KUDU-1882 Configuration

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 7: (21 comments) Just small things and I

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-05 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11360 ) Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list". .. KUDU-2529: Add a "-tables=" flag to the "kudu

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-09-05 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. [location_awareness] Add 'location' column in

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11360 ) Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list". .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-09-05 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11360 to look at the new patch set (#8). Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list".

[kudu-CR] cfile-test: pass in IOContext on Open()

2018-09-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11389 ) Change subject: cfile-test: pass in IOContext on Open() .. Patch Set 2: > > Patch Set 1: Code-Review+2 > > > > I'm curious why ASAN

[kudu-CR] cfile-test: pass in IOContext on Open()

2018-09-05 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11389 ) Change subject: cfile-test: pass in IOContext on Open() .. cfile-test: pass in IOContext on Open() Previously, on certain

[kudu-CR] cfile-test: pass in IOContext on Open()

2018-09-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11389 ) Change subject: cfile-test: pass in IOContext on Open() .. Patch Set 1: > Patch Set 1: Code-Review+2 > > I'm curious why ASAN