[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-12 Thread Anonymous Coward (Code Review)
jinxing6...@126.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/11333 ) Change subject: [KUDU-2521] Java Implementation for BloomFilter .. Patch Set 7: (2 comments)

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-12 Thread Anonymous Coward (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11333 to look at the new patch set (#7). Change subject: [KUDU-2521] Java Implementation for BloomFilter

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-12 Thread Anupama Gupta (Code Review)
Anupama Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 7: (13 comments) Many thanks for the comments. Please

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-12 Thread Anupama Gupta (Code Review)
Hello Alexey Serbin, Mike Percy, Attila Bukor, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11263 to look at the new patch set (#7). Change subject: Blogpost describing index skip scan optimization.

[kudu-CR] [tests] minor cleanup on BadTabletCopyITest

2018-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11434 ) Change subject: [tests] minor cleanup on BadTabletCopyITest .. [tests] minor cleanup on BadTabletCopyITest Added missing

[kudu-CR] [tests] minor cleanup on BadTabletCopyITest

2018-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11434 ) Change subject: [tests] minor cleanup on BadTabletCopyITest .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 12: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 12: Code-Review+1 -- To view, visit

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-12 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11207 to look at the new patch set (#12). Change subject: [location_awareness] replica selection honors placement policy

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 11: (3 comments)

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 11: LGTM besides Adar's comments. -- To

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 11: (3 comments)

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-12 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11207 to look at the new patch set (#11). Change subject: [location_awareness] replica selection honors placement policy

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 4: (1 comment)

[kudu-CR] [docs] Add basic advice on setting block cache size

2018-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11420 ) Change subject: [docs] Add basic advice on setting block cache size .. Patch Set 1: (5 comments)

[kudu-CR] common: add equality methods to ColumnBlock and SelectionVector

2018-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11267 ) Change subject: common: add equality methods to ColumnBlock and SelectionVector .. Removed reviewer Kudu Jenkins with the

[kudu-CR] common: add equality methods to ColumnBlock and SelectionVector

2018-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11267 ) Change subject: common: add equality methods to ColumnBlock and SelectionVector .. Patch Set 5: Verified+1 Overriding Jenkins, unrelated

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-09-12 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11395 to look at the new patch set (#3). Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11395 ) Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. Patch Set 3: (6 comments)

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-09-12 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11394 to look at the new patch set (#3). Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11333 ) Change subject: [KUDU-2521] Java Implementation for BloomFilter .. Patch Set 6: (16 comments)

[kudu-CR] [docs] Add basic advice on setting block cache size

2018-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11420 ) Change subject: [docs] Add basic advice on setting block cache size .. Patch Set 1: (3 comments)

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-09-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11395 ) Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. Patch Set 2: (6 comments) I'm working through this

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-12 Thread Anonymous Coward (Code Review)
jinxing6...@126.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/11333 ) Change subject: [KUDU-2521] Java Implementation for BloomFilter .. Patch Set 6: (3 comments)

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-12 Thread Anonymous Coward (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11333 to look at the new patch set (#6). Change subject: [KUDU-2521] Java Implementation for BloomFilter

[kudu-CR] [iwyu] add catalog manager.{cc,h} files

2018-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11430 ) Change subject: [iwyu] add catalog_manager.{cc,h} files .. [iwyu] add catalog_manager.{cc,h} files Removed

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 1: (6 comments)

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR] Supporting Spark streaming DataFrame in KuduContext.

2018-09-12 Thread Attila Piros (Code Review)
Attila Piros has posted comments on this change. ( http://gerrit.cloudera.org:8080/11199 ) Change subject: Supporting Spark streaming DataFrame in KuduContext. .. Patch Set 5: Gentle ping. Is there any new comments? -- To

[kudu-CR] KUDU-2463 pt 2: adjust MVCC on Raft no-op

2018-09-12 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11427 to look at the new patch set (#2). Change subject: KUDU-2463 pt 2: adjust MVCC on Raft no-op ..

[kudu-CR] KUDU-2463 pt 3: don't scan if MVCC hasn't moved

2018-09-12 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11428 to look at the new patch set (#2). Change subject: KUDU-2463 pt 3: don't scan if MVCC hasn't moved ..

[kudu-CR] [catalog manager] optimization in AsyncAddReplicaTask

2018-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11429 ) Change subject: [catalog_manager] optimization in AsyncAddReplicaTask .. [catalog_manager] optimization in AsyncAddReplicaTask

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 7: (14 comments) Few more nits.

[kudu-CR] [iwyu] add catalog manager.{cc,h} files

2018-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11430 ) Change subject: [iwyu] add catalog_manager.{cc,h} files .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [iwyu] add catalog manager.{cc,h} files

2018-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11430 Change subject: [iwyu] add catalog_manager.{cc,h} files .. [iwyu] add catalog_manager.{cc,h} files Removed catalog_manager.{cc,h}

[kudu-CR] [catalog manager] optimization in AsyncAddReplicaTask

2018-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11429 ) Change subject: [catalog_manager] optimization in AsyncAddReplicaTask .. Patch Set 2: Code-Review+2 -- To view, visit