Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11420 )
Change subject: [docs] Add basic advice on setting block cache size ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11420/1/docs/troubleshooting.adoc File docs/troubleshooting.adoc: http://gerrit.cloudera.org:8080/#/c/11420/1/docs/troubleshooting.adoc@538 PS1, Line 538: as a percentage of `--memory_limit_hard_bytes` Hrm, at first glance I read this as either: - the block cache shouldn't be larger than 1% of --memory_limit_hard_bytes, or - there is some percentage of --memory_limit_hard_bytes at which setting the block cache size would be bad Since this is clarified below, maybe just, "(see below)"? http://gerrit.cloudera.org:8080/#/c/11420/1/docs/troubleshooting.adoc@557 PS1, Line 557: metricz metrics? http://gerrit.cloudera.org:8080/#/c/11420/1/docs/troubleshooting.adoc@602 PS1, Line 602: `block_cache_evictions` metric is significant compared to `block_cache_inserts` I'm trying to think of a case where this isn't true, but the above is true. I.e. where there isn't a lot of churn in the block cache and it's near capacity, but there are a lot of cache misses. That shouldn't happen, right? -- To view, visit http://gerrit.cloudera.org:8080/11420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc7411c38b6fcc8694509ec89c32e2fe74e6c0db Gerrit-Change-Number: 11420 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 12 Sep 2018 18:33:56 +0000 Gerrit-HasComments: Yes
