[kudu-CR] wip sentry: sanitize and parse privileges from Sentry

2019-04-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12919 ) Change subject: wip sentry: sanitize and parse privileges from Sentry .. wip sentry: sanitize and parse privileges from Sentry wip: I

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-02 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12833 to look at the new patch set (#7). Change subject: WIP [master] introduced SentryPrivilegesFetcher

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryPrivilegesFetcher .. Patch Set 6: (7 comments)

[kudu-CR] WIP: [backup] Add incremental backup/restore support

2019-04-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: WIP: [backup] Add incremental backup/restore support .. Patch Set 1: This looks good. To address the potential conflict

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-02 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 2: (3 comments)

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 1: Verified+1 Overriding Jenkins.

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Removed reviewer Kudu Jenkins with the

[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 ) Change subject: java: ensure KuduTestHarness or RetryRule in every test .. Patch Set 6: Verified+1 Overriding Jenkins, hit KUDU-2432.

[kudu-CR] java: add support for flaky test reporting

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] java: add support for flaky test reporting

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. Patch Set 9: Verified+1 Overriding Jenkins, unrelated test failure. --

[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12872 ) Change subject: java: ensure KuduTestHarness or RetryRule in every test .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] KUDU-2757: retry OpenSSL downloads

2019-04-02 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12913 ) Change subject: KUDU-2757: retry OpenSSL downloads .. KUDU-2757: retry OpenSSL downloads Commit 3bdc32054 added retry for

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 1: Here's what I manually tested:

[kudu-CR] java: add support for flaky test reporting

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#9) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. java: add support for flaky

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-02 Thread Adar Dembo (Code Review)
Hello Mike Percy, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12917 to review the following change. Change subject: build: adapt new Java flaky test infrastructure to existing controls

[kudu-CR] KUDU-2757: retry OpenSSL downloads

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12913 ) Change subject: KUDU-2757: retry OpenSSL downloads .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2757: retry OpenSSL downloads

2019-04-02 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12913 ) Change subject: KUDU-2757: retry OpenSSL downloads .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12913/1//COMMIT_MSG

[kudu-CR] KUDU-2757: retry OpenSSL downloads

2019-04-02 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12913 to look at the new patch set (#2). Change subject: KUDU-2757: retry OpenSSL downloads ..

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12912 ) Change subject: [master_sentry-itest] add description into AuthzFuncs .. Patch Set 4: (1 comment)

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12912 ) Change subject: [master_sentry-itest] add description into AuthzFuncs .. Patch Set 3: (1 comment)

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12912 ) Change subject: [master_sentry-itest] add description into AuthzFuncs .. [master_sentry-itest] add description into AuthzFuncs

[kudu-CR] KUDU-2757: retry OpenSSL downloads

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12913 ) Change subject: KUDU-2757: retry OpenSSL downloads .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12913/1//COMMIT_MSG

[kudu-CR] KUDU-2757: retry OpenSSL downloads

2019-04-02 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12913 Change subject: KUDU-2757: retry OpenSSL downloads .. KUDU-2757: retry OpenSSL downloads Commit 3bdc32054 added retry for thirdparty

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12912 ) Change subject: [master_sentry-itest] add description into AuthzFuncs .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12912 ) Change subject: [master_sentry-itest] add description into AuthzFuncs .. Patch Set 2: Verified+1 unrelated flake in

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Alexey Serbin (Code Review)
Hello Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12912 to look at the new patch set (#3). Change subject: [master_sentry-itest] add description into AuthzFuncs

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12912 ) Change subject: [master_sentry-itest] add description into AuthzFuncs .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12912 ) Change subject: [master_sentry-itest] add description into AuthzFuncs .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12912 to look at the new patch set (#2). Change subject: [master_sentry-itest] add description into AuthzFuncs

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12912 ) Change subject: [master_sentry-itest] add description into AuthzFuncs .. Patch Set 1: (1 comment)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 2: (3 comments)

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12912 ) Change subject: [master_sentry-itest] add description into AuthzFuncs .. Patch Set 1: (1 comment)

[kudu-CR] [master sentry-itest] add description into AuthzFuncs

2019-04-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12912 Change subject: [master_sentry-itest] add description into AuthzFuncs .. [master_sentry-itest] add description into AuthzFuncs Added

[kudu-CR] [TS heartbeater] avoid reconnecting to master too often

2019-04-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12647 ) Change subject: [TS heartbeater] avoid reconnecting to master too often .. [TS heartbeater] avoid reconnecting to master too

[kudu-CR] [TS heartbeater] avoid reconnecting to master too often

2019-04-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12647 ) Change subject: [TS heartbeater] avoid reconnecting to master too often .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test

2019-04-02 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 ) Change subject: java: ensure KuduTestHarness or RetryRule in every test .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] java: add support for flaky test reporting

2019-04-02 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] build: enable Java flaky test reporting

2019-04-02 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 ) Change subject: build: enable Java flaky test reporting .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-02 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#2). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java: ColumnSchema supports storing column comment

2019-04-02 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java: ColumnSchema supports storing column comment .. Patch Set 1: (14 comments)