[kudu-CR] sentry: sanitize and parse privileges from Sentry

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 3: > Overall looks good to me structurally, some nits a

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryPrivilegesFetcher .. Patch Set 8: > Uploaded patch set 8. I'm thinking to significantly

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12833 to look at the new patch set (#8). Change subject: WIP [master] introduced SentryPrivilegesFetcher .

[kudu-CR] java/c++: ColumnSchema supports storing column comment

Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#8). Change subject: java/c++: ColumnSchema supports storing column comment .

[kudu-CR] java/c++: ColumnSchema supports storing column comment

helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 7: Yeah, i will rebase on master after this modification.

[kudu-CR] java/c++: ColumnSchema supports storing column comment

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 7: Oh, I think you still need to rebase. -- To vie

[kudu-CR] java/c++: ColumnSchema supports storing column comment

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 7: Code-Review+1 LGTM but I will let Adar review too

[kudu-CR] java/c++: ColumnSchema supports storing column comment

helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/1289

[kudu-CR] java/c++: ColumnSchema supports storing column comment

Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#7). Change subject: java/c++: ColumnSchema supports storing column comment .

[kudu-CR] sentry: sanitize and parse privileges from Sentry

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/12

[kudu-CR] sentry: sanitize and parse privileges from Sentry

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 3: Overall looks good to me structurally, some nits and

[kudu-CR] util: pull Random methods out from tests

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] util: pull Random methods out from tests

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12918/5/src/ku

[kudu-CR] sentry: sanitize and parse privileges from Sentry

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 3: (6 comments) a few comments, more are coming http:

[kudu-CR] util: pull Random methods out from tests

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12918/5/src/kud

[kudu-CR] util: pull Random methods out from tests

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12918/3/src/ku

[kudu-CR] util: pull Random methods out from tests

Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12918 to look at the new patch set (#5). Change subject: util: pull Random methods out from tests ...

[kudu-CR] util: pull Random methods out from tests

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12918/3/src/kud

[kudu-CR] util: pull Random methods out from tests

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12918/3/src/k

[kudu-CR] util: pull Random methods out from tests

Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12918 to look at the new patch set (#4). Change subject: util: pull Random methods out from tests ...

[kudu-CR] dist test.py: support --collect-tmpdir in Java tests

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12924 ) Change subject: dist_test.py: support --collect-tmpdir in Java tests .. Patch Set 2: Verified+1 Overriding Jenkins, more flakes. -- To

[kudu-CR] dist test.py: support --collect-tmpdir in Java tests

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12924 ) Change subject: dist_test.py: support --collect-tmpdir in Java tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] dist test.py: support --collect-tmpdir in Java tests

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12924 ) Change subject: dist_test.py: support --collect-tmpdir in Java tests .. dist_test.py: support --collect-tmpdir in Java tests KUDU

[kudu-CR] dist test.py: support --collect-tmpdir in Java tests

Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12924 ) Change subject: dist_test.py: support --collect-tmpdir in Java tests .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] dist test.py: support --collect-tmpdir in Java tests

Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12924 to look at the new patch set (#2). Change subject: dist_test.py: support --collect-tmpdir in Java tests ...

[kudu-CR](branch-1.9.x) [docs] Update known issues docs for location awareness

Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12925 ) Change subject: [docs] Update known issues docs for location awareness .. [docs] Update known issues docs for location awareness

[kudu-CR](branch-1.9.x) [docs] Update known issues docs for location awareness

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12925 ) Change subject: [docs] Update known issues docs for location awareness .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR](branch-1.9.x) [docs] Update known issues docs for location awareness

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12925 ) Change subject: [docs] Update known issues docs for location awareness .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloud

[kudu-CR] [docs] Update known issues docs for location awareness

Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12920 ) Change subject: [docs] Update known issues docs for location awareness .. [docs] Update known issues docs for location awareness

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 4: Code-Review+2 (1 comment) http://

[kudu-CR](branch-1.9.x) [docs] Update known issues docs for location awareness

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12925 Change subject: [docs] Update known issues docs for location awareness .. [docs] Update known issues docs for location awareness Removes

[kudu-CR] wip sentry: generate authz tokens

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12897 ) Change subject: wip sentry: generate authz tokens .. Patch Set 1: (5 comments) I need to rebase this on top of https://gerrit.cloudera.

[kudu-CR] [docs] Update known issues docs for location awareness

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12920 ) Change subject: [docs] Update known issues docs for location awareness .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] dist test.py: support --collect-tmpdir in Java tests

Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12924 to review the following change. Change subject: dist_test.py: support --collect-tmpdir in Java tests .. dist_test.py:

[kudu-CR] java/c++: ColumnSchema supports storing column comment

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 6: Note: This has a merge conflict. You should rebas

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. build: adapt new Java flaky test infrastr

[kudu-CR] build: enable Java flaky test reporting

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12043 ) Change subject: build: enable Java flaky test reporting .. build: enable Java flaky test reporting This patch moves flaky test en

[kudu-CR] java: add support for flaky test reporting

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. java: add support for flaky test reporting This patch hooks into th

[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12872 ) Change subject: java: ensure KuduTestHarness or RetryRule in every test .. java: ensure KuduTestHarness or RetryRule in every test

[kudu-CR] [docs] Update known issues docs for location awareness

Grant Henke has removed a vote on this change. Change subject: [docs] Update known issues docs for location awareness .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12920 To unsubsc

[kudu-CR] [docs] Update known issues docs for location awareness

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12920 ) Change subject: [docs] Update known issues docs for location awareness .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloud

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 3: Verified+1 More unknown Java flakes

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Removed reviewer Kudu Jenkins with the fo

[kudu-CR] [docs] Update known issues docs for location awareness

Hello Will Berkeley, Alex Rodoni, Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12920 to look at the new patch set (#2). Change subject: [docs] Update known issues docs for location awareness .

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 3: Code-Review+2 -- To view, visit h

[kudu-CR] add document for KUDU-2080

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12774 ) Change subject: add document for KUDU-2080 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/12774 To uns

[kudu-CR] [docs] Update known issues docs for location awarness

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12920 ) Change subject: [docs] Update known issues docs for location awarness .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Hello Mike Percy, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12917 to look at the new patch set (#3). Change subject: build: adapt new Java flaky test infrastructure to existing controls ...

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 1: (1 comment) http://gerrit.clouder

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 3: (1 comment) http://gerrit.cloudera

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 2: Code-Review+2 -- To view, visit h

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 2: Verified+1 A Java test failed, but

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Removed reviewer Kudu Jenkins with the fo

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Hello Mike Percy, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12917 to look at the new patch set (#2). Change subject: build: adapt new Java flaky test infrastructure to existing controls ...

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 1: (6 comments) http://gerrit.clouder

[kudu-CR] util: pull Random methods out from tests

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12918/3/src/ku

[kudu-CR] util: pull Random methods out from tests

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12918/3/src/ku

[kudu-CR] [metrics] Remove incorrect comments

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12921 ) Change subject: [metrics] Remove incorrect comments .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12921/1//COMMIT_MSG

[kudu-CR] [docs] Update known issues docs for location awarness

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12920 ) Change subject: [docs] Update known issues docs for location awarness .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [metrics] Remove incorrect comments

Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12921 Change subject: [metrics] Remove incorrect comments .. [metrics] Remove incorrect comments Data store in std::map with key type 'const c

[kudu-CR] util: pull Random methods out from tests

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12918 to look at the new patch set (#3). Change subject: util: pull Random methods out from tests .. util: pull Random me

[kudu-CR] sentry: sanitize and parse privileges from Sentry

Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#3). Change subject: sentry: sanitize and parse privileges from Sentry .. s

[kudu-CR] [docs] Update known issues docs for location awarness

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12920 ) Change subject: [docs] Update known issues docs for location awarness .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] [docs] Update known issues docs for location awarness

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12920 Change subject: [docs] Update known issues docs for location awarness .. [docs] Update known issues docs for location awarness Removes th

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 1: (6 comments) http://gerrit.cloude

[kudu-CR] java: add support for flaky test reporting

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] build: enable Java flaky test reporting

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 ) Change subject: build: enable Java flaky test reporting .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 ) Change subject: java: ensure KuduTestHarness or RetryRule in every test .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.c

[kudu-CR] java/c++: ColumnSchema supports storing column comment

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 6: (5 comments) Thank you for all the work on this

[kudu-CR] java/c++: ColumnSchema supports storing column comment

Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#6). Change subject: java/c++: ColumnSchema supports storing column comment .

[kudu-CR] java/c++: ColumnSchema supports storing column comment

Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#5). Change subject: java/c++: ColumnSchema supports storing column comment .

[kudu-CR] java/c++: ColumnSchema supports storing column comment

helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/1289

[kudu-CR] java/c++: ColumnSchema supports storing column comment

helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 4: Sorry for quickly retriggering the builder :( -- To

[kudu-CR] java/c++: ColumnSchema supports storing column comment

Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#4). Change subject: java/c++: ColumnSchema supports storing column comment .

[kudu-CR] java/c++: ColumnSchema supports storing column comment

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] java/c++: ColumnSchema supports storing column comment

Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#3). Change subject: java/c++: ColumnSchema supports storing column comment .