[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13657 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloude

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-06-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 4: Verified+1 Unrelated flake: TestLeaderStepDown.TestLeaderS

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-06-14 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [metrics] Merge metrics by the same attribute .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13580 To unsubscribe, vis

[kudu-CR] [test] Remove unused variables

2019-06-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13658 ) Change subject: [test] Remove unused variables .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13658 To

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13657 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] [test] Remove unused variables

2019-06-14 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13658 Change subject: [test] Remove unused variables .. [test] Remove unused variables Change-Id: I5b96dd87c2f189659f6a0e89c6fd2a54f00933fa --- M sr

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13657 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/1365

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13657 to look at the new patch set (#3). Change subject: [sentry] add require_db_privileges flag for ListTables .

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13657 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13657 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/136

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13657 to look at the new patch set (#2). Change subject: [sentry] add require_db_privileges flag for ListTables .

[kudu-CR] [sentry] Add ListPrivilegesByAuthorizablesAndUser sentry client API

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/13599 ) Change subject: [sentry] Add ListPrivilegesByAuthorizablesAndUser sentry client API .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/135

[kudu-CR] wip: [sentry] use bulk Sentry API for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13600 ) Change subject: wip: [sentry] use bulk Sentry API for ListTables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13600/2//C

[kudu-CR] wip: [sentry] use bulk Sentry API for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/13600 ) Change subject: wip: [sentry] use bulk Sentry API for ListTables .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13600 To unsubscribe, v

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13657 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR](branch-1.10.x) Bump version to 1.10.0 (non-SNAPSHOT)

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13656 ) Change subject: Bump version to 1.10.0 (non-SNAPSHOT) .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/1365

[kudu-CR](branch-1.10.x) Bump version to 1.10.0 (non-SNAPSHOT)

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13656 ) Change subject: Bump version to 1.10.0 (non-SNAPSHOT) .. Bump version to 1.10.0 (non-SNAPSHOT) Change-Id: If4c9014deb9d5958bf97d

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13657 Change subject: [sentry] add require_db_privileges flag for ListTables .. [sentry] add require_db_privileges flag for ListTables This patch a

[kudu-CR](branch-1.10.x) Bump version to 1.10.0 (non-SNAPSHOT)

2019-06-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13656 ) Change subject: Bump version to 1.10.0 (non-SNAPSHOT) .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1

[kudu-CR] Bump version to 1.10.0 (non-SNAPSHOT)

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has abandoned this change. ( http://gerrit.cloudera.org:8080/13655 ) Change subject: Bump version to 1.10.0 (non-SNAPSHOT) .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13655 To unsubscribe, visit ht

[kudu-CR] Bump version to 1.10.0 (non-SNAPSHOT)

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13655 Change subject: Bump version to 1.10.0 (non-SNAPSHOT) .. Bump version to 1.10.0 (non-SNAPSHOT) Change-Id: If4c9014deb9d5958bf97dbb6229bb2

[kudu-CR](branch-1.10.x) Bump version to 1.10.0 (non-SNAPSHOT)

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13656 Change subject: Bump version to 1.10.0 (non-SNAPSHOT) .. Bump version to 1.10.0 (non-SNAPSHOT) Change-Id: If4c9014deb9d5958bf97dbb6229bb2

[kudu-CR](branch-1.10.x) Optimize and sort imports

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13654 ) Change subject: Optimize and sort imports .. Optimize and sort imports I ran IntelliJ's "Optimize imports" function on the kudu-

[kudu-CR](branch-1.10.x) Optimize and sort imports

2019-06-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13654 ) Change subject: Optimize and sort imports .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13654 To un

[kudu-CR](branch-1.10.x) [java] Favor column ids over column names in scan tokens

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13646 ) Change subject: [java] Favor column ids over column names in scan tokens .. [java] Favor column ids over column names in scan tok

[kudu-CR](branch-1.10.x) Optimize and sort imports

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13654 Change subject: Optimize and sort imports .. Optimize and sort imports I ran IntelliJ's "Optimize imports" function on the kudu-client mo

[kudu-CR](branch-1.10.x) [java] Favor column ids over column names in scan tokens

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13646 ) Change subject: [java] Favor column ids over column names in scan tokens .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] Optimize and sort imports

2019-06-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13642 ) Change subject: Optimize and sort imports .. Patch Set 3: Verified+1 Unrelated failures in C++ tests. Something funny is going on with

[kudu-CR] Optimize and sort imports

2019-06-14 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13642 ) Change subject: Optimize and sort imports .. Optimize and sort imports I ran IntelliJ's "Optimize imports" function on the kud

[kudu-CR] Optimize and sort imports

2019-06-14 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: Optimize and sort imports .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13642 To unsubscribe, visit http://gerrit.c

[kudu-CR](branch-1.10.x) [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13643 ) Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped .. [java] Add

[kudu-CR](branch-1.10.x) thrift: follow-up to 327be47820dcaba358095f118e516a5e92621a59

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13651 ) Change subject: thrift: follow-up to 327be47820dcaba358095f118e516a5e92621a59 .. thrift: follow-up to 327be47820dcaba358095f118e5

[kudu-CR](branch-1.10.x) [k8s] Improve helm chart testing

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13652 ) Change subject: [k8s] Improve helm chart testing .. [k8s] Improve helm chart testing Adds documentation for helm chart testing a

[kudu-CR](branch-1.10.x) [k8s] Improve helm chart testing

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13652 ) Change subject: [k8s] Improve helm chart testing .. Patch Set 1: Verified+1 Code-Review+2 Manually verifying since there is no automated

[kudu-CR] [k8s] Improve helm chart testing

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 ) Change subject: [k8s] Improve helm chart testing .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13641 To

[kudu-CR] [k8s] Improve helm chart testing

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13641 ) Change subject: [k8s] Improve helm chart testing .. [k8s] Improve helm chart testing Adds documentation for helm chart testing a

[kudu-CR] [k8s] Improve helm chart testing

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 ) Change subject: [k8s] Improve helm chart testing .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13641

[kudu-CR](branch-1.10.x) [k8s] Improve helm chart testing

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13652 Change subject: [k8s] Improve helm chart testing .. [k8s] Improve helm chart testing Adds documentation for helm chart testing and lintin

[kudu-CR] [k8s] Improve helm chart testing

2019-06-14 Thread Sandish Kumar HN (Code Review)
Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 ) Change subject: [k8s] Improve helm chart testing .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13641/2/kubernete

[kudu-CR] [k8s] Improve helm chart testing

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 ) Change subject: [k8s] Improve helm chart testing .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13641/2/kubernetes/hel

[kudu-CR] [k8s] Improve helm chart testing

2019-06-14 Thread Sandish Kumar HN (Code Review)
Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 ) Change subject: [k8s] Improve helm chart testing .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13641/2/kubernete

[kudu-CR] [k8s] Improve helm chart testing

2019-06-14 Thread Sandish Kumar HN (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13641 to look at the new patch set (#3). Change subject: [k8s] Improve helm chart testing .. [k8s] Improve h

[kudu-CR](branch-1.10.x) thrift: follow-up to 327be47820dcaba358095f118e516a5e92621a59

2019-06-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13651 ) Change subject: thrift: follow-up to 327be47820dcaba358095f118e516a5e92621a59 .. Patch Set 1: Code-Review+2 -- To view, visit http://ge

[kudu-CR] Testing helm charts,

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 ) Change subject: Testing helm charts, .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13641/2//COMMIT_MSG Commit Messag

[kudu-CR](branch-1.10.x) KUDU-2846 (part 2): optimize IS [NOT] NULL predicates

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13650 ) Change subject: KUDU-2846 (part 2): optimize IS [NOT] NULL predicates .. KUDU-2846 (part 2): optimize IS [NOT] NULL predicates T

[kudu-CR](branch-1.10.x) KUDU-2846 (part 2): optimize IS [NOT] NULL predicates

2019-06-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13650 ) Change subject: KUDU-2846 (part 2): optimize IS [NOT] NULL predicates .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.c

[kudu-CR](branch-1.10.x) [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped

2019-06-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13643 ) Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped .. Patch Set 2: Cod

[kudu-CR](branch-1.10.x) [java] Favor column ids over column names in scan tokens

2019-06-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13646 ) Change subject: [java] Favor column ids over column names in scan tokens .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] Optimize and sort imports

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13642 ) Change subject: Optimize and sort imports .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13642 To unsu

[kudu-CR] Optimize and sort imports

2019-06-14 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13642 to look at the new patch set (#3). Change subject: Optimize and sort imports .. Optimize and sort impo

[kudu-CR](branch-1.10.x) KUDU-2846 (part 2): optimize IS [NOT] NULL predicates

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: KUDU-2846 (part 2): optimize IS [NOT] NULL predicates .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13650 To unsubscri

[kudu-CR](branch-1.10.x) KUDU-2846 (part 2): optimize IS [NOT] NULL predicates

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13650 ) Change subject: KUDU-2846 (part 2): optimize IS [NOT] NULL predicates .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloude

[kudu-CR](branch-1.10.x) KUDU-2846 (part 2): optimize IS [NOT] NULL predicates

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: KUDU-2846 (part 2): optimize IS [NOT] NULL predicates .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13650 To unsubscr

[kudu-CR](branch-1.10.x) thrift: follow-up to 327be47820dcaba358095f118e516a5e92621a59

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13651 Change subject: thrift: follow-up to 327be47820dcaba358095f118e516a5e92621a59 .. thrift: follow-up to 327be47820dcaba358095f118e516a5e9262

[kudu-CR](branch-1.10.x) KUDU-2850: fix thrift comparison

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13636 ) Change subject: KUDU-2850: fix thrift comparison .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13636

[kudu-CR](branch-1.10.x) KUDU-2850: fix thrift comparison

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13636 ) Change subject: KUDU-2850: fix thrift comparison .. KUDU-2850: fix thrift comparison In the operator< implementations, we previo

[kudu-CR](branch-1.10.x) KUDU-2846 (part 2): optimize IS [NOT] NULL predicates

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13650 Change subject: KUDU-2846 (part 2): optimize IS [NOT] NULL predicates .. KUDU-2846 (part 2): optimize IS [NOT] NULL predicates This does

[kudu-CR](branch-1.10.x) Bump Sentry version to b71a78e

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13637 ) Change subject: Bump Sentry version to b71a78e .. Bump Sentry version to b71a78e This patch bumps Sentry version to include SENT

[kudu-CR](branch-1.10.x) [java] Favor column ids over column names in scan tokens

2019-06-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13646 ) Change subject: [java] Favor column ids over column names in scan tokens .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] [tools] Add get/set extra-configs for CLI tools

2019-06-14 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13649 to look at the new patch set (#2). Change subject: [tools] Add get/set extra-configs for CLI tools .. [tools] Add g

[kudu-CR] [tools] Add get/set extra-configs for CLI tools

2019-06-14 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13649 Change subject: [tools] Add get/set extra-configs for CLI tools .. [tools] Add get/set extra-configs for CLI tools Change-Id: I90c790bbfe41a59