[kudu-CR] docs: add docs for maintenance mode

2019-11-15 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14718 ) Change subject: docs: add docs for maintenance mode .. docs: add docs for maintenance mode A staged version can be found here:

[kudu-CR] [mini-cluster] another fix on building mini-cluster JAR

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14730 Change subject: [mini-cluster] another fix on building mini-cluster JAR .. [mini-cluster] another fix on building mini-cluster JAR

[kudu-CR](branch-1.11.x) [mini-cluster] fix on building mini-cluster JAR

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14728 ) Change subject: [mini-cluster] fix on building mini-cluster JAR .. Patch Set 1: Verified+1 Unrelated test failures: *

[kudu-CR](branch-1.11.x) [mini-cluster] fix on building mini-cluster JAR

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14728 ) Change subject: [mini-cluster] fix on building mini-cluster JAR .. [mini-cluster] fix on building mini-cluster JAR Prior to

[kudu-CR](branch-1.11.x) [mini-cluster] fix on building mini-cluster JAR

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14728 ) Change subject: [mini-cluster] fix on building mini-cluster JAR .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.11.x) [mini-cluster] fix on building mini-cluster JAR

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [mini-cluster] fix on building mini-cluster JAR .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14728 To

[kudu-CR](branch-1.11.x) [docs] WARN AS ERROR requires doxygen >= 1.8.11

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14729 ) Change subject: [docs] WARN_AS_ERROR requires doxygen >= 1.8.11 .. [docs] WARN_AS_ERROR requires doxygen >= 1.8.11 The

[kudu-CR](branch-1.11.x) [docs] WARN AS ERROR requires doxygen >= 1.8.11

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14729 ) Change subject: [docs] WARN_AS_ERROR requires doxygen >= 1.8.11 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.11.x) [docs] WARN AS ERROR requires doxygen >= 1.8.11

2019-11-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14729 to review the following change. Change subject: [docs] WARN_AS_ERROR requires doxygen >= 1.8.11 ..

[kudu-CR](branch-1.11.x) [mini-cluster] fix on building mini-cluster JAR

2019-11-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14728 to review the following change. Change subject: [mini-cluster] fix on building mini-cluster JAR ..

[kudu-CR](branch-1.11.x) [java] fixed bug in the connection negotiation code

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14727 ) Change subject: [java] fixed bug in the connection negotiation code .. Patch Set 1: Code-Review+2 Carrying over +2 from

[kudu-CR](branch-1.11.x) [java] fixed bug in the connection negotiation code

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14727 ) Change subject: [java] fixed bug in the connection negotiation code .. [java] fixed bug in the connection negotiation code

[kudu-CR](branch-1.11.x) [mini cluster] SetDaemonFlag for test minicluster

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14726 ) Change subject: [mini_cluster] SetDaemonFlag for test minicluster .. [mini_cluster] SetDaemonFlag for test minicluster Added

[kudu-CR](branch-1.11.x) [mini cluster] SetDaemonFlag for test minicluster

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14726 ) Change subject: [mini_cluster] SetDaemonFlag for test minicluster .. Patch Set 1: Code-Review+2

[kudu-CR](branch-1.11.x) thirdparty: remove memkind from LICENSE.txt

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14725 ) Change subject: thirdparty: remove memkind from LICENSE.txt .. thirdparty: remove memkind from LICENSE.txt I'm getting kinda

[kudu-CR](branch-1.11.x) thirdparty: remove memkind from LICENSE.txt

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14725 ) Change subject: thirdparty: remove memkind from LICENSE.txt .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] docs: add docs for maintenance mode

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 ) Change subject: docs: add docs for maintenance mode .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] docs: add docs for maintenance mode

2019-11-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 ) Change subject: docs: add docs for maintenance mode .. Patch Set 2: (8 comments)

[kudu-CR] docs: add docs for maintenance mode

2019-11-15 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Priyanka Chheda, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14718 to look at the new patch set (#3). Change subject: docs: add docs for maintenance mode

[kudu-CR](branch-1.11.x) [java] fixed bug in the connection negotiation code

2019-11-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14727 to review the following change. Change subject: [java] fixed bug in the connection negotiation code

[kudu-CR](branch-1.11.x) [mini cluster] SetDaemonFlag for test minicluster

2019-11-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14726 to review the following change. Change subject: [mini_cluster] SetDaemonFlag for test minicluster ..

[kudu-CR](branch-1.11.x) thirdparty: remove memkind from LICENSE.txt

2019-11-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14725 to review the following change. Change subject: thirdparty: remove memkind from LICENSE.txt .. thirdparty: remove

[kudu-CR] docs: add docs for maintenance mode

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 ) Change subject: docs: add docs for maintenance mode .. Patch Set 2: Code-Review+1 (8 comments) A few nits.

[kudu-CR](branch-1.10.x) [java] fixed bug in the connection negotiation code

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14724 ) Change subject: [java] fixed bug in the connection negotiation code .. Patch Set 1: Code-Review+2 Carrying over +2 from

[kudu-CR](branch-1.10.x) [java] fixed bug in the connection negotiation code

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14724 ) Change subject: [java] fixed bug in the connection negotiation code .. [java] fixed bug in the connection negotiation code

[kudu-CR](branch-1.10.x) [mini cluster] SetDaemonFlag for test minicluster

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14723 ) Change subject: [mini_cluster] SetDaemonFlag for test minicluster .. [mini_cluster] SetDaemonFlag for test minicluster Added

[kudu-CR](branch-1.10.x) [mini cluster] SetDaemonFlag for test minicluster

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14723 ) Change subject: [mini_cluster] SetDaemonFlag for test minicluster .. Patch Set 1: Code-Review+2 This patch is required by

[kudu-CR] docs: add docs for maintenance mode

2019-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 ) Change subject: docs: add docs for maintenance mode .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] docs: add docs for maintenance mode

2019-11-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 ) Change subject: docs: add docs for maintenance mode .. Patch Set 2: (1 comment)

[kudu-CR] docs: add docs for maintenance mode

2019-11-15 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Priyanka Chheda, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14718 to look at the new patch set (#2). Change subject: docs: add docs for maintenance mode

[kudu-CR] docs: add docs for maintenance mode

2019-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 ) Change subject: docs: add docs for maintenance mode .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR](branch-1.10.x) [mini cluster] SetDaemonFlag for test minicluster

2019-11-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14723 to review the following change. Change subject: [mini_cluster] SetDaemonFlag for test minicluster ..

[kudu-CR](branch-1.10.x) [java] fixed bug in the connection negotiation code

2019-11-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14724 to review the following change. Change subject: [java] fixed bug in the connection negotiation code

[kudu-CR] KUDU-1260 Add test for prefetching on java scanner

2019-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14631 ) Change subject: KUDU-1260 Add test for prefetching on java scanner .. Patch Set 2: I'm not as qualified to review Java client code so

[kudu-CR] [mini cluster] SetDaemonFlag for test minicluster

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14712 ) Change subject: [mini_cluster] SetDaemonFlag for test minicluster .. [mini_cluster] SetDaemonFlag for test minicluster Added

[kudu-CR] [java] fixed bug in the connection negotiation code

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14713 ) Change subject: [java] fixed bug in the connection negotiation code .. [java] fixed bug in the connection negotiation code

[kudu-CR] [mini cluster] SetDaemonFlag for test minicluster

2019-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14712 ) Change subject: [mini_cluster] SetDaemonFlag for test minicluster .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [mini cluster] SetDaemonFlag for test minicluster

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14712 ) Change subject: [mini_cluster] SetDaemonFlag for test minicluster .. Patch Set 2: (1 comment)

[kudu-CR] [mini cluster] SetDaemonFlag for test minicluster

2019-11-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14712 to look at the new patch set (#2). Change subject: [mini_cluster] SetDaemonFlag for test minicluster ..

[kudu-CR] [java] fixed bug in the connection negotiation code

2019-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14713 ) Change subject: [java] fixed bug in the connection negotiation code .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [java] fixed bug in the connection negotiation code

2019-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14713 ) Change subject: [java] fixed bug in the connection negotiation code .. Patch Set 5: Code-Review+2 Todd do you want to take a look before

[kudu-CR] [mini cluster] SetDaemonFlag for test minicluster

2019-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14712 ) Change subject: [mini_cluster] SetDaemonFlag for test minicluster .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 10: (3 comments)

[kudu-CR] [java] fixed bug in the connection negotiation code

2019-11-15 Thread Alexey Serbin (Code Review)
Hello Attila Bukor, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14713 to look at the new patch set (#5). Change subject: [java] fixed bug in the connection negotiation code

[kudu-CR] [java] fixed bug in the connection negotiation code

2019-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14713 ) Change subject: [java] fixed bug in the connection negotiation code .. Patch Set 4: (2 comments)

[kudu-CR] [java] fixed typo in the connection negotiation code

2019-11-15 Thread Alexey Serbin (Code Review)
Hello Attila Bukor, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14713 to look at the new patch set (#4). Change subject: [java] fixed typo in the connection negotiation code

[kudu-CR] docs: add docs for maintenance mode

2019-11-15 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Priyanka Chheda, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14718 to review the following change. Change subject: docs: add docs for maintenance mode .. docs: add

[kudu-CR] [tablet] Optimize TabletMetadata::CollectBlockIds efficiency

2019-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14445 ) Change subject: [tablet] Optimize TabletMetadata::CollectBlockIds efficiency .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [tablet] Optimize TabletMetadata::CollectBlockIds efficiency

2019-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14445 ) Change subject: [tablet] Optimize TabletMetadata::CollectBlockIds efficiency .. [tablet] Optimize TabletMetadata::CollectBlockIds

[kudu-CR] [subprocess] KUDU-2791 p2: add basic protobuf msg

2019-11-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 ) Change subject: [subprocess] KUDU-2791 p2: add basic protobuf msg .. Patch Set 2: (1 comment) > Patch Set 1: > > (1 comment) > > Not

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-11-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 3: (3 comments) I added a few comments to supbprocess_protocol.cc -

[kudu-CR] [java] fixed typo in the connection negotiation code

2019-11-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14713 ) Change subject: [java] fixed typo in the connection negotiation code .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers

2019-11-15 Thread Yifan Zhang (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Hannah Nguyen, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14154 to look at the new patch set (#14). Change subject: KUDU-2914: Rebalance tool support moving replicas from some specific

[kudu-CR] KUDU-2975: Spread WAL across multiple directories

2019-11-15 Thread YangSong (Code Review)
YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14654 ) Change subject: KUDU-2975: Spread WAL across multiple directories .. Patch Set 13: (14 comments)

[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)

2019-11-15 Thread Volodymyr Verovkin (Code Review)
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14517 ) Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client) .. Patch Set 3: (19 comments)

[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)

2019-11-15 Thread Volodymyr Verovkin (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14517 to look at the new patch set (#3). Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 2, Java client)

[kudu-CR] KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers

2019-11-15 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14154 ) Change subject: KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers .. Patch Set 13: (20 comments)