[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared

2021-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 ) Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared .. Patch Set 3: Code-Review+2 I don't have ARM machine to test th

[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared

2021-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16907 ) Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared .. KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared G

[kudu-CR] [master] KUDU-2181 Procedure for copying sys catalog on adding master

2021-01-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16830 ) Change subject: [master] KUDU-2181 Procedure for copying sys catalog on adding master .. Patch Set 7: (1 comment) http://gerrit.cloude

[kudu-CR] [master] KUDU-2181 Procedure for copying sys catalog on adding master

2021-01-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16830 ) Change subject: [master] KUDU-2181 Procedure for copying sys catalog on adding master .. Patch Set 7: (1 comment) http://gerrit.cloude

[kudu-CR] [master] KUDU-2181 Procedure for copying sys catalog on adding master

2021-01-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16830 ) Change subject: [master] KUDU-2181 Procedure for copying sys catalog on adding master .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [consensus] Allow sending status-only request messages to FAILED peer

2021-01-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16899 ) Change subject: [consensus] Allow sending status-only request messages to FAILED peer .. Patch Set 2: Code-Review+2 (1 comment) http:/

[kudu-CR] KUDU-1644 use range partition info for pruning

2021-01-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16903 ) Change subject: KUDU-1644 use range partition info for pruning .. Patch Set 1: (4 comments) Overall looks pretty good. Thanks for follo

[kudu-CR] [master] KUDU-2181 Procedure for copying sys catalog on adding master

2021-01-05 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16830 to look at the new patch set (#7). Change subject: [master] KUDU-2181 Procedure for copying sys catalog on adding master ..

[kudu-CR] [consensus] Allow sending status-only request messages to FAILED peer

2021-01-05 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16899 to look at the new patch set (#2). Change subject: [consensus] Allow sending status-only request messages to FAILED peer .

[kudu-CR] [master] KUDU-2181 Procedure for copying sys catalog on adding master

2021-01-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16830 ) Change subject: [master] KUDU-2181 Procedure for copying sys catalog on adding master .. Patch Set 6: (3 comments) http://gerrit.cl

[kudu-CR] [consensus] Allow sending status-only request messages to FAILED peer

2021-01-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16899 ) Change subject: [consensus] Allow sending status-only request messages to FAILED peer .. Patch Set 1: (5 comments) http://gerrit.cl

[kudu-CR] (wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2021-01-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: (wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 3: (13 comments) Mostly ni

[kudu-CR] WIP KUDU-2612 Java client transaction API

2021-01-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16894 ) Change subject: WIP KUDU-2612 Java client transaction API .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16894/2/java/kudu

[kudu-CR] [rpc] update ServiceIf::service name() signature

2021-01-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16916 ) Change subject: [rpc] update ServiceIf::service_name() signature .. Patch Set 3: Code-Review+2 (1 comment) Thanks for the update! http

[kudu-CR] [rpc] update ServiceIf::service name() signature

2021-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16916 ) Change subject: [rpc] update ServiceIf::service_name() signature .. Patch Set 3: > (1 comment) > > Thanks for the update! Thank you

[kudu-CR] [docs] Add note about Javadoc compatibility

2021-01-05 Thread Attila Bukor (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16924 to review the following change. Change subject: [docs] Add note about Javadoc compatibility .. [docs] Add note about

[kudu-CR] [Java] Upgrade dependencies

2021-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16874 ) Change subject: [Java] Upgrade dependencies .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16874 To u

[kudu-CR] [Java] Upgrade dependencies

2021-01-05 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16874 to look at the new patch set (#3). Change subject: [Java] Upgrade dependencies ...

[kudu-CR] [Java] Upgrade dependencies

2021-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16874 ) Change subject: [Java] Upgrade dependencies .. Patch Set 2: maybe we should upgrade the Gradle wrapper to 6.7.1 as well? -- To view,

[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared

2021-01-05 Thread Anonymous Coward (Code Review)
Hello Quanlong Huang, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16907 to look at the new patch set (#3). Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared ...

[kudu-CR] KUDU-3225 Fixes error 'vld1q u8 x4' was not declared

2021-01-05 Thread Anonymous Coward (Code Review)
huangtianhua...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 ) Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared .. Patch Set 2: (1 comment) http://gerrit.cloudera.o