[kudu-CR] KUDU-1945 Auto-Incrementing Column, C++ client

2023-01-13 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 ) Change subject: KUDU-1945 Auto-Incrementing Column, C++ client .. Patch Set 16: (1 comment)

[kudu-CR] KUDU-1945 Auto-Incrementing Column, C++ client

2023-01-13 Thread Marton Greber (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19272 to look at the new patch set (#16). Change subject: KUDU-1945 Auto-Incrementing Column, C++ client

[kudu-CR] KUDU-1945 Auto-Incrementing Column, C++ client

2023-01-13 Thread Marton Greber (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19272 to look at the new patch set (#15). Change subject: KUDU-1945 Auto-Incrementing Column, C++ client

[kudu-CR] KUDU-1945: Support non unique primary key for Java client

2023-01-13 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/19384 ) Change subject: KUDU-1945: Support non unique primary key for Java client .. KUDU-1945: Support non unique primary key for Java client

[kudu-CR] KUDU-1945 Auto-Incrementing Column, C++ client

2023-01-13 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 ) Change subject: KUDU-1945 Auto-Incrementing Column, C++ client .. Patch Set 14: (1 comment)

[kudu-CR] Adds ppc64le to the exclusion list of architectures

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19012 ) Change subject: Adds ppc64le to the exclusion list of architectures .. Adds ppc64le to the exclusion list of architectures

[kudu-CR] Adds ppc64le to the exclusion list of architectures

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19012 ) Change subject: Adds ppc64le to the exclusion list of architectures .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Adds ppc64le to the exclusion list of architectures

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: Adds ppc64le to the exclusion list of architectures .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/19012 To

[kudu-CR] Adds ppc64le to the exclusion list of architectures

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19012 ) Change subject: Adds ppc64le to the exclusion list of architectures .. Patch Set 2: Verified+1 unrelated test failure in

[kudu-CR] KUDU-1945: Support non unique primary key for Java client

2023-01-13 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/19384 ) Change subject: KUDU-1945: Support non unique primary key for Java client .. KUDU-1945: Support non unique primary key for Java client

[kudu-CR] Busy loop is proposed for ppc64le to implement PauseCPU()

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19010 ) Change subject: Busy loop is proposed for ppc64le to implement PauseCPU() .. Busy loop is proposed for ppc64le to implement

[kudu-CR] Busy loop is proposed for ppc64le to implement PauseCPU()

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19010 ) Change subject: Busy loop is proposed for ppc64le to implement PauseCPU() .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Busy loop is proposed for ppc64le to implement PauseCPU()

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19010 ) Change subject: Busy loop is proposed for ppc64le to implement PauseCPU() .. Patch Set 1: (1 comment)

[kudu-CR] Adds the missing atomic32 atomic64 typedefs for ppc64le

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19005 ) Change subject: Adds the missing atomic32 atomic64 typedefs for ppc64le .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Adds the missing atomic32 atomic64 typedefs for ppc64le

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19005 ) Change subject: Adds the missing atomic32 atomic64 typedefs for ppc64le .. Adds the missing atomic32 atomic64 typedefs for

[kudu-CR] Replaces the preprocessor trigger ARCH POWERPC64 with powerpc64

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19004 ) Change subject: Replaces the preprocessor trigger ARCH_POWERPC64 with __powerpc64__ .. Replaces the preprocessor trigger

[kudu-CR] Replaces the preprocessor trigger ARCH POWERPC64 with powerpc64

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19004 ) Change subject: Replaces the preprocessor trigger ARCH_POWERPC64 with __powerpc64__ .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Replaces the preprocessor trigger ARCH POWERPC64 with powerpc64

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: Replaces the preprocessor trigger ARCH_POWERPC64 with __powerpc64__ .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] Replaces the preprocessor trigger ARCH POWERPC64 with powerpc64

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19004 ) Change subject: Replaces the preprocessor trigger ARCH_POWERPC64 with __powerpc64__ .. Patch Set 2: Verified+1 unrelated TSAN

[kudu-CR] Skips -msse4.2 compiler flag for arch: ppc64le

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19000 ) Change subject: Skips -msse4.2 compiler flag for arch: ppc64le .. Skips -msse4.2 compiler flag for arch: ppc64le Files

[kudu-CR] Skips -msse4.2 compiler flag for arch: ppc64le

2023-01-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19000 ) Change subject: Skips -msse4.2 compiler flag for arch: ppc64le .. Patch Set 2: Code-Review+2 Thank you for the contribution! -- To

[kudu-CR] KUDU-1945 Auto-Incrementing Column, C++ client

2023-01-13 Thread Marton Greber (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19272 to look at the new patch set (#14). Change subject: KUDU-1945 Auto-Incrementing Column, C++ client

[kudu-CR] KUDU-1945 Auto-Incrementing Column, C++ client

2023-01-13 Thread Marton Greber (Code Review)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 ) Change subject: KUDU-1945 Auto-Incrementing Column, C++ client .. Patch Set 13: (2 comments)

[kudu-CR] KUDU-1945 Auto-Incrementing Column, C++ client

2023-01-13 Thread Marton Greber (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19272 to look at the new patch set (#13). Change subject: KUDU-1945 Auto-Incrementing Column, C++ client

[kudu-CR] KUDU-1945 Auto-Incrementing Column, C++ client

2023-01-13 Thread Marton Greber (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19272 to look at the new patch set (#12). Change subject: KUDU-1945 Auto-Incrementing Column, C++ client

[kudu-CR] KUDU-1945 Auto-Incrementing Column, C++ client

2023-01-13 Thread Marton Greber (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19272 to look at the new patch set (#11). Change subject: KUDU-1945 Auto-Incrementing Column, C++ client

[kudu-CR] [compaction] support turn on/off FLAGS enable maintenance manager at runtime

2023-01-13 Thread Yuqi Du (Code Review)
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19398 ) Change subject: [compaction] support turn on/off FLAGS_enable_maintenance_manager at runtime .. Patch Set 2: (2 comments) Good advices.

[kudu-CR] [compaction] support turn on/off FLAGS enable maintenance manager at runtime

2023-01-13 Thread Yuqi Du (Code Review)
Hello Tidy Bot, Ashwani Raina, Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19398 to look at the new patch set (#2). Change subject: [compaction] support turn on/off FLAGS_enable_maintenance_manager at runtime

[kudu-CR] [KUDU-3430] Implement getting flags filter logic in tool side

2023-01-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19393 ) Change subject: [KUDU-3430] Implement getting flags filter logic in tool side .. Patch Set 10: Verified+1 -- To view, visit

[kudu-CR] [KUDU-3430] Implement getting flags filter logic in tool side

2023-01-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [KUDU-3430] Implement getting flags filter logic in tool side .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/19393

[kudu-CR] [tools] Return immediately after the limit number of rows have been dumped

2023-01-13 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19369 ) Change subject: [tools] Return immediately after the limit number of rows have been dumped .. Patch Set 6: (2 comments)

[kudu-CR] [tools] Return immediately after the limit number of rows have been dumped

2023-01-13 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Ashwani Raina, Yifan Zhang, Kudu Jenkins, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19369 to look at the new patch set (#6). Change subject: [tools] Return immediately after the limit number of rows