[kudu-CR] [GC] gc ancient, fully deleted rowsets without live row count

2023-04-03 Thread KeDeng (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19670 to look at the new patch set (#4). Change subject: [GC] gc ancient, fully deleted rowsets without live row count ...

[kudu-CR] [GC] gc ancient, fully deleted rowsets without live row count

2023-04-03 Thread KeDeng (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19670 to look at the new patch set (#5). Change subject: [GC] gc ancient, fully deleted rowsets without live row count ...

[kudu-CR] [Python] Support setting runtime flags in tests

2023-04-03 Thread Marton Greber (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19640 to look at the new patch set (#7). Change subject: [Python] Support setting runtime flags in tests .

[kudu-CR] [Python] Support setting startup flags in tests

2023-04-03 Thread Marton Greber (Code Review)
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19679 Change subject: [Python] Support setting startup flags in tests .. [Python] Support setting startup flags in tests Currently it is not

[kudu-CR] jwt: Additional test

2023-04-03 Thread Zoltan Chovan (Code Review)
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19156 to look at the new patch set (#13). Change subject: jwt: Additional test

[kudu-CR] Change order of operations during InitCatalogManagerTask

2023-04-03 Thread Code Review
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19639 to look at the new patch set (#2). Change subject: Change order of operations during InitCatalogManagerTask .. Chan

[kudu-CR] [Python] Support setting startup flags in tests

2023-04-03 Thread Marton Greber (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19679 to look at the new patch set (#2). Change subject: [Python] Support setting startup flags in tests .. [Python] Supp

[kudu-CR] [Python] Support setting startup flags in tests

2023-04-03 Thread Marton Greber (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19679 to look at the new patch set (#3). Change subject: [Python] Support setting startup flags in tests .

[kudu-CR] [GC] gc ancient, fully deleted rowsets without live row count

2023-04-03 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 ) Change subject: [GC] gc ancient, fully deleted rowsets without live row count .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:

[kudu-CR](branch-1.17.x) KUDU-1945 Update auto incrementing counter during bootstrap

2023-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19678 ) Change subject: KUDU-1945 Update auto incrementing counter during bootstrap .. KUDU-1945 Update auto incrementing counter durin

[kudu-CR](branch-1.17.x) KUDU-3437 Set default block cache metrics policy to reset

2023-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19673 ) Change subject: KUDU-3437 Set default block_cache_metrics_policy to reset .. KUDU-3437 Set default block_cache_metrics_policy t

[kudu-CR] [clock] add sanity check to detect wall clock jumps

2023-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19473 ) Change subject: [clock] add sanity check to detect wall clock jumps .. [clock] add sanity check to detect wall clock jumps The

[kudu-CR](branch-1.17.x) [clock] add sanity check to detect wall clock jumps

2023-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19681 Change subject: [clock] add sanity check to detect wall clock jumps .. [clock] add sanity check to detect wall clock jumps There was a

[kudu-CR] [KUDU-3452] Make validate table creating task not affected

2023-04-03 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 ) Change subject: [KUDU-3452] Make validate table creating task not affected .. Patch Set 6: (8 comments) http://gerrit.cloudera.org:808

[kudu-CR] [Python] Support setting startup flags in tests

2023-04-03 Thread Marton Greber (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19679 to look at the new patch set (#4). Change subject: [Python] Support setting startup flags in tests .

[kudu-CR] jwt: Additional test

2023-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19156 ) Change subject: jwt: Additional test .. Patch Set 13: Code-Review+2 Thank you very much for a new test! -- To view, visit http://ger

[kudu-CR] jwt: Additional test

2023-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19156 ) Change subject: jwt: Additional test .. jwt: Additional test * Added JWT scenarios to the negiotiation test * Updated the secu

[kudu-CR](branch-1.17.x) [clock] add sanity check to detect wall clock jumps

2023-04-03 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19681 ) Change subject: [clock] add sanity check to detect wall clock jumps .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [GC] gc ancient, fully deleted rowsets without live row count

2023-04-03 Thread KeDeng (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19670 to look at the new patch set (#6). Change subject: [GC] gc ancient, fully deleted rowsets without live row count ...

[kudu-CR] [GC] gc ancient, fully deleted rowsets without live row count

2023-04-03 Thread KeDeng (Code Review)
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 ) Change subject: [GC] gc ancient, fully deleted rowsets without live row count .. Patch Set 6: (6 comments) Thnaks for your reviews. http://

[kudu-CR] [Python] Refactor tests to use assertRaisesRegex

2023-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19633 ) Change subject: [Python] Refactor tests to use assertRaisesRegex .. Patch Set 6: Code-Review+1 (3 comments) Overall LGTM, just a few

[kudu-CR] [GC] gc ancient, fully deleted rowsets without live row count

2023-04-03 Thread KeDeng (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19670 to look at the new patch set (#7). Change subject: [GC] gc ancient, fully deleted rowsets without live row count ...

[kudu-CR] [Python] Support setting startup flags in tests

2023-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19679 ) Change subject: [Python] Support setting startup flags in tests .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/1967

[kudu-CR] [Python] Support setting runtime flags in tests

2023-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19640 ) Change subject: [Python] Support setting runtime flags in tests .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/1964

[kudu-CR](branch-1.17.x) [clock] add sanity check to detect wall clock jumps

2023-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19681 ) Change subject: [clock] add sanity check to detect wall clock jumps .. [clock] add sanity check to detect wall clock jumps The

[kudu-CR](branch-1.17.x) [clock] add sanity check to detect wall clock jumps

2023-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19681 ) Change subject: [clock] add sanity check to detect wall clock jumps .. Patch Set 1: > Patch Set 1: Code-Review+2 Thank you for fast r