[kudu-CR] [rpc] increase listened socket backlog up to 512

2023-12-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20797 ) Change subject: [rpc] increase listened socket backlog up to 512 .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2023-12-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 4: Code-Review+1 (4 comments) http://gerrit

[kudu-CR] [rpc] increase listened socket backlog up to 512

2023-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] increase listened socket backlog up to 512 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20797 To unsubscribe

[kudu-CR] [rpc] increase listened socket backlog up to 512

2023-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20797 ) Change subject: [rpc] increase listened socket backlog up to 512 .. Patch Set 2: Verified+1 unrelated test failures in RaftConsensusIT

[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests

2023-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests .. KUDU-3524 Fix crash when sending periodic keep

[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests

2023-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests .. Patch Set 6: (2 comments) Thank you very much for th

[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests

2023-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests .. Patch Set 6: Verified+1 unrelated test failure in Too

[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests

2023-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests .. Patch Set 6: Code-Review+2 -- To view, visit http://

[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests

2023-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20739 T

[kudu-CR] [rpc] increase listened socket backlog up to 512

2023-12-14 Thread Alexey Serbin (Code Review)
Hello Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20797 to look at the new patch set (#2). Change subject: [rpc] increase listened socket backlog up to 512

[kudu-CR] [rpc] increase listened socket backlog up to 512

2023-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20797 ) Change subject: [rpc] increase listened socket backlog up to 512 .. Patch Set 1: Verified+1 unrelated test failure in RollingRestartAr

[kudu-CR] [rpc] increase listened socket backlog up to 512

2023-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] increase listened socket backlog up to 512 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20797 To unsubscribe

[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests

2023-12-14 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:808

[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests

2023-12-14 Thread Wang Xixu (Code Review)
Hello Tidy Bot, Alexey Serbin, Ashwani Raina, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Ádám Bakai, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20739 to look at the new patch set (#6). Change subject: KUDU-3524 Fix crash when sending periodic keep-alive

[kudu-CR] [rpc] increase listened socket backlog up to 512

2023-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20797 Change subject: [rpc] increase listened socket backlog up to 512 .. [rpc] increase listened socket backlog up to 512 This patch updates

[kudu-CR] KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations.

2023-12-14 Thread Ashwani Raina (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20792 to look at the new patch set (#2). Change subject: KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations. ..

[kudu-CR] [compaction] Log timestamp of two matching DELETE REDO mutations.

2023-12-14 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20792 ) Change subject: [compaction] Log timestamp of two matching DELETE REDO mutations. .. Patch Set 1: (1 comment) http://gerrit.cloudera

[kudu-CR] [compaction] Log timestamp of two matching DELETE REDO mutations.

2023-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20792 ) Change subject: [compaction] Log timestamp of two matching DELETE REDO mutations. .. Patch Set 1: (1 comment) http://gerrit.cloudera

[kudu-CR] [compaction] Log timestamp of two matching DELETE REDO mutations.

2023-12-14 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20792 ) Change subject: [compaction] Log timestamp of two matching DELETE REDO mutations. .. Patch Set 1: (1 comment) http://gerrit.cloudera

[kudu-CR] [compaction] Log timestamp of two matching DELETE REDO mutations.

2023-12-14 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20792 ) Change subject: [compaction] Log timestamp of two matching DELETE REDO mutations. .. Patch Set 1: (1 comment) Raised KUDU-3534 f

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2023-12-14 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 4: > > > The reason behind 64K block size

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2023-12-14 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 4: > > The reason behind 64K block size on

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2023-12-14 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 4: > 4k block, then 15*4k holes, and the

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2023-12-14 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 4: I looked into LogBlockManagerTest/Con

[kudu-CR] KUDU-3527 Fix block manager test on 64k filesystems

2023-12-14 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test on 64k filesystems .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2023-12-14 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 4: > The reason behind 64K block size on

[kudu-CR] [compaction] Add memory estimation unit test

2023-12-14 Thread Code Review
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20787 to look at the new patch set (#5). Change subject: [compaction] Add memory estimation unit test

[kudu-CR] [compaction] Add memory estimation unit test

2023-12-14 Thread Code Review
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20787 to look at the new patch set (#4). Change subject: [compaction] Add memory estimation unit test

[kudu-CR] KUDU-3527 Fix block manager test on 64k filesystems

2023-12-14 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test on 64k filesystems .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests

2023-12-14 Thread Code Review
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests .. Patch Set 5: Code-Review+1 -- To view, visit http://ger

[kudu-CR] [compaction] Log timestamp of two matching DELETE REDO mutations.

2023-12-14 Thread Ashwani Raina (Code Review)
Ashwani Raina has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20792 Change subject: [compaction] Log timestamp of two matching DELETE REDO mutations. .. [compaction] Log timestamp of two matching DELETE

[kudu-CR] KUDU-3527 Fix block manager test on 64k filesystems

2023-12-14 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test on 64k filesystems .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests

2023-12-14 Thread Code Review
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] [compaction] Add memory estimation unit test

2023-12-14 Thread Code Review
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20787 to look at the new patch set (#3). Change subject: [compaction] Add memory estimation unit test

[kudu-CR] [compaction] Add memory estimation unit test

2023-12-14 Thread Code Review
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20787 to look at the new patch set (#2). Change subject: [compaction] Add memory estimation unit test

[kudu-CR] [compaction] Add memory estimation unit test

2023-12-14 Thread Code Review
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20787 ) Change subject: [compaction] Add memory estimation unit test .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/20787/1//C

[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests

2023-12-14 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests .. Patch Set 5: Code-Review+1 (1 comment) Changes look

[kudu-CR] [Refactor] Fix a memory leak warning

2023-12-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20784 ) Change subject: [Refactor] Fix a memory leak warning .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/2078

[kudu-CR] [Refactor] Fix a memory leak warning

2023-12-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [Refactor] Fix a memory leak warning .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20784 To unsubscribe, visit http:

[kudu-CR] [Refactor] Fix a memory leak warning

2023-12-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20784 ) Change subject: [Refactor] Fix a memory leak warning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2

[kudu-CR] KUDU-3524 Fix crash when sending periodic keep-alive requests

2023-12-14 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 ) Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests .. Patch Set 5: Code-Review+2 -- To view, visit http://ge