[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-16 Thread Song Jiacheng (Code Review)
Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 28: (2 comments) > Patch Set 27: >

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-16 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yifan Zhang, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20715 to look at the new patch set (#28). Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. ..

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-16 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20894 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20894/

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-16 Thread Zoltan Martonka (Code Review)
Hello Ashwani Raina, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20894 to look at the new patch set (#3). Change subject: Fix CheckHolePunch for bigger than 4k blocks. .

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-16 Thread Zoltan Martonka (Code Review)
Hello Ashwani Raina, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20894 to look at the new patch set (#4). Change subject: Fix CheckHolePunch for bigger than 4k blocks. .

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-16 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20894 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/2089

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-16 Thread Zoltan Martonka (Code Review)
Hello Ashwani Raina, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20894 to look at the new patch set (#5). Change subject: Fix CheckHolePunch for bigger than 4k blocks. .

[kudu-CR] [log block manager-test] Improve random selection

2024-01-16 Thread Code Review
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20899 ) Change subject: [log_block_manager-test] Improve random selection .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/20899

[kudu-CR] [log block manager-test] Improve random selection

2024-01-16 Thread Code Review
Hello Tidy Bot, Zoltan Martonka, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20899 to look at the new patch set (#5). Change subject: [log_block_manager-test] Improve random selection .

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20892 ) Change subject: [net] DiagnosticSocket wrapper for sock_diag API .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/2089

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2024-01-16 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 4: Do you have any real problem running

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2024-01-16 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 4: > Do you have any real problem runnin

[kudu-CR] [log block manager-test] Improve random selection

2024-01-16 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20899 ) Change subject: [log_block_manager-test] Improve random selection .. Patch Set 5: > Patch Set 5: > > (1 comment) Besides this error, e

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20892 ) Change subject: [net] DiagnosticSocket wrapper for sock_diag API .. Patch Set 1: (5 comments) Thank you for feedback! http://gerrit.

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-16 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20892 to look at the new patch set (#2). Change subject: [net] DiagnosticSocket wrapper for sock_diag API

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20908 Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. [rpc] introduce rpc_listened_socket_rx_queue_size metric Th

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-16 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20892 to look at the new patch set (#3). Change subject: [net] DiagnosticSocket wrapper for sock_diag API

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2024-01-16 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 4: > Patch Set 4: > > > Do you have any real p