[kudu-CR] Minor refactoring on Op class

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 ) Change subject: Minor refactoring on Op class .. Patch Set 2: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/41

[kudu-CR] Minor refactoring on Op class

2024-04-23 Thread KeDeng (Code Review)
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 ) Change subject: Minor refactoring on Op class .. Patch Set 2: (4 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/213

[kudu-CR] Minor refactoring on Op class

2024-04-23 Thread KeDeng (Code Review)
Hello Alexey Serbin, Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21342 to look at the new patch set (#2). Change subject: Minor refactoring on Op class .. Mi

[kudu-CR] Minor refactoring on Op class

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 ) Change subject: Minor refactoring on Op class .. Patch Set 2: Build Started http://jenkins.kudu.apache.org/job/pre_commit/41/ -- To v

[kudu-CR] [util] switch to using std::shared lock

2024-04-23 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21349 ) Change subject: [util] switch to using std::shared_lock .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/2

[kudu-CR] [util] expose recently seen value in a histogram

2024-04-23 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21321 ) Change subject: [util] expose recently seen value in a histogram .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [util] expose recently seen value in a histogram

2024-04-23 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21321 ) Change subject: [util] expose recently seen value in a histogram .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] [rpc-test] make RpcPendingConnectionsMetric more stable

2024-04-23 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21251 ) Change subject: [rpc-test] make RpcPendingConnectionsMetric more stable .. [rpc-test] make RpcPendingConnectionsMetric more

[kudu-CR] [rpc-test] make RpcPendingConnectionsMetric more stable

2024-04-23 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21251 ) Change subject: [rpc-test] make RpcPendingConnectionsMetric more stable .. Patch Set 1: Code-Review+2 -- To view, visit http://ge

[kudu-CR](gh-pages) [blog] blogpost about auto-incrementing column in Kudu

2024-04-23 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21119 ) Change subject: [blog] blogpost about auto-incrementing column in Kudu .. [blog] blogpost about auto-incrementing column in

[kudu-CR](gh-pages) [blog] blogpost about auto-incrementing column in Kudu

2024-04-23 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21119 ) Change subject: [blog] blogpost about auto-incrementing column in Kudu .. Patch Set 4: Verified+1 -- To view, visit http://gerrit

[kudu-CR] [util] switch to using std::shared lock

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21349 ) Change subject: [util] switch to using std::shared_lock .. Patch Set 1: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre

[kudu-CR] [util] switch to using std::shared lock

2024-04-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21349 Change subject: [util] switch to using std::shared_lock .. [util] switch to using std::shared_lock Since Kudu switched to using C++17 l

[kudu-CR] [util] switch to using std::shared lock

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21349 ) Change subject: [util] switch to using std::shared_lock .. Patch Set 1: Build Started http://jenkins.kudu.apache.org/job/pre_commit/40/

[kudu-CR] Minor refactoring on Op Class

2024-04-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 ) Change subject: Minor refactoring on Op Class .. Patch Set 1: Code-Review-1 (4 comments) http://gerrit.cloudera.org:8080/#/c/21342/1/

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 10: Verified-1 Build Failed http://jenkins.kudu.apach

[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 ) Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 .. Patch Set 9: Verified-1 Build Failed http://jenkins.kudu.apache.org/

[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4

2024-04-23 Thread Zoltan Chovan (Code Review)
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 ) Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 .. Patch Set 9: (1 comment) I'll collect and summarise some additional

[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4

2024-04-23 Thread Zoltan Chovan (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21030 to look at the new patch set (#9). Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 ..

[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 ) Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 .. Patch Set 9: Build Started http://jenkins.kudu.apache.org/job/pre_com

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#10). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 10: Build Started http://jenkins.kudu.apache.org/job/p

[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4

2024-04-23 Thread Zoltan Chovan (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21030 to look at the new patch set (#8). Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 ..

[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 ) Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 .. Patch Set 8: Verified-1 Build Failed http://jenkins.kudu.apache.org/

[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 ) Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 .. Patch Set 8: Build Started http://jenkins.kudu.apache.org/job/pre_com

[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4

2024-04-23 Thread Zoltan Chovan (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21030 to look at the new patch set (#7). Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 ..

[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 ) Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 .. Patch Set 7: Verified-1 Build Failed http://jenkins.kudu.apache.org/

[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 ) Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 .. Patch Set 7: Build Started http://jenkins.kudu.apache.org/job/pre_com

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 9: Verified-1 Build Failed http://jenkins.kudu.apache

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 6: (1 comment) I realized that, the only proper wa

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#9). Change subject: [ARM] Concurrent binary tree memory barriers fixed. .

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#8). Change subject: [ARM] Concurrent binary tree memory barriers fixed. .

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 8: Build Aborted http://jenkins.kudu.apache.org/job/p

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 9: Build Started http://jenkins.kudu.apache.org/job/pr

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 8: Build Started http://jenkins.kudu.apache.org/job/pr

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 7: Build Aborted http://jenkins.kudu.apache.org/job/p

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#7). Change subject: [ARM] Concurrent binary tree memory barriers fixed. .

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 7: Build Started http://jenkins.kudu.apache.org/job/pr

[kudu-CR] [alter table-test] Increase assertion timeout

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21347 ) Change subject: [alter_table-test] Increase assertion timeout .. Patch Set 1: Verified-1 Build Failed http://jenkins.kudu.apache.org/j

[kudu-CR] [alter table-test] Increase assertion timeout

2024-04-23 Thread Code Review
Ádám Bakai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21347 Change subject: [alter_table-test] Increase assertion timeout .. [alter_table-test] Increase assertion timeout On ubuntu 22.04 release bui

[kudu-CR] [alter table-test] Increase assertion timeout

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21347 ) Change subject: [alter_table-test] Increase assertion timeout .. Patch Set 1: Build Started http://jenkins.kudu.apache.org/job/pre_comm

[kudu-CR] [CMakeLists] Make kudu test main static

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 4: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre

[kudu-CR] [CMakeLists] Make kudu test main static

2024-04-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 4: -Verified Build Started http://jenkins.kudu.apache.org/job/pre_

[kudu-CR] [CMakeLists] Make kudu test main static

2024-04-23 Thread Code Review
Hello Alexey Serbin, Zoltan Martonka, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21282 to look at the new patch set (#4). Change subject: [CMakeLists] Make kudu_test_main static ...

[kudu-CR] Minor refactoring on Op Class

2024-04-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 ) Change subject: Minor refactoring on Op Class .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21342 To un

[kudu-CR] Minor refactoring on Op Class

2024-04-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: Minor refactoring on Op Class .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21342 To unsubscribe, visit http://gerri

[kudu-CR] Minor refactoring on Op Class

2024-04-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 ) Change subject: Minor refactoring on Op Class .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21342 To