KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 )
Change subject: Minor refactoring on Op class ...................................................................... Patch Set 2: (4 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/21342/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21342/1//COMMIT_MSG@7 PS1, Line 7: class > class Done http://gerrit.cloudera.org:8080/#/c/21342/1//COMMIT_MSG@10 PS1, Line 10: Now, if we need to add time statistics for these operations, it : would be repetitive to add an initial timestamp separately for : each derived cl > BTW, if thinking forward, when an operation completes, where are you going Done http://gerrit.cloudera.org:8080/#/c/21342/1/src/kudu/tablet/ops/op.h File src/kudu/tablet/ops/op.h: http://gerrit.cloudera.org:8080/#/c/21342/1/src/kudu/tablet/ops/op.h@111 PS1, Line 111: eplicateMsg for this op. > Now this is confusing: the timestamp assigned to the operation is tracked b Done http://gerrit.cloudera.org:8080/#/c/21342/1/src/kudu/tablet/ops/op.cc File src/kudu/tablet/ops/op.cc: http://gerrit.cloudera.org:8080/#/c/21342/1/src/kudu/tablet/ops/op.cc@33 PS1, Line 33: > Doesn't it look quite restrictive? This means all the operations have this I have changed the initialization location of the timestamp as you suggested. -- To view, visit http://gerrit.cloudera.org:8080/21342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie391d4a55b8da08a62025a05cc466fc2b947099c Gerrit-Change-Number: 21342 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Wed, 24 Apr 2024 04:35:18 +0000 Gerrit-HasComments: Yes
