[kudu-CR] [catalog manager] cache masters' addresses

2020-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15704 ) Change subject: [catalog manager] cache masters' addresses .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] [catalog manager] cache masters' addresses

2020-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15704 ) Change subject: [catalog manager] cache masters' addresses .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15704/1//COMM

[kudu-CR] [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15698 ) Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock .. Patch Set 1: (1 comment) Good catch! http://gerrit.clo

[kudu-CR] WIP: KUDU-3097 whether master keep record could be configurable

2020-04-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15616 ) Change subject: WIP: KUDU-3097 whether master keep record could be configurable .. Patch Set 4: > But it would cause some inconsistent be

[kudu-CR] [master] KUDU-2798 fix logging on deleted TSK entries

2020-04-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15657 ) Change subject: [master] KUDU-2798 fix logging on deleted TSK entries .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] util: remove duplicate results from DNS resolution

2020-04-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15665 ) Change subject: util: remove duplicate results from DNS resolution .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:

[kudu-CR] [master] KUDU-2798 fix logging on deleted TSK entries

2020-04-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15657 ) Change subject: [master] KUDU-2798 fix logging on deleted TSK entries .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] bitshuffle: check for a multiple-of-8-bytes invariant in Finish

2020-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15652 ) Change subject: bitshuffle: check for a multiple-of-8-bytes invariant in Finish .. bitshuffle: check for a multiple-of-8-bytes inv

[kudu-CR] ranger: allow overwriting of the log4j2 properties file

2020-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15650 ) Change subject: ranger: allow overwriting of the log4j2 properties file .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] bitshuffle: stop using uninitialized data as padding

2020-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15647 ) Change subject: bitshuffle: stop using uninitialized data as padding .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/156

[kudu-CR] bitshuffle: check for a multiple-of-8-bytes invariant in Finish

2020-04-04 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Bankim Bhavsar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15652 to review the following change. Change subject: bitshuffle: check for a multiple-of-8-bytes invariant in Finish ..

[kudu-CR] ranger: allow overwriting of the log4j2 properties file

2020-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15650 ) Change subject: ranger: allow overwriting of the log4j2 properties file .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] bitshuffle: stop using uninitialized data as padding

2020-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15647 ) Change subject: bitshuffle: stop using uninitialized data as padding .. bitshuffle: stop using uninitialized data as padding The

[kudu-CR] WIP: MSAN support

2020-04-03 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15649 to review the following change. Change subject: WIP: MSAN support .. WIP: MSAN support WIP because I can't seem to g

[kudu-CR] ranger: enable log4j2 logging to files

2020-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15628 ) Change subject: ranger: enable log4j2 logging to files .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] remove last vestiges of boost::bind, boost::function, and std::bind

2020-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15639 ) Change subject: remove last vestiges of boost::bind, boost::function, and std::bind .. remove last vestiges of boost::bind, boost

[kudu-CR] ranger: enable log4j2 logging to files

2020-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15628 ) Change subject: ranger: enable log4j2 logging to files .. Patch Set 9: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/156

[kudu-CR] bitshuffle: stop using uninitialized data as padding

2020-04-03 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Bankim Bhavsar, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15647 to review the following change. Change subject: bitshuffle: stop using uninitialized data as padding

[kudu-CR] ranger: enable log4j2 logging to files

2020-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15628 ) Change subject: ranger: enable log4j2 logging to files .. Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/15628/8//COMMIT_

[kudu-CR] remove last vestiges of boost::bind, boost::function, and std::bind

2020-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15639 ) Change subject: remove last vestiges of boost::bind, boost::function, and std::bind .. Patch Set 1: (2 comments) http://gerrit.cloudera

[kudu-CR] remove last vestiges of boost::bind, boost::function, and std::bind

2020-04-02 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15639 to review the following change. Change subject: remove last vestiges of boost::bind, boost::function, and std::bind ..

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [ranger] Use unique loopback for MiniRanger

2020-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 ) Change subject: [ranger] Use unique loopback for MiniRanger .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] [postgres] Deflake MiniPostgres tests

2020-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15629 ) Change subject: [postgres] Deflake MiniPostgres tests .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1

[kudu-CR] [subprocess] Fix shutdown behavior

2020-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 ) Change subject: [subprocess] Fix shutdown behavior .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15615

[kudu-CR] [build] Fix boost compilation on latest macOS Catalina

2020-04-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15632 ) Change subject: [build] Fix boost compilation on latest macOS Catalina .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-04-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/15601/10/s

[kudu-CR] [postgres] Deflake MiniPostgres tests

2020-04-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15629 ) Change subject: [postgres] Deflake MiniPostgres tests .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15629/4/src/kudu/p

[kudu-CR] [ranger] Use unique loopback for MiniRanger

2020-04-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 ) Change subject: [ranger] Use unique loopback for MiniRanger .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] [build] Fix boost compilation on latest macOS Catalina update

2020-04-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15632 ) Change subject: [build] Fix boost compilation on latest macOS Catalina update .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] [subprocess] Fix shutdown behavior

2020-04-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 ) Change subject: [subprocess] Fix shutdown behavior .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/15615/3

[kudu-CR] WIP: KUDU-3097 whether master keep record could be configurable

2020-04-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15616 ) Change subject: WIP: KUDU-3097 whether master keep record could be configurable .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:

[kudu-CR] wip ranger: direct client logs to a log file

2020-04-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15628 ) Change subject: wip ranger: direct client logs to a log file .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15628/1//CO

[kudu-CR] subprocess: enable log4j debug logging

2020-04-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15627 ) Change subject: subprocess: enable log4j debug logging .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/1

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/15043

[kudu-CR] client: add support for columnar format scan

2020-04-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] [ranger] Use unique loopback for MiniRanger

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 ) Change subject: [ranger] Use unique loopback for MiniRanger .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15625/1/src

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 ) Change subject: [subprocess] Fix shutdown behavior .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/15615

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15601/4/sr

[kudu-CR] KUDU-3097 kudu master should delete table record when deleting table

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15616 ) Change subject: KUDU-3097 kudu master should delete table record when deleting table .. Patch Set 3: (1 comment) This needs a unit test

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/15601/4/sr

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 ) Change subject: [subprocess] Fix shutdown behavior .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15615/1/java/kudu-sub

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. Patch Set 1: (3 comments) Just looked at the new APIs. http://gerrit.cl

[kudu-CR] external mini cluster: actually default to system unsync time source

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/14836 ) Change subject: external_mini_cluster: actually default to system_unsync time source .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] WIP: use ExternalProject Add to define thirdparty deps

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/9931 ) Change subject: WIP: use ExternalProject_Add to define thirdparty deps .. Abandoned If we wanted to revisit our thirdparty dependency system, someth

[kudu-CR] [thirdparty] root can run postgres

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15613 ) Change subject: [thirdparty] root can run postgres .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15613

[kudu-CR] [client] Add a note that only FAST HASH is supported in Bloom filter predicate

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15608 ) Change subject: [client] Add a note that only FAST_HASH is supported in Bloom filter predicate .. [client] Add a note that only F

[kudu-CR] [client] Add a note that only FAST HASH is supported in Bloom filter predicate

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15608 ) Change subject: [client] Add a note that only FAST_HASH is supported in Bloom filter predicate .. Patch Set 1: Code-Review+2 -- To view

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. gutil: remove callback and bind from the codebase It is fitt

[kudu-CR] KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15605 ) Change subject: KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace .. KUDU-3093: another band-aid for this D

[kudu-CR] KUDU-2059: add a TSAN suppression

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15603 ) Change subject: KUDU-2059: add a TSAN suppression .. KUDU-2059: add a TSAN suppression No one is actively working on fixing this,

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Remove return types from various lambdas Only the ones that were abso

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://g

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. [util] Add special handling for nullptr in fast hash Impo

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] WIP [release notes] support for RHEL/CentOS 8.1

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15594 ) Change subject: WIP [release notes] support for RHEL/CentOS 8.1 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15599/3/src/kud

[kudu-CR] KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15605 ) Change subject: KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace .. Patch Set 2: (1 comment) http://gerrit.cloud

[kudu-CR] KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15605 to look at the new patch set (#2). Change subject: KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/156

[kudu-CR] KUDU-3093: another band-aid for this test

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15605 to review the following change. Change subject: KUDU-3093: another band-aid for this test .. KUDU-3093

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Patch Set 3: Verified+1 Overriding Jenkins, unrelated test failure for which

[kudu-CR] KUDU-2059: add a TSAN suppression

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15603 to review the following change. Change subject: KUDU-2059: add a TSAN suppression .. KUDU-2059: add a

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15599 ) Change subject: Remove return types from various lambdas .. Patch Set 2: Verified+1 Overriding Jenkins, unrelated test failures (and KUDU

[kudu-CR] [util] Add special handling for nullptr in fast hash

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 ) Change subject: [util] Add special handling for nullptr in fast hash .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/15

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/15583

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15583 to look at the new patch set (#5). Change subject: gutil: remove callback and bind from the codebase ...

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15582 ) Change subject: consensus: remove kudu::Bind usage from dirty callbacks .. consensus: remove kudu::Bind usage from dirty callbacks

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15582 ) Change subject: consensus: remove kudu::Bind usage from dirty callbacks .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15582 ) Change subject: consensus: remove kudu::Bind usage from dirty callbacks .. Patch Set 3: Verified+1 Overriding Jenkins, KUDU-2059. -- To

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15599 to look at the new patch set (#2). Change subject: Remove return types from various lambdas

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15583 to look at the new patch set (#4). Change subject: gutil: remove callback and bind from the codebase ...

[kudu-CR] gutil: remove BASE EXPORT

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15576 ) Change subject: gutil: remove BASE_EXPORT .. gutil: remove BASE_EXPORT The various definitions of BASE_EXPORT cause IWYU to recom

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15582 ) Change subject: consensus: remove kudu::Bind usage from dirty callbacks .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] Remove return types from various lambdas

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15599 Change subject: Remove return types from various lambdas .. Remove return types from various lambdas Only the ones that were absolutely ne

[kudu-CR] logging: remove kudu::Bind usage from LoggingCallback

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15577 ) Change subject: logging: remove kudu::Bind usage from LoggingCallback .. logging: remove kudu::Bind usage from LoggingCallback Ch

[kudu-CR] fs: remove kudu::Bind usage from ErrorManager

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15579 ) Change subject: fs: remove kudu::Bind usage from ErrorManager .. fs: remove kudu::Bind usage from ErrorManager Change-Id: I15df4e

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15582 to look at the new patch set (#3). Change subject: consensus: remove kudu::Bind usage from dirty callbacks .

[kudu-CR] rpc: remove kudu::Bind usage from ServerPicker

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15578 ) Change subject: rpc: remove kudu::Bind usage from ServerPicker .. rpc: remove kudu::Bind usage from ServerPicker Snuck in a Bind

[kudu-CR] tracing: remove kudu::Bind usage from various callbacks

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15580 ) Change subject: tracing: remove kudu::Bind usage from various callbacks .. tracing: remove kudu::Bind usage from various callbacks

[kudu-CR] env: remove kudu::Bind usage from Walk

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15575 ) Change subject: env: remove kudu::Bind usage from Walk .. env: remove kudu::Bind usage from Walk This isn't as elegant as the oth

[kudu-CR] fs: remove kudu::Bind usage from DataDir closures

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15581 ) Change subject: fs: remove kudu::Bind usage from DataDir closures .. fs: remove kudu::Bind usage from DataDir closures Change-Id:

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15583/

[kudu-CR] env: add a fifo class

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15584 ) Change subject: env: add a fifo class .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15584 To unsubscri

[kudu-CR] WIP [release notes] support for RHEL/CentOS 8.1

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15594 ) Change subject: WIP [release notes] support for RHEL/CentOS 8.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15594/1/

[kudu-CR] subprocess: use a fifo instead of stdout for IO

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15574 ) Change subject: subprocess: use a fifo instead of stdout for IO .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] env: add a fifo class

2020-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15584 ) Change subject: env: add a fifo class .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15584/3/src/kudu/util/env_posix.cc

[kudu-CR] subprocess: use a fifo instead of stdout for IO

2020-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15574 ) Change subject: subprocess: use a fifo instead of stdout for IO .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15574/5/

[kudu-CR] env: add a fifo class

2020-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15584 ) Change subject: env: add a fifo class .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15584/3/src/kudu/util/env_posix.cc

[kudu-CR] rpc: remove kudu::Bind usage from ServerPicker

2020-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15578 ) Change subject: rpc: remove kudu::Bind usage from ServerPicker .. Removed reviewer Kudu Jenkins with the following votes: * Verif

[kudu-CR] rpc: remove kudu::Bind usage from ServerPicker

2020-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15578 ) Change subject: rpc: remove kudu::Bind usage from ServerPicker .. Patch Set 2: Verified+1 Overriding Jenkins, known race. -- To view, v

[kudu-CR] fs: remove kudu::Bind usage from ErrorManager

2020-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15579 ) Change subject: fs: remove kudu::Bind usage from ErrorManager .. Removed reviewer Kudu Jenkins with the following votes: * Verifi

[kudu-CR] fs: remove kudu::Bind usage from ErrorManager

2020-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15579 ) Change subject: fs: remove kudu::Bind usage from ErrorManager .. Patch Set 2: Verified+1 Overriding Jenkins, known race. -- To view, vi

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. Removed reviewer Kudu Jenkins with the following votes: * Ve

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15583 ) Change subject: gutil: remove callback and bind from the codebase .. Patch Set 2: Verified+1 Overriding Jenkins, known race. -- To view

[kudu-CR] [build-support] introduce PARALLEL variable

2020-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15591 ) Change subject: [build-support] introduce PARALLEL variable .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] [build-support] introduce PARALLEL variable

2020-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15591 ) Change subject: [build-support] introduce PARALLEL variable .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/

[kudu-CR] tracing: remove kudu::Bind usage from various callbacks

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15580 to look at the new patch set (#2). Change subject: tracing: remove kudu::Bind usage from various callbacks .

  1   2   3   4   5   6   7   8   9   10   >