[kudu-CR] KUDU-3543 Fix Content-Type headers

2024-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 ) Change subject: KUDU-3543 Fix Content-Type headers .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20868

[kudu-CR] [common] Remove std::lock guard template parameter

2024-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21623 ) Change subject: [common] Remove std::lock_guard template parameter .. Patch Set 8: Verified+1 unrelated Java test failure (RELEASE):

[kudu-CR] [common] Remove std::lock guard template parameter

2024-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [common] Remove std::lock_guard template parameter .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21623 To unsubscri

[kudu-CR] [common] Remove std::lock guard template parameter

2024-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21623 ) Change subject: [common] Remove std::lock_guard template parameter .. [common] Remove std::lock_guard template parameter As of

[kudu-CR] [common] Remove std::lock guard template parameter

2024-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21623 ) Change subject: [common] Remove std::lock_guard template parameter .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [cfile] minor clean-up

2024-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [cfile] minor clean-up .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21632 To unsubscribe, visit http://gerrit.clou

[kudu-CR] [cfile] minor clean-up

2024-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21632 ) Change subject: [cfile] minor clean-up .. Patch Set 4: Verified+1 unrelated test failure in Java tests (RELEASE): org.apache.kudu.spa

[kudu-CR] [cfile] minor clean-up

2024-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21632 ) Change subject: [cfile] minor clean-up .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21632/3/src/kudu/cfile/binary_

[kudu-CR] [cfile] minor clean-up

2024-08-07 Thread Alexey Serbin (Code Review)
Hello Mahesh Reddy, Marton Greber, Zoltan Chovan, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21632 to look at the new patch set (#4). Change subject: [cfile] minor clean-up ..

[kudu-CR] [common] Remove std::lock guard template parameter

2024-08-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21623 ) Change subject: [common] Remove std::lock_guard template parameter .. Patch Set 7: > > Patch Set 6: > > > > > Build Failed > > >

[kudu-CR] [Tool] Retry failed table copying tasks

2024-08-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21536 ) Change subject: [Tool] Retry failed table copying tasks .. Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/21536/11//C

[kudu-CR] [client] KUDU-3595: Add a way to set Kudu client's rpc max message size

2024-08-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21622 ) Change subject: [client] KUDU-3595: Add a way to set Kudu client's rpc_max_message_size .. Patch Set 2: (1 comment) http://gerrit.cl

[kudu-CR] [cfile] minor clean-up

2024-08-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21632 ) Change subject: [cfile] minor clean-up .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21632/1/src/kudu/cfile/rle_blo

[kudu-CR] [cfile] minor clean-up

2024-08-06 Thread Alexey Serbin (Code Review)
Hello Mahesh Reddy, Zoltan Chovan, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21632 to look at the new patch set (#3). Change subject: [cfile] minor clean-up ..

[kudu-CR] [common] Remove std::lock guard template parameter

2024-08-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21623 ) Change subject: [common] Remove std::lock_guard template parameter .. Patch Set 6: > Build Failed > > http://jenkins.kudu.apache.org

[kudu-CR] [cfile] make WriterOptions* a constant member field

2024-08-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21631 ) Change subject: [cfile] make WriterOptions* a constant member field .. [cfile] make WriterOptions* a constant member field Sin

[kudu-CR] [cfile] make WriterOptions* a constant member field

2024-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21631 ) Change subject: [cfile] make WriterOptions* a constant member field .. Patch Set 2: Verified+1 unrelated test failures (TSAN): http:/

[kudu-CR] [common] Remove std::lock guard template parameter

2024-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21623 ) Change subject: [common] Remove std::lock_guard template parameter .. Patch Set 5: > > Patch Set 5: Verified-1 > > > > Build Failed

[kudu-CR] [cfile] minor clean-up

2024-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21632 ) Change subject: [cfile] minor clean-up .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21632/1//COMMIT_MSG Commit Mes

[kudu-CR] [cfile] minor clean-up

2024-08-05 Thread Alexey Serbin (Code Review)
Hello Mahesh Reddy, Zoltan Chovan, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21632 to look at the new patch set (#2). Change subject: [cfile] minor clean-up ..

[kudu-CR] [cfile] make WriterOptions* a constant member field

2024-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21631 ) Change subject: [cfile] make WriterOptions* a constant member field .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [cfile] make WriterOptions* a constant member field

2024-08-05 Thread Alexey Serbin (Code Review)
Hello Mahesh Reddy, Zoltan Chovan, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21631 to look at the new patch set (#2). Change subject: [cfile] make WriterOptions* a constant member field .

[kudu-CR] KUDU-3543 Fix Content-Type headers

2024-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 ) Change subject: KUDU-3543 Fix Content-Type headers .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/

[kudu-CR] KUDU-3543 Fix Content-Type headers

2024-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 ) Change subject: KUDU-3543 Fix Content-Type headers .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20868

[kudu-CR] KUDU-3543 Fix Content-Type headers

2024-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3543 Fix Content-Type headers .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20868 To unsubscribe, visit http:/

[kudu-CR] Fix a mistake of using function 'Substitute'

2024-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21635 ) Change subject: Fix a mistake of using function 'Substitute' .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] Fix a mistake of using function 'Substitute'

2024-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: Fix a mistake of using function 'Substitute' .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21635 To unsubscribe, vi

[kudu-CR] Fix a mistake of using function 'Substitute'

2024-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21635 ) Change subject: Fix a mistake of using function 'Substitute' .. Fix a mistake of using function 'Substitute' Change-Id: Ia8ad5

[kudu-CR] Fix a mistake of using function 'Substitute'

2024-08-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21635 ) Change subject: Fix a mistake of using function 'Substitute' .. Patch Set 3: Verified+1 unrelated test failures -- To view, visit ht

[kudu-CR] KUDU-3371 Parameterize some options of RocksDB

2024-08-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21570 ) Change subject: KUDU-3371 Parameterize some options of RocksDB .. KUDU-3371 Parameterize some options of RocksDB There are man

[kudu-CR] KUDU-3371 Parameterize some options of RocksDB

2024-08-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21570 ) Change subject: KUDU-3371 Parameterize some options of RocksDB .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8

[kudu-CR] KUDU-3543 Fix Content-Type headers

2024-08-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 ) Change subject: KUDU-3543 Fix Content-Type headers .. Patch Set 5: Code-Review+1 (12 comments) Overall looks good to me, a few nits a

[kudu-CR] Fix a grammar error

2024-08-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21635 ) Change subject: Fix a grammar error .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/21635/1//COMMIT_MSG

[kudu-CR] [cfile] minor clean-up

2024-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21632 Change subject: [cfile] minor clean-up .. [cfile] minor clean-up I'm going to post more patches updating the code in src/kudu/cfile, so

[kudu-CR] [cfile] make WriterOptions* a constant member field

2024-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21631 Change subject: [cfile] make WriterOptions* a constant member field .. [cfile] make WriterOptions* a constant member field Since I'm pr

[kudu-CR] [tests] check for gflags::SetCommandLineOption() result

2024-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21630 ) Change subject: [tests] check for gflags::SetCommandLineOption() result .. [tests] check for gflags::SetCommandLineOption() res

[kudu-CR] [tests] check for gflags::SetCommandLineOption() result

2024-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [tests] check for gflags::SetCommandLineOption() result .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21630 To unsu

[kudu-CR] [tests] check for gflags::SetCommandLineOption() result

2024-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21630 ) Change subject: [tests] check for gflags::SetCommandLineOption() result .. Patch Set 1: Verified+1 unrelated test failures in BlockMa

[kudu-CR] [tests] check for gflags::SetCommandLineOption() result

2024-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21630 Change subject: [tests] check for gflags::SetCommandLineOption() result .. [tests] check for gflags::SetCommandLineOption() result With

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. KUDU-613: Add SLRU Cache metrics This patch adds segment-specific metrics

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/213

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 14: Verified+1 unrelated test failures -- To view, visit http://gerrit

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-613: Add SLRU Cache metrics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21389 To unsubscribe, visit http://g

[kudu-CR] [common] Remove std::lock guard template parameter

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21623 ) Change subject: [common] Remove std::lock_guard template parameter .. Patch Set 4: > (1 comment) > > > Patch Set 3: > > > > (1 com

[kudu-CR] [fs] check block size match only for block managers

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21627 ) Change subject: [fs] check block size match only for block managers .. [fs] check block size match only for block managers Sin

[kudu-CR] [fs] check block size match only for block managers

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [fs] check block size match only for block managers .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21627 To unsubscr

[kudu-CR] [fs] check block size match only for block managers

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21627 ) Change subject: [fs] check block size match only for block managers .. Patch Set 1: Verified+1 unrelated test failures -- To view, v

[kudu-CR] [fs] check block size match only for block managers

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21627 Change subject: [fs] check block size match only for block managers .. [fs] check block size match only for block managers Since the bl

[kudu-CR] [cmake] work around of Gradle-related issues

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21626 ) Change subject: [cmake] work around of Gradle-related issues .. Patch Set 2: Verified+1 unrelated test failures: KUDU-3601 -- To vie

[kudu-CR] [cmake] work around of Gradle-related issues

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21626 ) Change subject: [cmake] work around of Gradle-related issues .. [cmake] work around of Gradle-related issues Once Gradle start

[kudu-CR] [cmake] work around of Gradle-related issues

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [cmake] work around of Gradle-related issues .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21626 To unsubscribe, vi

[kudu-CR] [tools] fix compilation warning

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21625 ) Change subject: [tools] fix compilation warning .. [tools] fix compilation warning This patch addresses compilation warnings l

[kudu-CR] [tools] fix compilation warning

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21625 ) Change subject: [tools] fix compilation warning .. Patch Set 1: Verified+1 unrelated test failures -- To view, visit http://gerrit.c

[kudu-CR] [cmake] work around of Gradle-related issues

2024-07-31 Thread Alexey Serbin (Code Review)
Hello Zoltan Chovan, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21626 to look at the new patch set (#2). Change subject: [cmake] work around of Gradle-related issues ..

[kudu-CR] [cmake] work around of Gradle-related issues

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21626 Change subject: [cmake] work around of Gradle-related issues .. [cmake] work around of Gradle-related issues Once Gradle started being

[kudu-CR] [tools] fix compilation warning

2024-07-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21625 Change subject: [tools] fix compilation warning .. [tools] fix compilation warning This patch addresses compilation warnings like below

[kudu-CR] [common] Remove std::lock guard template parameter

2024-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21623 ) Change subject: [common] Remove std::lock_guard template parameter .. Patch Set 3: (1 comment) > Build Failed > > http://jenkins.ku

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

2024-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21604 ) Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz .. KUDU-3591 Fix the flaky test FsMan

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

2024-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 ) Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz .. Patch Set 5: Code-Review+2 (1 comment) T

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 13: Code-Review+1 (3 comments) overall looks good, just a couple of nit

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-07-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/21389/11/src/kudu/u

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-07-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 11: (6 comments) Almost there. Just one nit and a question w.r.t. maki

[kudu-CR] [client] KUDU-3595: Add a way to set Kudu client's rpc max message size

2024-07-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21622 ) Change subject: [client] KUDU-3595: Add a way to set Kudu client's rpc_max_message_size .. Patch Set 2: (5 comments) http://gerrit.c

[kudu-CR] [Tool] Fix unit test ToolTest.TableCopyLimitSpeed

2024-07-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21609 ) Change subject: [Tool] Fix unit test ToolTest.TableCopyLimitSpeed .. [Tool] Fix unit test ToolTest.TableCopyLimitSpeed This pa

[kudu-CR] [Tool] Fix unit test ToolTest.TableCopyLimitSpeed

2024-07-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21609 ) Change subject: [Tool] Fix unit test ToolTest.TableCopyLimitSpeed .. Patch Set 3: Verified+1 unrelated test failure in Java test --

[kudu-CR] [Tool] Fix unit test ToolTest.TableCopyLimitSpeed

2024-07-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [Tool] Fix unit test ToolTest.TableCopyLimitSpeed .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21609 To unsubscrib

[kudu-CR] [Tool] Retry failed table copying tasks

2024-07-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21536 ) Change subject: [Tool] Retry failed table copying tasks .. Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/#/c/21536/9//COM

[kudu-CR] [Tool] Fix unit test ToolTest.TableCopyLimitSpeed

2024-07-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21609 ) Change subject: [Tool] Fix unit test ToolTest.TableCopyLimitSpeed .. Patch Set 3: Code-Review+2 Thanks a lot for addressing the feedba

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-07-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/21389/11//COMMIT_M

[kudu-CR] KUDU-613: SLRU Cache Benchmark

2024-07-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21601 ) Change subject: KUDU-613: SLRU Cache Benchmark .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21601/1

[kudu-CR] [log] fix the Ranger client log count limit not working

2024-07-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21572 ) Change subject: [log] fix the Ranger client log count limit not working .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR] [log] fix the Ranger client log count limit not working

2024-07-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21572 ) Change subject: [log] fix the Ranger client log count limit not working .. [log] fix the Ranger client log count limit not work

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

2024-07-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21614 ) Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp() .. [tests] more robust TabletServerDiskErrorITest::SetU

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

2024-07-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21612 ) Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario .. [tests] re-enable ReplaceTabletsWhileWriting scenario

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

2024-07-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21614 ) Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp() .. Patch Set 1: > There is a new IWYU error need to be fixed.

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

2024-07-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21614 ) Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp() .. Patch Set 1: > Only thing is that IWYU has to be satisfied.

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

2024-07-25 Thread Alexey Serbin (Code Review)
Hello Marton Greber, Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21614 to look at the new patch set (#2). Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp()

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

2024-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21612 ) Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario .. Patch Set 2: Verified+1 TSAN: unrelated tests failures. File

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

2024-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21612 To unsubs

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

2024-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21614 Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp() .. [tests] more robust TabletServerDiskErrorITest::SetUp() This

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

2024-07-24 Thread Alexey Serbin (Code Review)
Hello Ashwani Raina, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21612 to look at the new patch set (#2). Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario ...

[kudu-CR] KUDU-2376 re-enable ReplaceTabletsWhileWriting scenario

2024-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21612 Change subject: KUDU-2376 re-enable ReplaceTabletsWhileWriting scenario .. KUDU-2376 re-enable ReplaceTabletsWhileWriting scenario Sinc

[kudu-CR] KUDU-3594 Fix scan token-test on ASAN

2024-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21610 ) Change subject: KUDU-3594 Fix scan_token-test on ASAN .. Patch Set 2: Code-Review+2 thank you for fixing the issue! -- To view, visi

[kudu-CR] KUDU-3594 Fix scan token-test on ASAN

2024-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21610 ) Change subject: KUDU-3594 Fix scan_token-test on ASAN .. KUDU-3594 Fix scan_token-test on ASAN scan_token-test was failing on

[kudu-CR] KUDU-3594 Fix scan token-test on ASAN

2024-07-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21610 ) Change subject: KUDU-3594 Fix scan_token-test on ASAN .. Patch Set 1: (1 comment) thank you for the fix! http://gerrit.cloudera.org:

[kudu-CR] [client] add ScanTokenStaleRaftMembershipTest

2024-07-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21580 ) Change subject: [client] add ScanTokenStaleRaftMembershipTest .. [client] add ScanTokenStaleRaftMembershipTest This patch adds

[kudu-CR] [client] add ScanTokenStaleRaftMembershipTest

2024-07-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21580 ) Change subject: [client] add ScanTokenStaleRaftMembershipTest .. Patch Set 3: Verified+1 All the failed tests seem to be solely relate

[kudu-CR] [client] add ScanTokenStaleRaftMembershipTest

2024-07-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [client] add ScanTokenStaleRaftMembershipTest .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21580 To unsubscribe, v

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

2024-07-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 ) Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz .. Patch Set 3: (2 comments) http://gerrit.

[kudu-CR] [util] a small clean up on the Throttler class

2024-07-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21603 ) Change subject: [util] a small clean up on the Throttler class .. [util] a small clean up on the Throttler class The motivatio

[kudu-CR] [util] a small clean up on the Throttler class

2024-07-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [util] a small clean up on the Throttler class .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21603 To unsubscribe,

[kudu-CR] [util] a small clean up on the Throttler class

2024-07-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21603 ) Change subject: [util] a small clean up on the Throttler class .. Patch Set 1: Verified+1 All test failures seem to be solely related

[kudu-CR] [util] a small clean up on the Throttler class

2024-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21603 Change subject: [util] a small clean up on the Throttler class .. [util] a small clean up on the Throttler class The motivation behind

[kudu-CR] [Tool] Limit table copying speed

2024-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21527 ) Change subject: [Tool] Limit table copying speed .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/too

[kudu-CR] [Tool] Limit table copying speed

2024-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21527 ) Change subject: [Tool] Limit table copying speed .. Patch Set 6: (9 comments) I'm not sure this works as expected in PS6. http://ger

[kudu-CR] Update CMake to 3.25.3

2024-07-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21569 ) Change subject: Update CMake to 3.25.3 .. Patch Set 3: It seems update cmake's ctest changed its output format, so dist_test.py script

[kudu-CR] KUDU-613: SLRU Cache Benchmark

2024-07-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21601 ) Change subject: KUDU-613: SLRU Cache Benchmark .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/21601/1//COMMIT_MSG C

[kudu-CR] [WIP] KUDU-1261 Java client complex type introduction

2024-07-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20749 ) Change subject: [WIP] KUDU-1261 Java client complex type introduction .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

2024-07-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21560 ) Change subject: KUDU-3371 Add NO_ROCKSDB build option .. KUDU-3371 Add NO_ROCKSDB build option This patch adds a build option

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

2024-07-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3371 Add NO_ROCKSDB build option .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21560 To unsubscribe, visit htt

<    1   2   3   4   5   6   7   8   9   10   >