[kudu-CR] Add "service name" as part of ConnectionId

2018-10-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11681 ) Change subject: Add "service_name" as part of ConnectionId .. Patch Set 1: (3 comments) Thanks for doing this. Just a few comments.

[kudu-CR] Add compile time checks for kerberos, libvmem

2018-07-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10870 ) Change subject: Add compile time checks for kerberos, libvmem .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.

[kudu-CR] Add krb5-server to SLES prerequisite libraries

2018-04-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9727 ) Change subject: Add krb5-server to SLES prerequisite libraries .. Patch Set 1: Code-Review+2 Carry +2. I think we forgot to merge this

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9934 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 4: > Patch Set 4: Veri

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9934 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 4: Code-Review+2 (4 co

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9934 to look at the new patch set (#4). Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9934 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 3: (4 comments) http:

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9934 to look at the new patch set (#3). Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9934 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 2: (1 comment) http:/

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/9934 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Removed reviewer Todd Lipc

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9934 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 2: (2 comments) Thank

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9934 to look at the new patch set (#2). Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fa

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9934 Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. KUDU-2401: External TLS certificat

[kudu-CR] KUDU-2394. Fix flaky RpcStubTest.TestDontHandleTimedOutCalls

2018-04-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9897 ) Change subject: KUDU-2394. Fix flaky RpcStubTest.TestDontHandleTimedOutCalls .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.c

[kudu-CR] KUDU-2394. Fix flaky RpcStubTest.TestDontHandleTimedOutCalls

2018-04-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9897 ) Change subject: KUDU-2394. Fix flaky RpcStubTest.TestDontHandleTimedOutCalls .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:80

[kudu-CR] rpc-test: fix multi-threaded test from running too long

2018-03-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9856 ) Change subject: rpc-test: fix multi-threaded test from running too long .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:

[kudu-CR] Add krb5-server to SLES prerequisite libraries

2018-03-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9727 Change subject: Add krb5-server to SLES prerequisite libraries .. Add krb5-server to SLES prerequisite libraries I was running a test wi

[kudu-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9587 ) Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write() .. Patch Set 2: Code-Review+1 -- To view,

[kudu-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9587 ) Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write() .. Patch Set 2: (1 comment) http://gerrit

[kudu-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9587 ) Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write() .. Patch Set 1: (3 comments) http://gerri

[kudu-CR] KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow

2018-03-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9375 ) Change subject: KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow .. Patch Set 5: (1 comment) http://ger

[kudu-CR] KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow

2018-03-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9375 ) Change subject: KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow .. Patch Set 5: (2 comments) http://ge

[kudu-CR] KUDU-2309: /masters can show the wrong list of masters

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 ) Change subject: KUDU-2309: /masters can show the wrong list of masters .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.clouder

[kudu-CR] KUDU-2309: /masters can show the wrong list of masters

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 ) Change subject: KUDU-2309: /masters can show the wrong list of masters .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] KUDU-2309: /masters can show the wrong list of masters

2018-03-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 ) Change subject: KUDU-2309: /masters can show the wrong list of masters .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 9: (1 comment) http://gerrit.cloudera.

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Tidy Bot, Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#9). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connecti

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 8: (1 comment) http://gerrit.cloudera.

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#8). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 7: (1 comment) http://gerrit.cloudera.

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#7). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 6: > Build Failed > > http://jenkins.

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 6: (1 comment) http://gerrit.cloudera.

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#6). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#5). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-19 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#4). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 3: (17 comments) Since there's a lot o

[kudu-CR] KUDU-2031: Add metrics per connection to the reactor metrics

2018-02-15 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#3). Change subject: KUDU-2031: Add metrics per connection to the reactor metrics ..

[kudu-CR] KUDU-2031: Add metrics per connection to the reactor metrics

2018-02-15 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#2). Change subject: KUDU-2031: Add metrics per connection to the reactor metrics ..

[kudu-CR] KUDU-2031: Add metrics per connection to the reactor metrics

2018-02-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9343 Change subject: KUDU-2031: Add metrics per connection to the reactor metrics .. KUDU-2031: Add metrics per connection to the reactor metr

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 10: Code-Review+1 (2 comments) This LGTM ht

[kudu-CR] jsonwriter: small optimization for PB fields

2018-02-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9184 ) Change subject: jsonwriter: small optimization for PB fields .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] jsonwriter: small optimization for repeated PB fields

2018-02-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9184 ) Change subject: jsonwriter: small optimization for repeated PB fields .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-01-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 5: (13 comments) http://gerrit.cloudera.org:

[kudu-CR](branch-1.6.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9055 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 1: Code-Review+1 -- To view, visit http:

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7821 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 3: Code-Review+2 I tested this on platfor

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-01-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:80

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-13 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8789 to look at the new patch set (#10). Change subject: KUDU-2228: Make Messenger options configurable

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8789 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8789/8/

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-13 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8789 to look at the new patch set (#9). Change subject: KUDU-2228: Make Messenger options configurable .

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-13 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8789 to look at the new patch set (#8). Change subject: KUDU-2228: Make Messenger options configurable .

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8789 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/8789/7

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8789 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/8789/7/

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8789 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/8789/6

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-08 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8789 to look at the new patch set (#7). Change subject: KUDU-2228: Make Messenger options configurable .

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8789 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8789/4/

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-08 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8789 to look at the new patch set (#6). Change subject: KUDU-2228: Make Messenger options configurable .

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-08 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8789 to look at the new patch set (#5). Change subject: KUDU-2228: Make Messenger options configurable .

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8789 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/8789/

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-08 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8789 to look at the new patch set (#4). Change subject: KUDU-2228: Make Messenger options configurable .

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8789 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 3: The last failure looks like a flaky test in: MultiThread

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-07 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8789 to look at the new patch set (#3). Change subject: KUDU-2228: Make Messenger options configurable

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8789 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/8789/

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-07 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8789 to look at the new patch set (#2). Change subject: KUDU-2228: Make Messenger options configurable

[kudu-CR] [rpc] WIP: Introduce configurable options to Messenger

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. ( http://gerrit.cloudera.org:8080/6520 ) Change subject: [rpc] WIP: Introduce configurable options to Messenger .. Abandoned Re-did the patch here: https://gerrit.cloudera.org/#/c/8789/

[kudu-CR] KUDU-2228: Make Messenger options configurable

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8789 Change subject: KUDU-2228: Make Messenger options configurable .. KUDU-2228: Make Messenger options configurable Currently, the RPC laye

[kudu-CR] KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8755 ) Change subject: KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional .. Patch Set 5: (3 comments) Sorry for the late r

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8700 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Patch Set 5: (1 comment) http://gerrit.cloude

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8700 to look at the new patch set (#5). Change subject: [security] Make the kerberos principal configurable for Kudu servers

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8700 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Patch Set 4: (1 comment) http://gerrit.cloude

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8700 to look at the new patch set (#4). Change subject: [security] Make the kerberos principal configurable for Kudu servers

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8700 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Patch Set 3: (1 comment) http://gerrit.cloude

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8700 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Patch Set 3: (2 comments) http://gerrit.cloud

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8700 to look at the new patch set (#3). Change subject: [security] Make the kerberos principal configurable for Kudu servers ...

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8700 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Patch Set 2: (1 comment) http://gerrit.cloude

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8700 to look at the new patch set (#2). Change subject: [security] Make the kerberos principal configurable for Kudu servers ...

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-11-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8700 Change subject: [security] Make the kerberos principal configurable for Kudu servers .. [security] Make the kerberos principal configura

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: > > Would it make more sense to just call it

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 2: Would it make more sense to just call it Get

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-19 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8595 to look at the new patch set (#2). Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. KUD

[kudu-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8595 Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. KUDU-2220: GetEndOfChainX509 does not return end-user cert

[kudu-CR] WIP: tls socket: properly handle temporary socket errors in Writev

2017-11-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 ) Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: (1 comment) http://gerrit.cloudera

[kudu-CR] WIP: tls socket: properly handle temporary socket errors in Writev

2017-11-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 ) Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: (1 comment) http://gerrit.cloudera

[kudu-CR] WIP: tls socket: properly handle temporary socket errors in Writev

2017-11-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 ) Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: Code-Review+1 The fix makes sense t

[kudu-CR] Allow configuration of values passed into kerberos env vars

2017-10-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8247 ) Change subject: Allow configuration of values passed into kerberos env vars .. Patch Set 2: > Build Failed > > http://jenkins.kudu.ap

[kudu-CR] Allow configuration of values passed into kerberos env vars

2017-10-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8247 ) Change subject: Allow configuration of values passed into kerberos env vars .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:80

[kudu-CR] Allow configuration of values passed into kerberos env vars

2017-10-12 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8247 to look at the new patch set (#2). Change subject: Allow configuration of values passed into kerberos env vars .

[kudu-CR] Allow configuration of values passed into kebreros env vars

2017-10-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8247 ) Change subject: Allow configuration of values passed into kebreros env vars .. Patch Set 1: Looks like a flaky timeout failure in clien

[kudu-CR] Allow configuration of values passed into kebreros env vars

2017-10-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8247 Change subject: Allow configuration of values passed into kebreros env vars .. Allow configuration of values passed into kebreros env var

[kudu-CR] Allow configuration of values passed into kebreros env vars

2017-10-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8247 ) Change subject: Allow configuration of values passed into kebreros env vars .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] Allow the SASL protocol service name to be configurable

2017-10-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8218 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 7: (3 comments) > Build Failed > > http://jenki

[kudu-CR] Allow the SASL protocol service name to be configurable

2017-10-05 Thread Sailesh Mukil (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8218 to look at the new patch set (#7). Change subject: Allow the SASL protocol service name to be configurable ...

[kudu-CR] Allow the SASL protocol service name to be configurable

2017-10-05 Thread Sailesh Mukil (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8218 to look at the new patch set (#6). Change subject: Allow the SASL protocol service name to be configurable ...

[kudu-CR] Allow the SASL protocol service name to be configurable

2017-10-05 Thread Sailesh Mukil (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8218 to look at the new patch set (#5). Change subject: Allow the SASL protocol service name to be configurable ...

[kudu-CR] Allow the SASL protocol service name to be configurable

2017-10-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8218 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/

[kudu-CR] Allow the SASL protocol service name to be configurable

2017-10-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8218 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#

  1   2   3   >