[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-02 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. [tools] ksck checksums: Factor out of main ksck code T

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 9: Code-Review+2 (3 comments) http://gerrit.clouder

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#9). Change subject: [tools] ksck checksums: Factor out of main ksck code .

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 8: (8 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#8). Change subject: [tools] ksck checksums: Factor out of main ksck code .

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 6: (4 comments) A couple of nits, otherwise LGTM.

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-10-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#7). Change subject: [tools] ksck checksums: Factor out of main ksck code .

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 6: Verified+1 Precommit failure due to known + unrel

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: [tools] ksck checksums: Factor out of main ksck code .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11488 To unsubsc

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 5: Fixed some bad indenting. -- To view, visit htt

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-24 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#6). Change subject: [tools] ksck checksums: Factor out of main ksck code

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-23 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#5). Change subject: [tools] ksck checksums: Factor out of main ksck code

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-23 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-21 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#4). Change subject: [tools] ksck checksums: Factor out of main ksck code

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-20 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#3). Change subject: [tools] ksck checksums: Factor out of main ksck code

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-20 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#2). Change subject: [tools] ksck checksums: Factor out of main ksck code

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-20 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11488 Change subject: [tools] ksck checksums: Factor out of main ksck code .. [tools] ksck checksums: Factor out of main ksck code To prepare