[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. KUDU-1831. Java client does not check if the primary key co

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-26 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 4: > (1 comment) > > I'm good with the change, just one javadoc co

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-26 Thread Jun He (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5723 to look at the new patch set (#4). Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first ...

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 3: (1 comment) I'm good with the change, just one javado

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-23 Thread Jun He (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5723 to look at the new patch set (#3). Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first ...

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-23 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5723/2/java/kudu-

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-23 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: > (1 comment) > > Jun, what motivated you to make this change i

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-23 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: -Code-Review (1 comment) Jun, what motivated you to m

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-20 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: Thanks for the discussion. Remove the new code from Schema class

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-19 Thread Jun He (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5723 to look at the new patch set (#2). Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first ...

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-19 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: Based on https://github.com/apache/kudu/blob/master/java/kudu-cli

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-19 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: > It seems like in the context of a projection, we don't want to

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-18 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: > I'm pretty sure we don't want this limitation, see > https://gi

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: > It seems like in the context of a projection, we don

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: It seems like in the context of a projection, we don't want t

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: Code-Review-2 I'm pretty sure we don't want this limit

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-15 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/5723 Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. KUDU-1831. Java client does not check i