[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-08-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 28: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-08-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 28: (1 comment)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-08-30 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#28). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-08-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 27: (1 comment)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-08-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 27: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-08-27 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 27: (10 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-08-27 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#27). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-08-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 26: (10 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-08-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 25: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-08-12 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#25). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-23 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 24: (1 comment) > Patch Set 24: Code-Review+2 > > (1

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 24: Code-Review+2 (1 comment) Looks good to me, though let's

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-23 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 24: (2 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-23 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#24). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 23: (1 comment)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 23: (1 comment) > Patch Set 22: > > Due to the variable length

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-20 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#23). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-20 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 22: (4 comments) While double checking maximum lengths for

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 22: (4 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-19 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#22). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-19 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 21: (9 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-19 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#21). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-17 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 20: (1 comment)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 20: (1 comment)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 20: (7 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-17 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#20). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-17 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 19: (3 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 19: (3 comments) I had some questions about how CHAR padding

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-16 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#19). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-15 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#18). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 18: (11 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 17: (9 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 17: (12 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-15 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#17). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 16: (15 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 16: (6 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-30 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#16). Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-30 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#15). Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-30 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#14). Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 10: (6 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-29 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 13: (8 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-29 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#13). Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-29 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#12). Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-29 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#11). Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 10: (10 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-29 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#10). Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-29 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#9). Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-29 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#8). Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-06-29 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#7). Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1