[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 Remove round-robin for block placement This is the first of a multi-patch patchset t

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 47: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6636 To unsubscribe, vis

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 47: (3 comments) @dralves: this patch doesn't have that sort of test. Will add in a follow-up http:

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#47). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 46: last q: do you have a test that makes sure a ts boots from an old superblock (with no dd

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 40: (3 comments) looks, just nits. http://gerrit.cloudera.org:8080/#/c/6636/40/src/kudu/fs/

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 45: Code-Review+2 Verified+1 Known flake, let's override Jenkins. -- To view, visit http://gerrit.cl

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 45: (4 comments) http://gerrit.cloudera.org:8080/#/c/6636/44/src/kudu/tablet/tablet_metadata.h File

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-02 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#45). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 44: (4 comments) http://gerrit.cloudera.org:8080/#/c/6636/44/src/kudu/tablet/tablet_metadata.h File

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-01 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#44). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-01 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#43). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-30 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#42). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 41: Code-Review-1 Adding results to verify implementation of po2c. -- To view, visit http://gerrit.

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-30 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#41). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 40: build failure is from a TSAN flake -- To view, visit http://gerrit.cloudera.org:8080/6636 To un

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-25 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#40). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 35: (1 comment) http://gerrit.cloudera.org:8080/#/c/6636/35/src/kudu/fs/block_manager-test.cc File s

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-24 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#38). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 37: (88 comments) http://gerrit.cloudera.org:8080/#/c/6636/35//COMMIT_MSG Commit Message: PS35, Lin

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-24 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#37). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-24 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#36). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 35: (28 comments) http://gerrit.cloudera.org:8080/#/c/6636/35/src/kudu/cfile/bloomfile-test-base.h

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 35: (5 comments) http://gerrit.cloudera.org:8080/#/c/6636/35/src/kudu/fs/block_manager-test.cc File

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 35: k, think I'm done for this round -- To view, visit http://gerrit.cloudera.org:8080/6636

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 35: (5 comments) http://gerrit.cloudera.org:8080/#/c/6636/35/src/kudu/fs/data_dirs.cc File s

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 35: (10 comments) http://gerrit.cloudera.org:8080/#/c/6636/35/src/kudu/fs/data_dirs.cc File

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 35: (12 comments) http://gerrit.cloudera.org:8080/#/c/6636/35/src/kudu/fs/data_dirs-test.cc

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 35: (12 comments) posting my previous comments. looking through the rest now http://gerrit.

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 35: (11 comments) only about 50% through, but figured I'd post a couple comments I have so far http

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-17 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#35). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-17 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#34). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 33: Code-Review-1 Getting to the bottom of all the test failures. -- To view, visit http://gerrit.c

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-17 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#33). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-17 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#32). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-17 Thread Andrew Wong (Code Review)
Hello Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#31). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 Rem

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 30: Code-Review-1 As per our discussion, I'll update the usages of UUID indices to instead be UUIDs.

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 30: I'm looking -- To view, visit http://gerrit.cloudera.org:8080/6636 To unsubscribe, visi

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 30: Code-Review+1 Verified+1 Test failure is a known flake. Todd/David, I think this is good to go as

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 29: (4 comments) http://gerrit.cloudera.org:8080/#/c/6636/24/src/kudu/fs/data_dirs.cc File src/kudu/

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-15 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#29). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 26: (4 comments) Just skimmed through. I need to get better understanding of the background to g

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 28: (2 comments) Build failure is due to Kudu Java Client failure, seems unrelated. http://gerrit.c

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-15 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#28). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-14 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#27). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-12 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#26). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-12 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#25). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#24). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/6636/23/src/kudu/fs/data_dirs.cc File src/kudu/f

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/6636/18/src/kudu/fs/data_dirs.cc File src/kudu/fs

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#23). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#22). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 21: (8 comments) http://gerrit.cloudera.org:8080/#/c/6636/18/src/kudu/fs/block_manager-test.cc File

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#21). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#20). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#19). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 18: (9 comments) http://gerrit.cloudera.org:8080/#/c/6636/18/src/kudu/fs/block_manager-test.cc File s

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 18: (33 comments) Failure from LINT and a memory leak in ASAN data_dirs-test dist-test (looking int

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-10 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#18). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 17: (18 comments) http://gerrit.cloudera.org:8080/#/c/6636/17//COMMIT_MSG Commit Message: PS17, Lin

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 17: (12 comments) http://gerrit.cloudera.org:8080/#/c/6636/17/src/kudu/fs/block_manager-test.cc File

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#17). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#16). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/6636/15/src/kudu/fs/block_manager-test.cc File s

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 14: (27 comments) I moved the definition of DataDirGroup back to the .h since it's used by one of t

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#15). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 14: (27 comments) OK, I reviewed everything. It'd be nice to see a directed unit test for DataDirMan

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 14: (24 comments) http://gerrit.cloudera.org:8080/#/c/6636/12/src/kudu/fs/data_dirs.cc File src/kudu

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-01 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#14). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 12: (26 comments) Did another pass, still not done though. http://gerrit.cloudera.org:8080/#/c/6636/

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#12). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#11). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 10: (37 comments) http://gerrit.cloudera.org:8080/#/c/6636/9/src/kudu/fs/block_manager.h File src/ku

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#10). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 9: (37 comments) I reviewed everything but the data_dir changes and the new test. Mostly style stuff

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#9). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 Re

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#8). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 Re

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#7). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 Re

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-20 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#6). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 Re