[kudu-CR] KUDU-2971 p1: add subprocess module

2019-11-19 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. KUDU-2971 p1: add subprocess module Utility classes exist that allow for IPC

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-11-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-11-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14425 to look at the new patch set (#5). Change subject: KUDU-2971 p1: add subprocess module

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-11-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 4: (8 comments) > Patch Set 2: > > > Patch Set 2: Code-Review+1 > > > >

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-11-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14425 to look at the new patch set (#4). Change subject: KUDU-2971 p1: add subprocess module

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-11-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 3: (3 comments) I added a few comments to supbprocess_protocol.cc -

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-10-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 2: > Patch Set 2: Code-Review+1 > > (1 comment) > > I think this

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-10-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 2: Code-Review+1 (1 comment) I think this refactoring makes sense. I'm

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-10-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-10-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-10-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 2: (2 comments) Not a full review, but I'm gathering more context

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-10-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-10-14 Thread Hao Hao (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14425 to look at the new patch set (#2). Change subject: KUDU-2971 p1: add subprocess module .. KUDU-2971 p1:

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-10-14 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14425 Change subject: KUDU-2971 p1: add subprocess module .. KUDU-2971 p1: add subprocess module This commit separates a facility class that