Todd Lipcon has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4789
To unsubscribe, visit
Todd Lipcon has submitted this change and it was merged.
Change subject: KuduRPC integration with OpenSSL
..
KuduRPC integration with OpenSSL
This patch adds SSL support for the RPC layer in Kudu. It uses the
OpenSSL library
Alexey Serbin has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4789
To unsubscribe, visit
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 8: Code-Review+1
(11 comments)
Carry +1.
http://gerrit.cloudera.org:8080/#/c/4789/7//COMMIT_MSG
Commit Message:
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#8).
Change subject: KuduRPC integration with OpenSSL
Todd Lipcon has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4789/7/LICENSE.txt
File LICENSE.txt:
Line 533:
Alexey Serbin has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 7: Code-Review+1
(8 comments)
LGTM, just a couple of nits and a questions regarding TLS version: I guess
Dan Burkert has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 7: Code-Review+1
(2 comments)
LGTM, just a few small nits.
Todd Lipcon has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 7: Code-Review+1 Verified-1
OK, this looks good to me. I'm guessing it will need a rebase, and we're
waiting on the
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 6:
(18 comments)
http://gerrit.cloudera.org:8080/#/c/4789/6/LICENSE.txt
File LICENSE.txt:
PS6, Line 512:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#7).
Change subject: KuduRPC integration with OpenSSL
..
KuduRPC integration with
Todd Lipcon has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 6:
btw, you can edit build-support/lint.sh to exclude the x509_check_host.cc file
from lint checking.
--
To view,
Todd Lipcon has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 6:
(16 comments)
http://gerrit.cloudera.org:8080/#/c/4789/6/LICENSE.txt
File LICENSE.txt:
PS6, Line 512:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#6).
Change subject: KuduRPC integration with OpenSSL
..
KuduRPC integration with
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 5:
(2 comments)
Should I convert all the C-style casts in the ported code to C++ style casts?
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 4:
(34 comments)
http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/rpc/connection.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#5).
Change subject: KuduRPC integration with OpenSSL
..
KuduRPC integration with
Alexey Serbin has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/util/net/ssl_socket.cc
File
Alexey Serbin has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 4:
(4 comments)
Some more comments.
http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/util/net/socket.cc
File
Todd Lipcon has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 4:
(24 comments)
http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/rpc/connection.cc
File
Alexey Serbin has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 4:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/rpc/connection.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#4).
Change subject: KuduRPC integration with OpenSSL
..
KuduRPC integration with
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4789/3/src/kudu/rpc/reactor.cc
File src/kudu/rpc/reactor.cc:
Sailesh Mukil has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 2:
(83 comments)
Thanks Dan, Alexey and Todd. I've made the changes.
Sorry for the delay.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4789
to look at the new patch set (#3).
Change subject: KuduRPC integration with OpenSSL
..
KuduRPC integration with
Todd Lipcon has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 2:
(44 comments)
http://gerrit.cloudera.org:8080/#/c/4789/2//COMMIT_MSG
Commit Message:
Line 34: - Make SSL
Todd Lipcon has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4789/2/src/kudu/util/net/ssl_factory.cc
File
Alexey Serbin has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 2:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/4789/2/CMakeLists.txt
File CMakeLists.txt:
PS2, Line 834:
Dan Burkert has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 2:
As a general note, I'm pretty sure this is going to bump the minimum version
requirement on Centos 6 to
Dan Burkert has posted comments on this change.
Change subject: KuduRPC integration with OpenSSL
..
Patch Set 1:
(13 comments)
This is great. Did a quick first pass mostly looking at style, I'll take a
harder look at the
30 matches
Mail list logo
