[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5760 To unsubscribe, visit

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5760 To unsubscribe, visit

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-25 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#13). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/5760/12/src/kudu/rpc/server_negotiation.cc File

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-25 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#12). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 10: (13 comments) http://gerrit.cloudera.org:8080/#/c/5760/10/src/kudu/rpc/connection.h File

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/5760/10/src/kudu/rpc/reactor.cc File

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-25 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#11). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 10: (13 comments) Overall looks great, just a few nits. Probably, I'll do another pass after

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-25 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#10). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/5760/7/src/kudu/rpc/reactor.cc File

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-24 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#8). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 7: Code-Review+2 (1 comment)

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#7). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 6: (12 comments) http://gerrit.cloudera.org:8080/#/c/5760/5/src/kudu/rpc/client_negotiation.cc File

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-23 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#6). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 5: (12 comments) Seems like there is some kind of openssl-related leak as well: Direct leak of 4848

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/5760/4/src/kudu/rpc/connection.cc File

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-21 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#5). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-21 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#4). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-21 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#3). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-20 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#2). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5760 to review the following change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation