[kudu-CR] bshuf block: some code cleanup

2016-11-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: bshuf_block: some code cleanup .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5193/6/src/kudu/cfile/bshuf_block.cc File src/kudu/cfile/bshuf_bl

[kudu-CR] bshuf block: some code cleanup

2016-11-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: bshuf_block: some code cleanup .. bshuf_block: some code cleanup * Some typo/grammar fixes/reformatting in comments. * Rename kMaxHeaderSize to kHeaderSiz

[kudu-CR] bshuf block: some code cleanup

2016-11-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: bshuf_block: some code cleanup .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5193/6/src/kudu/cfile/bshuf_block.cc File src/kudu/cfile/bshuf_bloc

[kudu-CR] bshuf block: some code cleanup

2016-11-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: bshuf_block: some code cleanup .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5193 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR] bshuf block: some code cleanup

2016-11-29 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5193 to look at the new patch set (#7). Change subject: bshuf_block: some code cleanup .. bshuf_block: so

[kudu-CR] bshuf block: some code cleanup

2016-11-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: bshuf_block: some code cleanup .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5193/6/src/kudu/cfile/bshuf_block.cc File src/kudu/cfile/bshuf_bloc

[kudu-CR] bshuf block: some code cleanup

2016-11-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: bshuf_block: some code cleanup .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5193/6/src/kudu/cfile/bshuf_block.cc File src/kudu/cfile/bshuf_bl

[kudu-CR] bshuf block: some code cleanup

2016-11-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: bshuf_block: some code cleanup .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5193/6/src/kudu/cfile/bshuf_block.cc File src/kudu/cfile/bshuf_block

[kudu-CR] bshuf block: some code cleanup

2016-11-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: bshuf_block: some code cleanup .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5193 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] bshuf block: some code cleanup

2016-11-29 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5193 to look at the new patch set (#6). Change subject: bshuf_block: some code cleanup .. bshuf_block: some code cleanup

[kudu-CR] bshuf block: some code cleanup

2016-11-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: bshuf_block: some code cleanup .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/5193/3/src/kudu/cfile/bshuf_block.cc File src/kudu/cfile/bshuf_blo

[kudu-CR] bshuf block: some code cleanup

2016-11-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: bshuf_block: some code cleanup .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/5193/3/src/kudu/cfile/bshuf_block.cc File src/kudu/cfile/bshuf_b

[kudu-CR] bshuf block: some code cleanup

2016-11-23 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5193 to look at the new patch set (#5). Change subject: bshuf_block: some code cleanup .

[kudu-CR] bshuf block: some code cleanup

2016-11-23 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5193 to look at the new patch set (#4). Change subject: bshuf_block: some code cleanup .

[kudu-CR] bshuf block: some code cleanup

2016-11-23 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5193 to look at the new patch set (#3). Change subject: bshuf_block: some code cleanup .. bshuf_block: some code cleanup

[kudu-CR] bshuf block: some code cleanup

2016-11-23 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5193 to look at the new patch set (#2). Change subject: bshuf_block: some code cleanup .. bshuf_block: some code cleanup

[kudu-CR] bshuf block: some code cleanup

2016-11-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5193 Change subject: bshuf_block: some code cleanup .. bshuf_block: some code cleanup * Having just had a bug in the indexing of the 'data_' ar