[kudu-CR] disk failure: add persistent disk states

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 26: (1 comment) http://gerrit.cloudera.org:8080/#/c/7270/26/src/kudu/fs/block_manager_util.cc File src/kud

[kudu-CR] disk failure: add persistent disk states

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 26: (1 comment) http://gerrit.cloudera.org:8080/#/c/7270/26/src/kudu/fs/block_manager_util.cc File src/kud

[kudu-CR] disk failure: add persistent disk states

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 26: Code-Review-1 -- To view, visit http://gerrit.cloudera.org:8080/7270 To unsubscribe, visit http://gerrit

[kudu-CR] disk failure: add persistent disk states

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 26: (10 comments) Note: a significant portion of this revision and those prior have been moved to a separat

[kudu-CR] disk failure: add persistent disk states

2017-08-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 26: (17 comments) http://gerrit.cloudera.org:8080/#/c/7270/26/src/kudu/fs/block_manager_util.cc File src/kudu

[kudu-CR] disk failure: add persistent disk states

2017-08-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 26: Addressed the comments and a slip-up on my part that caused the build to fail. This is ready for review.

[kudu-CR] disk failure: add persistent disk states

2017-08-22 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#26). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 25: (3 comments) http://gerrit.cloudera.org:8080/#/c/7270/25/src/kudu/fs/block_manager_util.cc File src/kudu

[kudu-CR] disk failure: add persistent disk states

2017-08-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 25: (12 comments) http://gerrit.cloudera.org:8080/#/c/7270/24/src/kudu/fs/block_manager_util.cc File src/kud

[kudu-CR] disk failure: add persistent disk states

2017-08-22 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#25). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 24: (13 comments) I didn't finish reviewing data_dirs.cc. Looked at the rest, though. http://gerrit.cloudera

[kudu-CR] disk failure: add persistent disk states

2017-08-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#24). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#23). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#22). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-19 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#21). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#19). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/7270/18/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#18). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#17). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 15: (30 comments) http://gerrit.cloudera.org:8080/#/c/7270/15//COMMIT_MSG Commit Message: Line 11: failed d

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#16). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/7270/15//COMMIT_MSG Commit Message: Line 11: failed dis

[kudu-CR] disk failure: add persistent disk states

2017-08-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 15: (30 comments) Made it further in. Todd should review this too, since he was in that meeting we had to di

[kudu-CR] disk failure: add persistent disk states

2017-08-17 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#15). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-17 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#14). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-15 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#13). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/7270/11/src/kudu/fs/block_manager_util.cc File src/kudu

[kudu-CR] disk failure: add persistent disk states

2017-08-14 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#12). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/7270/10/src/kudu/fs/block_manager_util.cc File src/kudu

[kudu-CR] disk failure: add persistent disk states

2017-08-14 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#11). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-14 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#10). Change subject: disk failure: add persistent disk states .. disk failure: add p

[kudu-CR] disk failure: add persistent disk states

2017-08-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 9: (10 comments) Still working on updating this one. Note that there's now a dependency on a new patch to s

[kudu-CR] disk failure: add persistent disk states

2017-08-10 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#9). Change subject: disk failure: add persistent disk states .. disk failure: add pe

[kudu-CR] disk failure: add persistent disk states

2017-08-10 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#8). Change subject: disk failure: add persistent disk states .. disk failure: add pe

[kudu-CR] disk failure: add persistent disk states

2017-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 6: (29 comments) http://gerrit.cloudera.org:8080/#/c/7270/6/src/kudu/fs/block_manager_util-test.cc File src/

[kudu-CR] disk failure: add persistent disk states

2017-08-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#7). Change subject: disk failure: add persistent disk states .. disk failure: add pe

[kudu-CR] disk failure: add persistent disk states

2017-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 6: (29 comments) http://gerrit.cloudera.org:8080/#/c/7270/6/src/kudu/fs/block_manager_util-test.cc File src/k

[kudu-CR] disk failure: add persistent disk states

2017-08-01 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#6). Change subject: disk failure: add persistent disk states .. disk failure: add pe

[kudu-CR] disk failure: add persistent disk states

2017-08-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 5: (44 comments) I know there are already comments on some of these, but I've moved some of the changes to

[kudu-CR] disk failure: add persistent disk states

2017-08-01 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#5). Change subject: disk failure: add persistent disk states .. disk failure: add pe