[kudu-CR] tool: port log-dump

2016-09-02 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 3: > (3 comments) Thank you for the responses here. -- To view, visit http://gerrit.cloudera.org:8080/4167 To unsubscribe, visi

[kudu-CR] tool: port log-dump

2016-09-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4167/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc:

[kudu-CR] tool: port log-dump

2016-08-31 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 3: (4 comments) Hi Adar, sorry I missed the train here, but these are more of curious questions than review comments as such so

[kudu-CR] tool: port log-dump

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4167 To unsubscribe, visit http://gerrit.cloudera.org:8080/set

[kudu-CR] tool: port log-dump

2016-08-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: port log-dump .. tool: port log-dump This one was more complicated, because log-dump can run against a single file or an entire tablet. So I put all

[kudu-CR] tool: port log-dump

2016-08-30 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4167 to look at the new patch set (#2). Change subject: tool: port log-dump .. tool: port log-dump This one was more co

[kudu-CR] tool: port log-dump

2016-08-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3151/ -- To view, visit http://gerrit.cloudera.org:8080/4167 To unsubscr

[kudu-CR] tool: port log-dump

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 1: Code lgtm. Can you add this to the release note with a pointer to 'kudu wal dump' and 'kudu tablet dump_wals'? -- To view, v

[kudu-CR] tool: port log-dump

2016-08-29 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4167 to review the following change. Change subject: tool: port log-dump .. tool: port log-dump This one was more complica

[kudu-CR] tool: port log-dump

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3144/ -- To view, visit http://gerrit.cloudera.org:8080/4167 To unsubscr