[GitHub] [incubator-livy] captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334263458 ## File path:

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334236659 ## File path:

[GitHub] [incubator-livy] codecov-io edited a comment on issue #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.

2019-10-12 Thread GitBox
codecov-io edited a comment on issue #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#issuecomment-534468593 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr=h1) Report > Merging

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334236623 ## File path:

[GitHub] [incubator-livy] codecov-io edited a comment on issue #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.

2019-10-12 Thread GitBox
codecov-io edited a comment on issue #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#issuecomment-534468593 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr=h1) Report > Merging

[GitHub] [incubator-livy] codecov-io edited a comment on issue #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.

2019-10-12 Thread GitBox
codecov-io edited a comment on issue #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#issuecomment-534468593 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr=h1) Report > Merging

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334236564 ## File path:

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334236191 ## File path:

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334236191 ## File path:

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334236165 ## File path:

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334236165 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r334233145 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r334233110 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r334233247 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232915 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232822 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232637 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232889 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232809 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232745 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232937 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232899 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232791 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232673 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232925 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain

2019-10-12 Thread GitBox
mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334233018 ## File path:

[GitHub] [incubator-livy] mgaido91 commented on issue #193: [LIVY-621]add dynamic service discovery for thrift server

2019-10-12 Thread GitBox
mgaido91 commented on issue #193: [LIVY-621]add dynamic service discovery for thrift server URL: https://github.com/apache/incubator-livy/pull/193#issuecomment-541313667 I agree they are different and they may also lead to separate solutions, but I'd prefer to work on a full proposal