Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/ --- (Updated May 14, 2015, 1:54 a.m.) Review request for mesos, Ben Mahler and Nikl

Re: Review Request 34048: Fixed disappearing search bar: MESOS-2479

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34048/#review83735 --- Ship it! Ship It! - Adam B On May 11, 2015, 11:25 a.m., Ian Babr

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review83738 --- Bad patch! Reviews applied: [29507] Failed command: ./support/appl

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/ --- (Updated May 14, 2015, 3:01 a.m.) Review request for mesos, Ben Mahler and Nikl

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review83747 --- Patch looks great! Reviews applied: [29507] All tests passed. - M

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review83749 --- Ship it! LGTM, minor readibility improvement suggestion. docs/con

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review83758 --- src/master/master.cpp

Re: Review Request 33513: Added a modules-aware factory for allocators.

> On May 11, 2015, 6:26 p.m., Niklas Nielsen wrote: > > src/master/allocator/allocator.cpp, line 39 > > > > > > Unused variable? Did you want to return this somewhere? > > Niklas Nielsen wrote: > Ping - let's get t

Re: Review Request 33513: Added a modules-aware factory for allocators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33513/ --- (Updated May 14, 2015, 1:22 p.m.) Review request for mesos, Kapil Arya, Niklas

Re: Review Request 33514: Wired up --allocator flag in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33514/ --- (Updated May 14, 2015, 1:23 p.m.) Review request for mesos, Kapil Arya, Niklas

Re: Review Request 33514: Wired up --allocator flag in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33514/#review83764 --- Patch looks great! Reviews applied: [33513, 33514] All tests passe

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/#review83786 --- Ship it! Thanks Kapil! It looks SO much better!! LGTM src/exampl

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/#review83787 --- src/examples/test_hook_module.cpp

Re: Review Request 32587: Stopped using RunTaskMessage.framework_id.

> On May 12, 2015, 9:45 a.m., Niklas Nielsen wrote: > > Hey Kapil; what's blocking this patch? > > Adam B wrote: > As part of the deprecation cycle, we need to wait until 0.24 for this > patch. All the relevant 0.23 patches have landed. > "NOTE: This patch is only to be merged _ONLY_ af

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

> On April 22, 2015, 1:53 a.m., Adam B wrote: > > docs/modules.md, lines 165-166 > > > > > > I still think we need a note in upgrades.md since this is a hook API > > change when upgrading. Done :) - Niklas --

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372/ --- (Updated May 14, 2015, 10:06 a.m.) Review request for mesos and Adam B. Chang

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372/#review83802 --- Ship it! Ship It! - Adam B On May 14, 2015, 10:06 a.m., Niklas N

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372/#review83803 --- Patch looks great! Reviews applied: [30961, 30962, 31016, 31028, 32

Review Request 34225: Deleted travis YAML file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34225/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 34225: Deleted travis YAML file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34225/#review83812 --- Ship it! Ship It! - Cody Maloney On May 14, 2015, 6:21 p.m., Vin

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

> On May 14, 2015, 12:38 p.m., Niklas Nielsen wrote: > > src/examples/test_hook_module.cpp, lines 146-150 > > > > > > Looks a bit dense; can we break it up a bit? Ideally, this whole block would be replaced by a sing

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

> On Feb. 11, 2015, 5:27 a.m., Adam B wrote: > > src/tests/hook_tests.cpp, lines 302-305 > > > > > > Did you consider just sending an explicit ShutdownExecutorMessage from > > the slave to the executor? Then you can w

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

> On May 14, 2015, 12:39 p.m., Niklas Nielsen wrote: > > src/examples/test_hook_module.cpp, line 37 > > > > > > Why did you need this one? Without this we would have to use qualify HookExecuted with `internal::`. (Not

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review83823 --- include/mesos/mesos.proto

Re: Review Request 34137: Add support for container image provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/#review83824 --- src/slave/containerizer/mesos/containerizer.cpp

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review83690 --- src/slave/containerizer/isolators/network/port_mapping.hpp

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 14, 2015, 7:44 p.m., Jie Yu wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1767 > > > > > > No need to use `filter::` prefix for `filter::Filter` as it's already > > included. W

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/#review83850 --- Bad patch! Reviews applied: [29327] Failed command: ./support/appl

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 14, 2015, 7:44 p.m., Jie Yu wrote: > > src/slave/containerizer/isolators/network/port_mapping.hpp, line 329 > > > > > > Please add some comments about what this is. Consider using hashset > > instead of std::

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/ --- (Updated May 14, 2015, 9:39 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 34139: AppC image discovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34139/#review83825 --- src/slave/containerizer/provisioners/appc/discovery.hpp

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

> On May 7, 2015, 12:38 a.m., Jie Yu wrote: > > include/mesos/mesos.proto, lines 454-458 > > > > > > Chatted with Vinod offline (PS: Vinod is going to send out a summary of > > the discussion). > > > > In sho

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/ --- (Updated May 14, 2015, 11:57 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/#review83880 --- Patch looks great! Reviews applied: [33865] All tests passed. - M

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

> On March 6, 2015, 1:19 p.m., Joerg Schad wrote: > > src/master/flags.hpp, line 383 > > > > > > Shouldn't this also be added to the documentation (i.e. > > http://mesos.apache.org/documentation/latest/configuration/)