On May 13, 2015, 11:19 a.m., Adam B wrote:
src/master/http.cpp, lines 279-288
https://reviews.apache.org/r/30612/diff/15/?file=947349#file947349line279
One thing I'm not 100% clear about from this description: Are each of
these levels strict subsets of the json hierarchy, or e.g.
On May 18, 2015, 3:18 p.m., Till Toenshoff wrote:
src/master/http.cpp, line 312
https://reviews.apache.org/r/30612/diff/15/?file=947349#file947349line312
`const`?
Cannot be const because the operator `[]` provides no const overload (common
problem on the std library)
On May 18,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33792/#review84457
---
Ship it!
Ship It!
- Alexander Rojas
On May 20, 2015, 4:06 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032/#review84465
---
3rdparty/libprocess/include/process/http.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34442/
---
(Updated May 20, 2015, 5:16 a.m.)
Review request for mesos, Ian Downes, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84464
---
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34442/
---
Review request for mesos, Ian Downes, Niklas Nielsen, and Vinod Kone.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34442/#review84422
---
Bad patch!
Reviews applied: [34308, 34309, 34442]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34308/
---
(Updated May 19, 2015, 5:29 p.m.)
Review request for mesos and Vinod Kone.
On May 19, 2015, 6:56 p.m., Joris Van Remoortere wrote:
Hey Ian, looks good.
I have a prototype for testing the pre-emption. I will add some reviews
that depend on this patch set, as I will need to introduce sched_affinity
first.
I've added the test in subsequent reviews:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34442/
---
(Updated May 20, 2015, 2:55 a.m.)
Review request for mesos, Ian Downes, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34294/
---
(Updated May 19, 2015, 11:56 p.m.)
Review request for mesos, Dave Lester and
On May 17, 2015, 7:03 a.m., Adam B wrote:
Thank you for putting this together. This will help people decide where to
turn when they need advice or a shepherd/reviewer.
Please allow me to suggest some additional components and maintainers, and
clarify some terminology/formatting.
My
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/#review84445
---
src/linux/routing/queueing/fq_codel.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34308/#review84426
---
Ship it!
Ship It!
- Vinod Kone
On May 20, 2015, 12:29 a.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33792/
---
(Updated May 20, 2015, 2:06 a.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34442/#review84453
---
src/linux/sched.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33823/
---
(Updated May 19, 2015, 2:19 p.m.)
Review request for mesos, Isabel Jimenez,
On May 5, 2015, 10:42 p.m., Vinod Kone wrote:
include/mesos/executor/executor.proto, line 48
https://reviews.apache.org/r/33823/diff/1/?file=949198#file949198line48
Is FrameworkID not present in FrameworkInfo?
It is but it is optional. Should we instead expect it to be there and
On May 9, 2015, 4:27 a.m., Marco Massenzio wrote:
include/mesos/executor/executor.hpp, line 22
https://reviews.apache.org/r/33823/diff/1/?file=949197#file949197line22
please avoid SCREAMING COMMENTS :)
(also, not sure what is the use of that comment? is it a TODO? should
we
On May 14, 2015, 9:39 a.m., Niklas Nielsen wrote:
src/examples/test_hook_module.cpp, line 37
https://reviews.apache.org/r/29947/diff/10/?file=958466#file958466line37
Why did you need this one?
Kapil Arya wrote:
Without this we would have to use qualify HookExecuted with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review84314
---
src/master/http.cpp
On May 18, 2015, 1:18 p.m., Till Toenshoff wrote:
src/master/http.cpp, line 312
https://reviews.apache.org/r/30612/diff/15/?file=947349#file947349line312
`const`?
Alexander Rojas wrote:
Cannot be const because the operator `[]` provides no const overload
(common problem on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34310/#review84338
---
LGTM - Can we wire up a test for this?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/#review84359
---
can you please make sure to run 'make check' on OSX?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34389/#review84360
---
Ship it!
Ship It!
- Vinod Kone
On May 19, 2015, 1:56 a.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34420/#review84363
---
Looks like we need to add a step for resolving the JIRA ticket
On May 19, 2015, 4:53 p.m., Niklas Nielsen wrote:
src/linux/sched.hpp, line 51
https://reviews.apache.org/r/34309/diff/2/?file=963181#file963181line51
Want to add some context to which pid that you couldn't get the policy
for? For example: Failed to get scheduler policy for pid:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/
---
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/#review84234
---
Hey Ian, looks good.
I have a prototype for testing the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34295/#review84361
---
Ship it!
docs/committers.md
On May 16, 2015, 4:46 a.m., Timothy Chen wrote:
src/slave/containerizer/isolators/cgroups/cpushare.cpp, line 345
https://reviews.apache.org/r/34310/diff/1/?file=961963#file961963line345
What if the same set of resources contains both revocable and
non-revocable resources?
Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review84380
---
src/cli/mesos.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34438/#review84400
---
Ship it!
Ship It!
- Jie Yu
On May 19, 2015, 9:44 p.m., Chi
On May 19, 2015, 9:53 a.m., Niklas Nielsen wrote:
src/tests/sched_tests.cpp, line 45
https://reviews.apache.org/r/34309/diff/2/?file=963182#file963182line45
Any reason not to use the fork abstraction? If not, want to explicitly
use ::fork()?
I only want a single child so the
On May 19, 2015, 12:42 p.m., Vinod Kone wrote:
My high leve comment:
Lets add the following check/invariant in the master:
An executor and all its tasks should all use regular resources or should
all use revocable resources.
We can relax this policy in the future when we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/#review84375
---
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
On May 9, 2015, 2:27 a.m., Marco Massenzio wrote:
include/mesos/executor/executor.hpp, line 22
https://reviews.apache.org/r/33823/diff/1/?file=949197#file949197line22
please avoid SCREAMING COMMENTS :)
(also, not sure what is the use of that comment? is it a TODO? should
we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34193/
---
(Updated May 19, 2015, 10:31 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/
---
(Updated May 19, 2015, 7:55 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34259/#review84379
---
Ship it!
Ship It!
- Vinod Kone
On May 17, 2015, 7:47 p.m., Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34420/#review84393
---
Patch looks great!
Reviews applied: [34420]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34310/
---
(Updated May 19, 2015, 12:58 p.m.)
Review request for mesos, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/
---
(Updated May 19, 2015, 12:58 p.m.)
Review request for mesos, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34321/
---
(Updated May 19, 2015, 8:27 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34416/#review84383
---
Patch looks great!
Reviews applied: [34416]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34438/
---
Review request for mesos, Ben Mahler, Evelina Dumitrescu, and Jie Yu.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34438/#review84399
---
Ship it!
Thanks! Minor style thing below which I'll clean up for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34310/
---
(Updated May 19, 2015, 3:43 p.m.)
Review request for mesos, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33793/#review84376
---
Thanks! Can you have a look at my comments on r/34068/ and apply
On May 19, 2015, 9:53 a.m., Niklas Nielsen wrote:
src/linux/sched.hpp, line 51
https://reviews.apache.org/r/34309/diff/2/?file=963181#file963181line51
Want to add some context to which pid that you couldn't get the policy
for? For example: Failed to get scheduler policy for pid:
On May 19, 2015, 4:53 p.m., Niklas Nielsen wrote:
src/linux/sched.hpp, line 51
https://reviews.apache.org/r/34309/diff/2/?file=963181#file963181line51
Want to add some context to which pid that you couldn't get the policy
for? For example: Failed to get scheduler policy for pid:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84370
---
Thanks for the test! I left some comments that are relevant to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34392/#review84320
---
Up for discussion: Given that `Time` should remain closely bound to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated May 19, 2015, 8:58 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34308/#review84329
---
LGTM - want to add a test in src/tests/resources_tests.cpp too?
-
On May 19, 2015, 5:54 p.m., Till Toenshoff wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, lines 41-42
https://reviews.apache.org/r/34392/diff/1/?file=963337#file963337line41
Why did you wrap this function head?
I don't start your question.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34310/#review84353
---
src/slave/containerizer/isolators/cgroups/cpushare.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34388/
---
(Updated May 19, 2015, 5:39 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34420/
---
Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34321/
---
(Updated May 19, 2015, 6:20 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/#review84366
---
src/linux/sched.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review84372
---
Patch looks great!
Reviews applied: [32198, 32163, 30612]
All
63 matches
Mail list logo
