Re: Review Request 34361: converted hard-coded strings to consts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/ --- (Updated May 25, 2015, 6:59 a.m.) Review request for mesos. Bugs: MESOS-2637

Re: Review Request 34361: converted hard-coded strings to consts

> On May 20, 2015, 11:47 a.m., Alexander Rojas wrote: > > src/examples/test_hook_module.cpp, lines 36-38 > > > > > > This constants are used nowhere but in one method. Is there any reason > > why they are not defined i

Re: Review Request 34361: converted hard-coded strings to consts

> On May 18, 2015, 5:48 p.m., Marco Massenzio wrote: > > src/examples/test_hook_module.cpp, lines 36-38 > > > > > > Thanks for doing this! > > > > I'm wondering whether, as these are constants, shouldn't they b

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34318/ --- (Updated May 25, 2015, 4:36 p.m.) Review request for mesos. Changes ---

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/ --- (Updated May 25, 2015, 4:38 p.m.) Review request for mesos. Changes ---

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

> On May 20, 2015, 5:50 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 157 > > > > > > Btw after looking at your other patches, I realize we don't really need > > hasenv an

Re: Review Request 34317: Updated callers of os::getenv() in /src.

> On May 20, 2015, 5:49 p.m., Timothy Chen wrote: > > src/examples/balloon_framework.cpp, line 207 > > > > > > Why not Option value = os::getenv("MESOS_BUILD_DIR")? > > Greg Mann wrote: > I think that in the case

Re: Review Request 34317: Updated callers of os::getenv() in /src.

> On May 20, 2015, 5:49 p.m., Timothy Chen wrote: > > src/examples/low_level_scheduler_libprocess.cpp, line 353 > > > > > > ditto Moved declaration and assignment onto same line. - Greg ---

Re: Review Request 34317: Updated callers of os::getenv() in /src.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/ --- (Updated May 25, 2015, 4:41 p.m.) Review request for mesos. Changes ---

Re: Review Request 34317: Updated callers of os::getenv() in /src.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/ --- (Updated May 25, 2015, 4:42 p.m.) Review request for mesos. Bugs: MESOS-994

Re: Review Request 34319: Refactored os::getenv() to return an option and removed os::hasenv()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/ --- (Updated May 25, 2015, 4:43 p.m.) Review request for mesos. Summary (updated)

Re: Review Request 34317: Updated callers of os::getenv() in /src and removed calls to os::hasenv()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/ --- (Updated May 25, 2015, 4:44 p.m.) Review request for mesos. Summary (updated)

Review Request 34655: Use relative url in /help generated links point

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34655/ --- Review request for mesos and Adam B. Bugs: MESOS-2748 https://issues.apache

Re: Review Request 34644: Update existing lambdas to meet style guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34644/#review85136 --- 3rdparty/libprocess/src/tests/process_tests.cpp

Re: Review Request 34645: Update existing lambdas to meet style guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34645/#review85137 --- This is an interesting case. We have a proxy to another function, ra

Re: Review Request 34193: Refactored common functionality into BaseFlags

> On May 24, 2015, 6:35 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 151 > > > > > > I think it would be great if we could consistently use the trailing > >

Review Request 34662: Modularized ResourceEstimator and added test for that module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/ --- Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone

Re: Review Request 34662: Modularized ResourceEstimator and added test for that module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/#review85146 --- src/tests/oversubscription_tests.cpp

Re: Review Request 34662: Modularized ResourceEstimator and added test for that module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/ --- (Updated May 26, 2015, 4:36 a.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34662: Modularized ResourceEstimator and added test for that module

> On May 26, 2015, 4:16 a.m., Szymon Konefal wrote: > > src/tests/oversubscription_tests.cpp, line 80 > > > > > > Why CHECK_SOME rather than ASSERT_SOME? > > CHECK_SOME prints only a log, and ASSERT_SOME could retur

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/ --- (Updated May 26, 2015, 5:29 a.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34631: Added QoS Controller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review85150 --- include/mesos/slave/qos_controller.hpp