Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/#review87520 --- How about adding an 'Address' message, which can contain 'ip' and 'p

Re: Review Request 34910: Added task validation for task using revocable resources while its executor does not.

> On June 3, 2015, 6:08 p.m., Ben Mahler wrote: > > src/tests/master_validation_tests.cpp, lines 1136-1137 > > > > > > I find it nice to reduce "jaggedness" on comments, e.g.: > > > > ``` > > // Create

Re: Review Request 35341: Added Uber to the Powered-by-Mesos page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35341/#review87518 --- Bad patch! Reviews applied: [35341] Failed command: ./support/appl

Re: Review Request 35332: Add a test case for egress flow ID recovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35332/#review87516 --- Patch looks great! Reviews applied: [35331, 35332] All tests passe

Re: Review Request 35341: Added Uber to the Powered-by-Mesos page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35341/#review87514 --- docs/powered-by-mesos.md

Re: Review Request 35341: Added Uber to the Powered-by-Mesos page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35341/ --- (Updated June 10, 2015, 7:41 p.m.) Review request for mesos and Niklas Nielsen.

Re: Review Request 35320: Fixed a bug in the fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35320/#review87511 --- Ship it! Ship It! - Niklas Nielsen On June 10, 2015, 12:48 p.m.,

Re: Review Request 34361: converted hard-coded strings to consts

> On June 9, 2015, 6:25 p.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, lines 3031-3034 > > > > > > Why bother with all this? Why not just have `"key1"`, `"value1"`, > > `"key2"`, `"value2"` inlined appropria

Re: Review Request 35333: Small fix in updateSlave() to make resource math clearer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35333/#review87509 --- Patch looks great! Reviews applied: [35333] All tests passed. - M

Re: Review Request 34361: converted hard-coded strings to consts

> On June 10, 2015, 1:25 a.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, lines 3031-3034 > > > > > > Why bother with all this? Why not just have `"key1"`, `"value1"`, > > `"key2"`, `"value2"` inlined appropri

Review Request 35332: Add a test case for egress flow ID recovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35332/ --- Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Bugs: MESOS-2799

Review Request 35331: Add a test case for egress flow ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35331/ --- Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Bugs: MESOS-2799

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review87503 --- src/docker/docker.cpp

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review87504 --- Patch looks great! Reviews applied: [35330] All tests passed. - M

Re: Review Request 35321: Implemented the fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35321/#review87498 --- Ship it! src/slave/resource_estimators/fixed.cpp

Re: Review Request 35305: Added a SlaveTest to caputure the case when containerizer usage fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35305/#review87501 --- Ship it! Ship It! - Ben Mahler On June 10, 2015, 6:30 p.m., Jie

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review87499 --- Patch looks great! Reviews applied: [35309, 34910, 34911] All test

Re: Review Request 35320: Fixed a bug in the fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35320/#review87497 --- Ship it! Ship It! - Ben Mahler On June 10, 2015, 7:48 p.m., Jie

Review Request 35333: Small fix in updateSlave() to make resource math clearer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35333/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/ --- (Updated June 11, 2015, 12:04 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/ --- (Updated June 11, 2015, 12:01 a.m.) Review request for mesos and Timothy Chen.

Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2797 https://issues.

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/ --- (Updated June 10, 2015, 11:57 p.m.) Review request for mesos, Ben Mahler, Ian D

Re: Review Request 34910: Added task validation for task using revocable resources while its executor does not.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34910/ --- (Updated June 10, 2015, 11:56 p.m.) Review request for mesos, Ben Mahler, Ian D

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review87490 --- Bad patch! Reviews applied: [35309, 34910] Failed command: ./suppo

Re: Review Request 35309: Added Resources::get() and Resources::names().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35309/#review87489 --- Ship it! I can use the code in this review if we get it committed s

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/ --- (Updated June 10, 2015, 11:18 p.m.) Review request for mesos, Ben Mahler, Ian D

Re: Review Request 34910: Added task validation for task using revocable resources while its executor does not.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34910/ --- (Updated June 10, 2015, 11:18 p.m.) Review request for mesos, Ben Mahler, Ian D

Re: Review Request 34910: Added task validation for task using revocable resources while its executor does not.

> On June 10, 2015, 10:03 p.m., Jie Yu wrote: > > src/master/validation.cpp, lines 714-721 > > > > > > Is this check redundent? Can you calculate the total first and do one > > check instead? I originally just had on

Re: Review Request 35327: Fixed a bug that allows different resources of the same name to have different types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35327/ --- (Updated June 10, 2015, 4:14 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 35264: Added a slave integration test in MonitorTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/ --- (Updated June 10, 2015, 11:13 p.m.) Review request for mesos, Ben Mahler, Nikla

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/ --- (Updated June 10, 2015, 11:13 p.m.) Review request for mesos, Ben Mahler, Nikla

Re: Review Request 35327: Fixed a bug that allows different resources of the same name to have different types.

> On June 10, 2015, 3:56 p.m., Vinod Kone wrote: > > src/common/resources.cpp, lines 383-388 > > > > > > No need for else if. > > > > if () { > > > > } > > > > nameTypes[name] = resource.get(

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35229/#review87485 --- src/slave/containerizer/isolators/network/port_mapping.hpp

Re: Review Request 35327: Fixed a bug that allows different resources of the same name to have different types.

> On June 10, 2015, 3:56 p.m., Vinod Kone wrote: > > src/common/resources.cpp, lines 383-388 > > > > > > No need for else if. > > > > if () { > > > > } > > > > nameTypes[name] = resource.get(

Re: Review Request 35327: Fixed a bug that allows different resources of the same name to have different types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35327/#review87482 --- Ship it! src/common/resources.cpp

Re: Review Request 35264: Added a slave integration test in MonitorTest.

> On June 10, 2015, 9:58 p.m., Ben Mahler wrote: > > src/tests/monitor_tests.cpp, line 243 > > > > > > This case is still ok for taking a const &, since it's not a temporary. Fixed. > On June 10, 2015, 9:58 p.m., Be

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

> On June 10, 2015, 9:52 p.m., Ben Mahler wrote: > > src/slave/resource_estimators/fixed.cpp, line 60 > > > > > > Whoops! Remove the reference? This is fixed in https://reviews.apache.org/r/35320/ > On June 10, 2015,

Review Request 35327: Fixed a bug that allows different resources of the same name to have different types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35327/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2854 https://issues.ap

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

> On June 5, 2015, 6:42 p.m., Vinod Kone wrote: > > I made some minor comments below but I think a better way to do this is to > > *not* write custom masterinfo json <-> protobuf converters. I prefer we > > just add a new optional field (say ipAddress of type string). Then you can > > just lev

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review87473 --- Ship it! src/slave/slave.cpp

Re: Review Request 35313: Added slave metrics for revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35313/#review87474 --- Patch looks great! Reviews applied: [35312, 35313] All tests passe

Re: Review Request 35313: Added slave metrics for revocable resources.

> On June 10, 2015, 9:36 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 4400 > > > > > > why the temporary? Didn't fit in a single line for nonRevocable, so I did the same here to keep it consistent, but I'll

Re: Review Request 35313: Added slave metrics for revocable resources.

> On June 10, 2015, 9:49 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 4380 > > > > > > s/std::// > > > > Here and two below. Thanks! - Ben

Re: Review Request 34910: Added task validation for task using revocable resources while its executor does not.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34910/#review87465 --- Ship it! src/master/validation.hpp

Re: Review Request 35264: Added a slave integration test in MonitorTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/#review87468 --- Ship it! src/tests/monitor_tests.cpp

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/#review87459 --- Ship it! src/slave/monitor.cpp

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/#review87440 --- Ship it! src/slave/monitor.cpp

Re: Review Request 35313: Added slave metrics for revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35313/#review87466 --- Ship it! src/slave/slave.cpp

Re: Review Request 35313: Added slave metrics for revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35313/#review87462 --- Ship it! src/slave/slave.cpp

Re: Review Request 35312: Minor cleanup to master/slave metric logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35312/#review87463 --- Ship it! Ship It! - Jiang Yan Xu On June 10, 2015, 12:50 p.m., B

Re: Review Request 35312: Minor cleanup to master/slave metric logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35312/#review87461 --- Ship it! Ship It! - Vinod Kone On June 10, 2015, 7:50 p.m., Ben

Re: Review Request 35309: Added Resources::get() and Resources::names().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35309/#review87460 --- Ship it! Ship It! - Jie Yu On June 10, 2015, 7:08 p.m., Vinod Ko

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

> On June 9, 2015, 6:11 p.m., Vinod Kone wrote: > > src/tests/fetcher_cache_tests.cpp, lines 201-207 > > > > > > While this looks good as a temporary fix, what is the long term > > strategy here? > > > > I re

Re: Review Request 35321: Implemented the fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35321/#review87454 --- Patch looks great! Reviews applied: [35259, 35260, 35264, 35305, 35

Re: Review Request 35291: Fixed some typos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35291/#review87453 --- Ship it! Thank you! - Vinod Kone On June 10, 2015, 10:20 a.m., A

Re: Review Request 35270: make a bunch of JSONP callback URLs in mesos UI protocol-relative

> On June 9, 2015, 11:49 p.m., Vinod Kone wrote: > > Ship It! > > Oliver Nicholas wrote: > hey Vinod I know these are two separate systems but would it be possible > for you to get me approved as a committer in Jira so I can actually claim the > underlying task? my username there is "bigo"

Re: Review Request 35270: make a bunch of JSONP callback URLs in mesos UI protocol-relative

> On June 9, 2015, 11:49 p.m., Vinod Kone wrote: > > Ship It! hey Vinod I know these are two separate systems but would it be possible for you to get me approved as a committer in Jira so I can actually claim the underlying task? my username there is "bigo" - Oliver ---

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review87446 --- Patch looks great! Reviews applied: [35309, 34910, 34911] All test

Review Request 35312: Minor cleanup to master/slave metric logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35312/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Review Request 35313: Added slave metrics for revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35313/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-2775 https://issues.

Review Request 35320: Fixed a bug in the fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35320/ --- Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. Bugs: MES

Review Request 35321: Implemented the fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35321/ --- Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. Bugs: MES

Re: Review Request 35305: Added a SlaveTest to caputure the case when containerizer usage fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35305/#review87443 --- Patch looks great! Reviews applied: [35259, 35260, 35264, 35305] A

Re: Review Request 34910: Added task validation for task using revocable resources while its executor does not.

> On June 3, 2015, 6:08 p.m., Ben Mahler wrote: > > Can we make the test a unit test? Looks like we could pull up > > '`validateResources`' to make this unit-testable? Chatting with Jie, we > > should probably place it in an `'internal::task'` namespace towards the > > bottom of the header, si

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/ --- (Updated June 10, 2015, 7:11 p.m.) Review request for mesos, Ben Mahler, Ian Do

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

> On June 3, 2015, 8:33 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, line 185 > > > > > > Do you only want to start the executor on oversubscribed resources or > > split it between task and ex

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

> On June 3, 2015, 6:34 p.m., Ben Mahler wrote: > > Ditto, can we roll it in to a unit test of '`validateResources`'? I really want to have an end to end test to make sure that the wiring is all correct. - Vinod --- This is an automati

Re: Review Request 34910: Added task validation for task using revocable resources while its executor does not.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34910/ --- (Updated June 10, 2015, 7:10 p.m.) Review request for mesos, Ben Mahler, Ian Do

Review Request 35309: Added Resources::get() and Resources::names().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35309/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-2753 https://i

Re: Review Request 30952: Adding scheduler validations to master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30952/#review87438 --- Ship it! Ship It! - Vinod Kone On June 10, 2015, 12:08 a.m., Isa

Re: Review Request 35259: Removed unused constaints from ResourceMonitor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35259/#review87439 --- Ship it! Ship It! - Vinod Kone On June 9, 2015, 7:50 p.m., Jie Y

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

> On June 9, 2015, 10:04 p.m., Niklas Nielsen wrote: > > src/tests/monitor_tests.cpp, lines 204-206 > > > > > > This doesn't test the same thing anymore? Shouldn't this be moved to a > > slave test instead of getting

Review Request 35305: Added a SlaveTest to caputure the case when containerizer usage fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35305/ --- Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. Bugs: MES

Re: Review Request 35264: Added a slave integration test in MonitorTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/ --- (Updated June 10, 2015, 6:30 p.m.) Review request for mesos, Ben Mahler, Niklas

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/ --- (Updated June 10, 2015, 6:29 p.m.) Review request for mesos, Ben Mahler, Niklas

Re: Review Request 35281: Added QoS module loader to ::create() factory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35281/#review87421 --- Ship it! src/slave/qos_controller.cpp

Re: Review Request 35280: Added Test QoS Controller module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35280/#review87405 --- src/examples/test_qos_controller_module.cpp

Re: Review Request 35279: Added QoS Controller module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35279/#review87402 --- Ship it! Ship It! - Bartek Plotka On June 10, 2015, 1:09 a.m., N

Re: Review Request 35278: Added missing flag initialization for qos controller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35278/#review87401 --- Ship it! src/slave/flags.cpp

Re: Review Request 35291: Fixed some typos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35291/#review87386 --- Patch looks great! Reviews applied: [35291] All tests passed. - M

Review Request 35291: Fixed some typos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35291/ --- Review request for mesos and Niklas Nielsen. Bugs: MESOS-2835 https://issue

Re: Review Request 35285: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (mesos)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/ --- (Updated June 10, 2015, 8:13 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 35286: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (libprocess)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35286/ --- (Updated June 10, 2015, 8:12 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

> On June 5, 2015, 6:42 p.m., Vinod Kone wrote: > > I made some minor comments below but I think a better way to do this is to > > *not* write custom masterinfo json <-> protobuf converters. I prefer we > > just add a new optional field (say ipAddress of type string). Then you can > > just lev

Re: Review Request 35287: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (stout)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/ --- (Updated June 10, 2015, 8:11 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 35287: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (stout)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/ --- (Updated June 10, 2015, 8:10 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 35286: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (libprocess)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35286/ --- (Updated June 10, 2015, 8:09 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 35285: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (mesos)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/ --- (Updated June 10, 2015, 8:10 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 35285: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (mesos)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/ --- (Updated June 10, 2015, 8:08 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 35286: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (libprocess)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35286/ --- (Updated June 10, 2015, 8:07 a.m.) Review request for mesos and Joris Van Remoo

Review Request 35287: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (stout)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/ --- Review request for mesos. Repository: mesos Description --- Rename Optio

Review Request 35285: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (mesos)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/ --- Review request for mesos. Repository: mesos Description --- Rename Optio

Review Request 35286: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (libprocess)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35286/ --- Review request for mesos. Repository: mesos Description --- Rename Optio