Review Request 35711: Disallow special characters in role name.

2015-06-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- Review request for mesos, Adam B and Jie Yu. Repository: mesos Description

Re: Review Request 35717: Add reservations support to master's state.json

2015-06-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/ --- (Updated June 21, 2015, 6:02 p.m.) Review request for mesos and Adam B.

Re: Review Request 35711: Disallow special characters in role name.

2015-06-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 21, 2015, 2:15 p.m.) Review request for mesos, Adam B and Jie

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-06-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review88697 --- Patch looks great! Reviews applied: [9] All tests passed. -

Review Request 35715: Added revocable resource state validation.

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35715/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Repository: mesos

Re: Review Request 35717: Add reservations support to master's state.json

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/#review88703 --- Thanks for doing this! Looks good to me overall.

Re: Review Request 34881: let libprocess to compile on arm64 servers

2015-06-21 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34881/#review88722 --- 3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch (line 18)

Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.

2015-06-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35714/#review88727 --- Ship it! Out of order, but otherwise good. Fix, then ShipIt!

Re: Review Request 35721: Set the owner of persistent volumes to frameworkInfo.user .

2015-06-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/#review88717 --- Patch looks great! Reviews applied: [35721] All tests passed. -

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 22, 2015, 2:35 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35714/ --- (Updated June 22, 2015, 5:06 a.m.) Review request for mesos, Adam B and Jie

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 22, 2015, 5:29 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 34427: AppC provisioner backend using bind mounts.

2015-06-21 Thread Ian Downes
On May 21, 2015, 12:29 p.m., Timothy Chen wrote: src/slave/containerizer/provisioners/appc/bind_backend.hpp, line 60 https://reviews.apache.org/r/34427/diff/1/?file=964174#file964174line60 I think we typcically add namespaces in cpp files to avoid process:: and std:: everywhere,

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 22, 2015, 5:11 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35717: Add reservations support to master's state.json

2015-06-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/ --- (Updated June 21, 2015, 6:04 p.m.) Review request for mesos and Adam B.

Re: Review Request 35717: Add reservations support to master's state.json

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/#review88707 --- Ship it! src/master/http.cpp (line 234)

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-06-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review88691 --- Patch looks great! Reviews applied: [9] All tests passed. -

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-06-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 21, 2015, 9:42 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-06-21 Thread haosdent huang
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: src/examples/java/TestPersistentVolumeFramework.java, lines 529-542 https://reviews.apache.org/r/9/diff/10/?file=941652#file941652line529 Please consider using Apache Commons CLI instead: