> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > src/examples/java/TestPersistentVolumeFramework.java, lines 529-542 > > <https://reviews.apache.org/r/33339/diff/10/?file=941652#file941652line529> > > > > Please consider using Apache Commons CLI instead: > > https://commons.apache.org/proper/commons-cli/ > > haosdent huang wrote: > Yes, but it would add a new dependence to Maven. Is it acceptable? Other > exist java examples also simple handle the args. > > Marco Massenzio wrote: > I am not sure what the "official policy" is here - but this is a widely > used library (and not a major dependency either) so I think we should be fine > with it. > Anyone got any opinion on this? > > Adam B wrote: > Anything from Apache Commons Proper should be fine. We're all Apache here.
@marco, @adam-mesos . I still don't like add log4j or commons-cli to this simple examples, because * Add external dependences to example may let user hard to run. Dependences may also conflict with user exist dependences. * If we want to add external jar dependences, we need add a pom.xml or a gradle file. Currently our java examples even don't have packages. Change a example to maven project maybe affect more code. If we decide to change examples to a maven project or gradle project, I need should open a new review to change them. So I just a Flags java implementation to handle command line options in this patch, I think it should be more readable now. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33339/#review86113 ----------------------------------------------------------- On June 21, 2015, 9:42 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33339/ > ----------------------------------------------------------- > > (Updated June 21, 2015, 9:42 a.m.) > > > Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. > > > Bugs: MESOS-2610 > https://issues.apache.org/jira/browse/MESOS-2610 > > > Repository: mesos > > > Description > ------- > > Add a Java example framework to test persistent volumes. > > > Diffs > ----- > > configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 > src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 > src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION > src/examples/java/test-persistent-volume-framework.in PRE-CREATION > src/tests/examples_tests.cpp 2ff6e7a449cc5037f9a3c8d6938855c35e389cca > src/tests/java_persistent_volume_framework_test.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/33339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >
