Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 2, 2015, 11:32 p.m., Ben Mahler wrote: > > src/linux/cgroups.cpp, lines 2014-2027 > > > > > > Any reason you're not just re-using cgroups::stat here? I'd suggest > > just calling cgroups::stat for now, shou

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 2, 2015, 11:32 p.m., Ben Mahler wrote: > > src/linux/cgroups.cpp, lines 2014-2027 > > > > > > Any reason you're not just re-using cgroups::stat here? I'd suggest > > just calling cgroups::stat for now, shou

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 2, 2015, 11:32 p.m., Ben Mahler wrote: > > src/linux/cgroups.hpp, lines 443-472 > > > > > > Thanks! > > > > (1) Do you mind updating my TODO on cgroups::stat() to reflect that > > cpuacct::stat is i

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90302 --- I chatted with Isabel on IRC and asked her to break apart this chang

Re: Review Request 36152: Updated CHANGELOG for 0.23.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36152/#review90298 --- Ship it! Adam, super-thanks for pulling this together - this was fa

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

> On July 1, 2015, 11:41 p.m., Paul Brett wrote: > > src/tests/perf_tests.cpp, line 93 > > > > > > ASSERT_SOME_TRUE would need parse to be Try for it to compile. - Chi --

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

> On July 2, 2015, 12:29 a.m., Ian Downes wrote: > > src/tests/perf_tests.cpp, line 87 > > > > > > ```cpp > > foreach (const tuple& input, input1) {} > > ```? foreach doesn't work with tuple for me. I used the

Re: Review Request 36152: Updated CHANGELOG for 0.23.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36152/ --- (Updated July 2, 2015, 4:47 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/#review90294 --- src/linux/perf.cpp (line 496)

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/ --- (Updated July 2, 2015, 11:42 p.m.) Review request for mesos, Ian Downes, Paul B

Review Request 36151: stout: relaxed Version to allow default and copy constructors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36151/ --- Review request for mesos, Ian Downes, Paul Brett, and Cong Wang. Bugs: mesos-28

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/ --- (Updated July 2, 2015, 11:40 p.m.) Review request for mesos, Ian Downes, Paul B

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

> On July 2, 2015, 12:28 a.m., Ian Downes wrote: > > src/linux/perf.cpp, line 473 > > > > > > Is there some way to have different extract functions without coding a > > single, specific kernel version in the name, e.g

Review Request 36152: Updated CHANGELOG for 0.23.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36152/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Jie Yu,

Re: Review Request 36048: Updated authorizer to allow for modularize implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 3, 2015, 1:36 a.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

> On July 2, 2015, 12:52 a.m., Paul Brett wrote: > > src/linux/perf.cpp, line 473 > > > > > > How about extract_post_linux_2_6_39 for the name? I wanted it that too, but functions names need to be lowerCamerl per styl

Re: Review Request 36049: Added support for modularized Authorizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated July 3, 2015, 1:34 a.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36112: perf: extracted out a 'version' function.

> On July 1, 2015, 11:19 p.m., Paul Brett wrote: > > src/linux/perf.cpp, line 456 > > > > > > Not your code but we should propagate the failure to the caller so that > > sample can fail rather than halt and catch fire

Re: Review Request 36048: Updated authorizer to allow for modularize implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 3, 2015, 1:33 a.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36113: perf: refactored parse to allow determining an output parsing function based on the runtime version.

> On July 1, 2015, 11:31 p.m., Paul Brett wrote: > > src/linux/perf.cpp, line 468 > > > > > > Could you replace the function pointer with a lambda? changed to not use a function pointer. - Chi

Re: Review Request 36113: perf: refactored parse to allow determining an output parsing function based on the runtime version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36113/ --- (Updated July 2, 2015, 11:32 p.m.) Review request for mesos, Ian Downes, Paul B

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90288 --- Are you planning to also update cpushare.cpp? src/linux/cgroups.hp

Re: Review Request 36050: Added test authorizer module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated July 3, 2015, 1:18 a.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36040: Change Server closing connections for every request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36040/ --- (Updated July 2, 2015, 10:32 p.m.) Review request for mesos, Anand Mazumdar, Ma

Re: Review Request 36040: Change Server closing connections for every request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36040/ --- (Updated July 2, 2015, 10:32 p.m.) Review request for mesos, Anand Mazumdar, Ma

Re: Review Request 36145: Update Upgrade Guide for Mesos 0.23.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36145/ --- (Updated July 2, 2015, 2:44 p.m.) Review request for mesos, Benjamin Hindman, B

Review Request 36145: Update Upgrade Guide for Mesos 0.23.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36145/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Jie Yu,

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/linux/cgroups.cpp, line 2014 > > > > > > I don't think we usually define a inline function like this anywhere > > else, so curious to see what others think. >

Re: Review Request 36040: Change Server closing connections for every request

> On June 30, 2015, 4:24 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/src/http.cpp, line 777 > > > > > > What is this change intending to solve ? If it's the ability to not > > close the connection for streamed

Re: Review Request 36040: Change Server closing connections for every request

> On June 30, 2015, 4:24 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/src/http.cpp, line 777 > > > > > > What is this change intending to solve ? If it's the ability to not > > close the connection for streamed

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90268 --- Ship it! I'm not entirely sure the Doxygen comments fully comply wi

Re: Review Request 36072: New "Unsupported" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36072/#review90266 --- Ship it! Ship It! - Ben Mahler On July 2, 2015, 2:05 a.m., Isabe

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

> On July 2, 2015, 1:35 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/firewall.hpp, line 59 > > > > > > Hm.. why is this an Owned as opposed to just an > > http::Response? Is there something subtle go

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/ --- (Updated July 2, 2015, 6:01 p.m.) Review request for mesos, Ian Downes, Joris V

Re: Review Request 36128: Change docker version parsing

> On July 2, 2015, 5:47 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 189 > > > > > > It's a bit harder to understand how this works. > > > > Looks like the new output is: > > Client: > >

Re: Review Request 36128: Change docker version parsing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36128/#review90257 --- Ship it! Ship It! - Timothy Chen On July 2, 2015, 8:58 a.m., Isa

Re: Review Request 36128: Change docker version parsing

> On July 2, 2015, 5:47 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 189 > > > > > > It's a bit harder to understand how this works. > > > > Looks like the new output is: > > Client: > >

Re: Review Request 34142: AppC provisioner.

> On July 2, 2015, 8:48 a.m., Timothy Chen wrote: > > include/mesos/mesos.proto, line 1300 > > > > > > I believe we discussed this, but different acVersion will most likely > > have different schema. > > > >

Re: Review Request 36128: Change docker version parsing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36128/#review90254 --- src/docker/docker.cpp (line 189)

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/#review90246 --- we can't do this. see my comments in the other review. - Vinod Kone

Re: Review Request 36125: Removing '.json' extension in master endpoints url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/#review90245 --- We cannot just rename the endpoints. That's a breaking API change!!

Re: Review Request 36071: Add flow diagram for docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36071/#review90242 --- This diagram does seem to be missing some essential flow-diagram-ele

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/#review90235 --- A high level question: do operators have the possibility to get a li

Re: Review Request 32384: Adding perf check to configure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32384/#review90210 --- Ship it! Ship It! configure.ac (line 1121)

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

> On June 30, 2015, 3:37 a.m., Adam B wrote: > > src/master/http.cpp, line 424 > > > > > > Is there a way you could reuse all or part of Http::redirect()? Seems > > like a lot of copy/paste. I add a condition in redi

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated July 2, 2015, 11:24 a.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated July 2, 2015, 11:22 a.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 36050: Added test authorizer module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated July 2, 2015, 12:28 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36049: Added support for modularized Authorizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated July 2, 2015, 12:25 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36050: Added test authorizer module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated July 2, 2015, 12:16 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36048: Update authorizer to allow for modularize implementations

> On July 1, 2015, 8:50 p.m., Kapil Arya wrote: > > src/tests/authorization_tests.cpp, line 46 > > > > > > May be I am missing something here, but why not use Owned ptr? I think raw pointers are used for modules, but I

Re: Review Request 36048: Update authorizer to allow for modularize implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 2, 2015, 12:14 p.m.) Review request for mesos and Till Toenshoff.

Review Request 36128: Change docker version parsing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36128/ --- Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-2986

Re: Review Request 34142: AppC provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34142/#review90204 --- include/mesos/mesos.proto (line 1300)

Re: Review Request 34427: AppC provisioner backend using bind mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34427/#review90202 --- Ship it! Ship It! src/slave/containerizer/provisioners/appc/bind_

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 2, 2015, 8:16 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 32384: Adding perf check to configure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32384/ --- (Updated July 2, 2015, 8:09 a.m.) Review request for mesos and Cody Maloney.

Review Request 36127: Removing '.json' extension in files endpoints url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod

Review Request 36126: Removing '.json' extension in slave endpoints url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

> On July 2, 2015, 3:35 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/firewall.hpp, line 59 > > > > > > Hm.. why is this an Owned as opposed to just an > > http::Response? Is there something subtle go

Review Request 36125: Removing '.json' extension in master endpoints url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 2, 2015, 7:35 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 2, 2015, 7:34 a.m.) Review request for mesos, Anand Mazumdar, Ben