Review Request 37921: Add Copy backend for provisioners.

2015-08-29 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37921/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Repository: mesos

Re: Review Request 37921: Add Copy backend for provisioners.

2015-08-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37921/#review96982 --- Patch looks great! Reviews applied: [37921] All tests passed. -

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-29 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96980 --- Ship it! Ship It! - Timothy Chen On Aug. 22, 2015, 5:04 p.m.,

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-29 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96981 --- Ship it! Ship It! src/docker/docker.hpp (line 45)

Re: Review Request 37814: Added documentation for libprocess environment variables

2015-08-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/#review96987 --- Ship it! Ship It! - haosdent huang On Aug. 28, 2015, 10:25

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Aug. 29, 2015, 12:22 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96990 --- Patch looks great! Reviews applied: [37669] All tests passed. -

Re: Review Request 37703: Add docker exec command.

2015-08-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/ --- (Updated Aug. 29, 2015, 1:51 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Aug. 29, 2015, 12:02 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 37881: Implemented AppcProvisioner.

2015-08-29 Thread Jiang Yan Xu
On Aug. 28, 2015, 12:59 p.m., Jie Yu wrote: src/slave/containerizer/provisioner.cpp, lines 43-46 https://reviews.apache.org/r/37881/diff/1/?file=1057720#file1057720line43 I would love to get this TODO solved in this patch. It should be pretty straightfoward, right? Just hard code

Re: Review Request 37881: Implemented AppcProvisioner.

2015-08-29 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37881/ --- (Updated Aug. 29, 2015, 9:28 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 37880: Changed the Appc provisioner directory to identify a rootfs by a rootfs_id (UUID).

2015-08-29 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37880/ --- (Updated Aug. 29, 2015, 9:26 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-08-29 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37929/ --- (Updated Aug. 29, 2015, 9:25 p.m.) Review request for mesos, Jie Yu and

Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-08-29 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37929/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-29 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review97005 --- Can you rebase on latest master? I can't apply this patch. -

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-29 Thread Timothy Chen
On Aug. 30, 2015, 1:47 a.m., Ben Mahler wrote: Is 1.7.0.fc22 legal semver? From what I can tell looking at http://semver.org/, it is not legal? (1) Could we also follow up with the docker folks to use legal semver versioning? (2) It would be nice if we could push the logic of the