Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100744 --- This doesn't compiler for me on Ubuntu 15.04 I will work with you o

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38754/#review100743 --- Ship it! 3rdparty/CMakeLists.txt (lines 37 - 39)

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38753/#review100745 --- Ship it! - Joris Van Remoortere On Sept. 26, 2015, 6 a.m., Alex

Re: Review Request 38752: CMake: Update MesosConfigure to use new process configure scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38752/#review100742 --- Ship it! - Joris Van Remoortere On Sept. 25, 2015, 10:12 p.m., A

Re: Review Request 38551: [1/2]CMake: Add version info for APR we need to build Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38551/#review100739 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 6:30 p.m., Al

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38751/#review100741 --- Ship it! 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake

Re: Review Request 38549: [1/2]CMake: Add libevent version, configure Windows to use as default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38549/#review100735 --- Ship it! This is a big decision because on linux right now the def

Re: Review Request 38552: [2/2]CMake: Add Windows-specific build targets for APR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38552/#review100740 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 11:21 a.m., A

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/#review100738 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 10:43 a.m., A

Re: Review Request 38542: CMake: Use version info from `Versions.cmake` instead of magic strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38542/#review100733 --- Ship it! This is great Alex! - Joris Van Remoortere On Sept. 21

Re: Review Request 38541: CMake: Add `Versions.cmake` as an analog to `versions.am`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38541/#review100732 --- Ship it! - Joris Van Remoortere On Sept. 25, 2015, 10:09 p.m., A

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/#review100729 --- Ship it! hausdorff will follow up with a JIRA for preventing 32 bi

Re: Review Request 38540: [VIA HAOSDENT] [2/2]Generate make batch file to build project in windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38540/#review100731 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 2:41 a.m., Al

Re: Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to common definitions file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38538/#review100726 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 2:33 a.m., Al

Re: Review Request 38531: CMake: Update CMake config to build Mesos against picojson v1.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38531/#review100725 --- Ship it! - Joris Van Remoortere On Sept. 20, 2015, 2:07 a.m., Al

Re: Review Request 38530: CMake: Add preprocessor definitions required to build picojson 1.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38530/#review100724 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 6:06 p.m., Al

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review100721 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 2:43 a.m., Al

Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38529/#review100722 --- Ship it! - Joris Van Remoortere On Sept. 20, 2015, 2:07 a.m., Al

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38753/ --- (Updated Sept. 26, 2015, 6 a.m.) Review request for mesos, Artem Harutyunyan, J

Re: Review Request 37531: MESOS-3070 (Master CHECK failure if a framework uses duplicated task id)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/#review100737 --- Patch looks great! Reviews applied: [37531] All tests passed. -

Re: Review Request 37531: MESOS-3070 (Master CHECK failure if a framework uses duplicated task id)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/ --- (Updated Sept. 26, 2015, 2:52 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 38549: [1/2]CMake: Add libevent version, configure Windows to use as default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38549/#review100736 --- CMakeLists.txt (line 37)

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

> On Sept. 25, 2015, 2:36 p.m., Artem Harutyunyan wrote: > > src/CMakeLists.txt, line 1 > > > > > > I think this file belongs in src/slave. And from top level src/ dir we > > should just be pulling CMakeLists.txt file

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 25, 2015, 9:46 a.m., Artem Harutyunyan wrote: > > > > haosdent huang wrote: > I don't think so. And Makefile.am also not follow the 80 characters limit. I'd rather have the Makefile.am fixed too. - Artem --- This is an a

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100728 --- Patch looks great! Reviews applied: [38456, 38457, 38529, 38530, 3

Re: Review Request 37540: Add perf event API

> On Sept. 25, 2015, 9:53 p.m., Vinod Kone wrote: > > src/linux/perf.hpp, line 110 > > > > > > put the braces on the same line. more importantly, do you actually need > > a default constructor? > > > > also

Re: Review Request 38779: Use new HTTP status code check in scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38779/#review100720 --- Patch looks great! Reviews applied: [38416, 38779] All tests pass

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100719 --- Ship it! Also tested on OSX. i.e. ``` mkdir cbuild cd cbuild cmak

Re: Review Request 38780: io: fixed a file descriptor leak in peek()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38780/#review100718 --- Ship it! Ship It! - Ben Mahler On Sept. 25, 2015, 10:57 p.m., C

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

> On Sept. 25, 2015, 11:16 p.m., Joseph Wu wrote: > > For me, `mkdir build && cd build && cmake .. && make`. > > > > Gave me an error (OSX): > > > > ``` > > Scanning dependencies of target mesos-0.25.0 > > /Applications/Xcode.app/Contents/Developer/usr/bin/make -f > > src/CMakeFiles/mesos-0.25

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/ --- (Updated Sept. 25, 2015, 11:19 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100714 --- For me, `mkdir build && cd build && cmake .. && make`. Gave me an

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Sept. 25, 2015, 11:14 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38774: state: fix file descriptor leak

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38774/#review100713 --- src/slave/state.cpp (lines 666 - 680)

Review Request 38780: io: fixed a file descriptor leak in peek()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38780/ --- Review request for mesos. Bugs: mesos-3519 https://issues.apache.org/jira/b

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review100711 --- 3rdparty/libprocess/include/process/http.hpp (lines 58 - 59)

Re: Review Request 38577: Added synchronous validation for Call in Agent

> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(s). We don't have cmake support for the

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

> On Sept. 25, 2015, 9:36 p.m., Artem Harutyunyan wrote: > > src/CMakeLists.txt, line 1 > > > > > > I think this file belongs in src/slave. And from top level src/ dir we > > should just be pulling CMakeLists.txt file

Re: Review Request 38779: Use new HTTP status code check in scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38779/#review100708 --- Ship it! Ship It! - Isabel Jimenez On Sept. 25, 2015, 10:40 p.m

Review Request 38779: Use new HTTP status code check in scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38779/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Repository: mesos De

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/ --- (Updated Sept. 25, 2015, 10:38 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38776: Removed unnecessary close calls on ifstream and ofstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38776/#review100707 --- Patch looks great! Reviews applied: [38775, 38776] All tests pass

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

> On Sept. 25, 2015, 5:39 p.m., Joseph Wu wrote: > > src/CMakeLists.txt, lines 34-38 > > > > > > This seems macro-able. > > > > A macro which would let you do something like: > > ``` > > BUILD_PROTO(M

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

> On Sept. 25, 2015, 5:48 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [38416] > > > > Failed command: ./support/apply-review.sh -n -r 38416 > > > > Error: > > 2015-09-25 17:48:15 URL:https://reviews.apache.org/r/38416/diff/raw/ > > [27994/27994] -> "38416.patch" [1]

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

> On Sept. 25, 2015, 7:06 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540, > > 38541, 38542, 38549, 38550, 38551, 38552, 38751, 38752] > > > > Failed command: ./support/apply-review.sh -n -r 38752 > > > > Error: > >

Re: Review Request 38752: CMake: Update MesosConfigure to use new process configure scripts.

> On Sept. 25, 2015, 8:29 p.m., Joris Van Remoortere wrote: > > You'll need to split this up as it's touching 2 different projects: > > ``` > > ERROR: Commit spanning multiple projects. > > > > Please use separate commits for mesos, libprocess and stout. > > > > Paths grouped by project: > > me

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

> On Sept. 25, 2015, 5:03 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 61 > > > > > > 80+ characters? > > Alex Clemmer wrote: > Per conversation with Joris, I think we'll p

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

> On Sept. 23, 2015, 4:58 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/src/http.cpp, line 77 > > > > > > Why not implement a `stringify(...)` for the newly created enum and > > make the `statuses[]` use it ? T

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

> On Sept. 25, 2015, 5:49 p.m., Artem Harutyunyan wrote: > > 3rdparty/CMakeLists.txt, line 37 > > > > > > 80+ characters. We decided that the precedent was to keep it on one line even though it looks way better brok

Re: Review Request 38775: Removed unnecessary close calls on ifstream and ofstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38775/#review100698 --- Ship it! Ship It! - Jie Yu On Sept. 25, 2015, 9:56 p.m., Ben Ma

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

> On Sept. 25, 2015, 6:05 p.m., Artem Harutyunyan wrote: > > cmake/CompilationConfigure.cmake, line 84 > > > > > > NOLINT? Doesn't complain on my box, I don't think it's necessary. Also, this _does_ run when you com

Re: Review Request 38777: Avoid closing '-1' file descriptors in Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38777/#review100697 --- Ship it! Ship It! - Jie Yu On Sept. 25, 2015, 10:14 p.m., Ben M

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38754/ --- (Updated Sept. 25, 2015, 10:22 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/ --- (Updated Sept. 25, 2015, 10:14 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38755/ --- (Updated Sept. 25, 2015, 10:13 p.m.) Review request for mesos, Artem Harutyunya

Review Request 38777: Avoid closing '-1' file descriptors in Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38777/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- c

Re: Review Request 38752: CMake: Update MesosConfigure to use new process configure scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38752/ --- (Updated Sept. 25, 2015, 10:12 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38751/ --- (Updated Sept. 25, 2015, 10:11 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38541: CMake: Add `Versions.cmake` as an analog to `versions.am`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38541/ --- (Updated Sept. 25, 2015, 10:09 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 25, 2015, 4:46 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 242 > > > > > > This surpasses 80 character limit, is there a way to fix it here and > > elsewhere in th

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/ --- (Updated Sept. 25, 2015, 10:08 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 38776: Removed unnecessary close calls on ifstream and ofstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38776/#review100694 --- Ship it! Ship It! - Jie Yu On Sept. 25, 2015, 9:56 p.m., Ben Ma

Review Request 38775: Removed unnecessary close calls on ifstream and ofstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38775/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- s

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/#review100693 --- Hi James, thank you for creating this benchmark! I will work with y

Review Request 38776: Removed unnecessary close calls on ifstream and ofstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38776/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- s

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review100656 --- src/linux/perf.hpp (line 96)

Re: Review Request 38774: state: fix file descriptor leak

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38774/#review100690 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

> On Sept. 25, 2015, 2:36 p.m., Artem Harutyunyan wrote: > > LGTM. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100641

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100641 --- src/CMakeLists.txt (line 1)

Re: Review Request 38774: state: fix file descriptor leak

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38774/#review100688 --- src/slave/state.cpp (line 656)

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100686 --- Patch looks great! Reviews applied: [38443, 38579, 38580, 38747]

Re: Review Request 38577: Added synchronous validation for Call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review100682 --- src/slave/validation.cpp (line 52)

Re: Review Request 38774: state: fix file descriptor leak

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38774/ --- (Updated Sept. 25, 2015, 9 p.m.) Review request for mesos. Bugs: mesos-3519

Review Request 38774: state: fix file descriptor leak

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38774/ --- Review request for mesos. Bugs: mesos-3519 https://issues.apache.org/jira/b

Re: Review Request 38743: files: fix potential fd leaks under error conditions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38743/ --- (Updated Sept. 25, 2015, 8:34 p.m.) Review request for mesos. Bugs: MESOS-351

Re: Review Request 38770: routing: fixed a file descriptor leak.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38770/ --- (Updated Sept. 25, 2015, 8:33 p.m.) Review request for mesos, Ben Mahler, Jie Y

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 25, 2015, 8:33 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Sept. 25, 2015, 8:32 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38752: CMake: Transition Mesos to use new third-party build scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38752/#review100676 --- You'll need to split this up as it's touching 2 different projects:

Re: Review Request 38770: routing: fixed a file descriptor leak.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38770/#review100675 --- Patch looks great! Reviews applied: [38770] All tests passed. -

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/#review100671 --- Ship it! Ship It! - Joseph Wu On Sept. 24, 2015, 2:29 p.m., Nei

Re: Review Request 38770: routing: fixed a file descriptor leak.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38770/#review100670 --- Ship it! Thanks! Would you mind tracking these under a ticket to c

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

> On Sept. 25, 2015, 10:39 a.m., Joseph Wu wrote: > > src/CMakeLists.txt, lines 34-38 > > > > > > This seems macro-able. > > > > A macro which would let you do something like: > > ``` > > BUILD_PROTO(

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review100628 --- Per AlexR, I'll review as a native speaker. General note: There ar

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

> On Sept. 25, 2015, 5:39 p.m., Joseph Wu wrote: > > src/CMakeLists.txt, lines 34-38 > > > > > > This seems macro-able. > > > > A macro which would let you do something like: > > ``` > > BUILD_PROTO(M

Re: Review Request 38770: routing: fixed a file descriptor leak.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38770/#review100661 --- Ship it! Or you can do unconditionally os::close() after that ioct

Re: Review Request 38770: routing: fixed a file descriptor leak.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38770/ --- (Updated Sept. 25, 2015, 7:07 p.m.) Review request for mesos, Ben Mahler, Jie Y

Re: Review Request 38618: Changed executor HTTP API tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38618/#review100658 --- Ship it! Ship It! - Vinod Kone On Sept. 25, 2015, 6:57 p.m., Is

Review Request 38770: routing: fixed a file descriptor leak.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38770/ --- Review request for mesos, Ben Mahler, Jie Yu, and Cong Wang. Repository: mesos

Re: Review Request 38577: Added synchronous validation for Call in Agent

> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/slave/validation.hpp, line 36 > > > > > > Can you please add tests in this patch? Adding tests in a separate dependant patch. - Isabel ---

Re: Review Request 38618: Changed executor HTTP API tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38618/ --- (Updated Sept. 25, 2015, 6:57 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 38577: Added synchronous validation for Call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review100653 --- src/Makefile.am (line 501)

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review100652 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 38619: Added missing header guards for master/validation.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38619/#review100651 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 9:57 a.m., Is

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

> On Sept. 25, 2015, 4:58 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake, lines > > 109-126 > > > > > > Just to clarify. You're getting rid of this because of haosdent

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Sept. 25, 2015, 6:34 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38443: Added layerid information to ManifestResponse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/ --- (Updated Sept. 25, 2015, 6:33 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38579: Exposing manifest structure outside RegistryClient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Sept. 25, 2015, 6:34 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 25, 2015, 6:33 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

> On Sept. 25, 2015, 6:18 p.m., Timothy Chen wrote: > > Can you add a test for this logic? Could, but because volume-driver depends on flocker, my test ideas for this is verify the docker run command is correct. - haosdent --- This is

  1   2   >