Re: Review Request 37853: Overlay filesystem provisioning backend

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 6, 2015, 6:36 a.m.) Review request for mesos, Ben Mahler, Chi Zha

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101615 --- src/slave/slave.cpp (line 2420)

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101614 --- src/slave/slave.cpp (line 2479)

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review101613 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review101589 --- include/mesos/resources.hpp (line 73)

Re: Review Request 39037: Allow description empty in help information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review101603 --- Ship it! Ship It! - Guangya Liu On 十月 6, 2015, 4:15 a.m., haosd

Re: Review Request 37023: Add an endpoint that exposes component flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/#review101604 --- Ship it! Ship It! - Guangya Liu On 十月 6, 2015, 4:15 a.m., haosd

Re: Review Request 38919: Validation of Docker Image Manifests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review101600 --- Patch looks great! Reviews applied: [38901, 38919] All tests pass

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review101595 --- Patch looks great! Reviews applied: [39019] All tests passed. -

Re: Review Request 37023: Add an endpoint that exposes component flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/ --- (Updated Oct. 6, 2015, 4:15 a.m.) Review request for mesos and Ben Mahler. Ch

Review Request 39037: Allow description empty in help information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3104 https://issues.ap

Re: Review Request 37023: Add an endpoint that exposes component flags.

> On Oct. 6, 2015, 3:43 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 131 > > > > > > Does DESCRIPTION still needed since it is empty now. > > haosdent huang wrote: > So far we still need it except we

Re: Review Request 37023: Add an endpoint that exposes component flags.

> On Oct. 6, 2015, 3:43 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 131 > > > > > > Does DESCRIPTION still needed since it is empty now. So far we still need it except we add ``` string HELP( strin

Re: Review Request 37023: Add an endpoint that exposes component flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/#review101592 --- src/master/master.cpp (line 131)

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/#review101591 --- src/tests/containerizer/port_mapping_tests.cpp (line 270)

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review101590 --- Patch looks great! Reviews applied: [39018] All tests passed. -

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/ --- (Updated Oct. 6, 2015, 3:13 a.m.) Review request for mesos, Adam B, Ian Downes,

Re: Review Request 38899: Added handler for Executor->Framework message for the Executor HTTP API

> On Oct. 4, 2015, 7:30 a.m., Guangya Liu wrote: > > src/slave/http.cpp, line 316 > > > > > > I think that the blank line is not needed. It's always considered good practice to have a newline after a multiline cont

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

> On Oct. 5, 2015, 11:57 p.m., Isabel Jimenez wrote: > > src/slave/http.cpp, line 310 > > > > > > Could you please change the syntax for every case to be consistent with > > `: {` through this switch? > > Guangya L

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

> On Sept. 30, 2015, 5 a.m., Guangya Liu wrote: > > src/slave/http.cpp, line 304 > > > > > > Can you please add some comments for when this if condition will be > > hit? I see that the scheduler API is not handling

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/#review101585 --- BTW, can you update https://issues.apache.org/jira/browse/MESOS-352

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

> On Oct. 6, 2015, 12:01 a.m., Cong Wang wrote: > > Or simply use 'tee -a' instead? Since it should not append anything to that > > file when nc receives nothing. > > haosdent huang wrote: > tee -a aslo OK, but seems use different files would more clear? I have no preference on either. BTW

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

> On Oct. 6, 2015, 12:01 a.m., Cong Wang wrote: > > Or simply use 'tee -a' instead? Since it should not append anything to that > > file when nc receives nothing. tee -a aslo OK, but seems use different files would more clear? - haosdent -

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

> On 十月 5, 2015, 11:57 p.m., Isabel Jimenez wrote: > > src/slave/http.cpp, line 310 > > > > > > Could you please change the syntax for every case to be consistent with > > `: {` through this switch? Does the "{" ne

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 6, 2015, 2:33 a.m.) Review request for mesos, Ben Mahler and Timo

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 6, 2015, 2:32 a.m.) Review request for mesos, Ben Mahler and Timo

Re: Review Request 38443: Added layerid information to ManifestResponse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/ --- (Updated Oct. 6, 2015, 2:31 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37023: Add an endpoint that exposes component flags.

> On Oct. 6, 2015, 1:19 a.m., Ben Mahler wrote: > > src/master/http.cpp, line 523 > > > > > > Can you avoid the static non-POD? We should follow up on removing the > > rest as well (I believe there is a ticket for t

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/ --- (Updated Oct. 6, 2015, 2:30 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37023: Add an endpoint that exposes component flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/ --- (Updated Oct. 6, 2015, 2:29 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38874/ --- (Updated Oct. 6, 2015, 2:22 a.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

> On Sept. 30, 2015, 4:25 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 5325 > > > > > > Can you please add some comments here? Just curious why here the state > > is REGISTERING? Thanks. Ideally this wou

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

> On Oct. 5, 2015, 11:51 p.m., Isabel Jimenez wrote: > > src/slave/slave.hpp, line 42 > > > > > > we don't need this We need this include as the encoder needs it. We can get away with this but that would entail conv

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review101578 --- Patch looks great! Reviews applied: [38443, 39013, 38579] All tes

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 6, 2015, 2:02 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 39034: Fixed "--help" output for "--master" in mesos-slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39034/#review101576 --- Ship it! Ship It! - Adam B On Oct. 5, 2015, 5:53 p.m., Neil Con

Re: Review Request 38527: Fix UserCgroupIsolatorTest failed on CentOS 6.6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38527/#review101575 --- src/tests/containerizer/isolator_tests.cpp (line 1205)

Re: Review Request 37024: Exposes mesos version information in components.

> On Oct. 6, 2015, 1:16 a.m., Ben Mahler wrote: > > Sorry, this should be the last iteration. :) Never mind, it is my fault not to recompile it again before update. Thank you very much. - haosdent --- This is an automatically generated

Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/#review101573 --- Ship it! Ship It! - Guangya Liu On 十月 5, 2015, 11:09 p.m., Anan

Re: Review Request 37024: Exposes mesos version information in components.

> On Oct. 6, 2015, 1:16 a.m., Ben Mahler wrote: > > src/version/version.hpp, line 43 > > > > > > Hm.. I'm confused as to how you can initialize this non-static member > > in the .cpp file as you're doing now. Can you

Re: Review Request 37023: Add an endpoint that exposes component flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/#review101570 --- Ship it! Looks great, just a minor cleanup and we can get this com

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101571 --- Ship it! Sorry, this should be the last iteration. :) src/versio

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 6, 2015, 1:14 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 6, 2015, 1:11 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 38570: Change documentation image links to absolute paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38570/#review101569 --- Patch looks great! Reviews applied: [38570] All tests passed. -

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101568 --- src/slave/slave.cpp (line 96)

Re: Review Request 39034: Fixed "--help" output for "--master" in mesos-slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39034/#review101567 --- Ship it! Ship It! - Guangya Liu On 十月 6, 2015, 12:53 a.m., Neil

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review101566 --- Ship it! Ship It! - haosdent huang On Oct. 6, 2015, 12:26 a.m.,

Review Request 39034: Fixed "--help" output for "--master" in mesos-slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39034/ --- Review request for mesos and Adam B. Bugs: MESOS-3591 https://issues.apache

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101565 --- Ship it! Ship It! - Isabel Jimenez On Sept. 30, 2015, 6:06 a.m.

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 十月 6, 2015, 12:26 a.m.) Review request for mesos, Adam B, Alexander Ru

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38932/#review101564 --- Patch looks great! Reviews applied: [38932] All tests passed. -

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/#review101563 --- Or simply use 'tee -a' instead? Since it should not append anything

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38875/#review101562 --- src/slave/http.cpp (line 298)

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38874/#review101556 --- src/slave/slave.hpp (line 42)

Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

> On Oct. 5, 2015, 11 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/http.cpp, line 783 > > > > > > s/`socket_`/`_socket`/? > > > > underscore suffix makes it more look like a member (Google style). Agreed

Re: Review Request 38919: Validation of Docker Image Manifests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review101555 --- src/slave/containerizer/provisioner/docker/spec.cpp (line 29)

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/#review101554 --- Hm.. this still depends on https://reviews.apache.org/r/38443/ whic

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review101553 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 357)

Re: Review Request 37996: Added property manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review101552 --- 3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.h

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review101541 --- src/examples/dynamic_reservation_framework.cpp (lines 60 - 61)

Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/#review101551 --- Ship it! Ship It! - Isabel Jimenez On Oct. 5, 2015, 11:09 p.m.,

Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/ --- (Updated Oct. 5, 2015, 11:09 p.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/#review101550 --- LGTM just small nit from standing review issue - Isabel Jimenez

Re: Review Request 38606: Added ability to check if the streaming decoder is writing to a body pipe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38606/#review101549 --- Ship it! Ship It! - Jie Yu On Sept. 22, 2015, 6:18 a.m., Ben Ma

Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38608/#review101548 --- Ship it! Ship It! - Jie Yu On Oct. 3, 2015, 12:04 a.m., Ben Mah

Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38608/#review101540 --- LGTM! Nice tests! 3rdparty/libprocess/src/http.cpp (line 783)

Re: Review Request 39025: Fixed a flaky oversubscription test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39025/#review101545 --- Ship it! LGTM ! - Anand Mazumdar On Oct. 5, 2015, 10:25 p.m., B

Re: Review Request 38646: Added WIP note for Executor endpoint in changelog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38646/#review101544 --- Ship it! Ship It! - Isabel Jimenez On Sept. 25, 2015, 12:09 a.m

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

Jie or Ian, can you shepherd this? On Sat, Oct 3, 2015 at 5:25 PM, Mesos ReviewBot wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36180/#review101422 > ---

Review Request 39025: Fixed a flaky oversubscription test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39025/ --- Review request for mesos, Anand Mazumdar and Jie Yu. Bugs: MESOS-3577 https

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Oct. 5, 2015, 10:12 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

> On Sept. 29, 2015, 4:17 p.m., Alexander Rukletsov wrote: > > One high level suggestion. > > > > After looking at our http code, I realized that we use the same pattern > > again and again, for example: > > ``` > > JSON::Array array; > > array.values.reserve(status.network_infos().size

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

> On Sept. 28, 2015, 9:11 a.m., Jan Schlicht wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 762 > > > > > > Because this code has been changed from a constructor to a function, we > >

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 5, 2015, 9:51 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101534 --- Ship it! Looks great hsaodent! Thanks for your patience, just a co

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 5, 2015, 9:38 p.m.) Review request for mesos, Adam B, Alexander R

Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael Park.

Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 5, 2015, 9:23 p.m.) Review request for mesos, Ben Mahler and Timo

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/ --- (Updated Oct. 5, 2015, 9:21 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review101533 --- src/slave/containerizer/provisioner/docker/message.proto (line 79)

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

> On Oct. 5, 2015, 9:07 p.m., Ben Mahler wrote: > > I'd like to ship these smaller fixes, but they depend on the large refactor > > patch and the patch for new functionality, so I can't apply the change :( > > > > Please put the small cleanup patches at the front of your change so that > > the

Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/#review101530 --- I'd like to ship these smaller fixes, but they depend on the large

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 5, 2015, 9:03 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38941: Moved structs outside RegistryClient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38941/ --- (Updated Oct. 5, 2015, 9:01 p.m.) Review request for mesos, Ben Mahler and Timo

Review Request 39013: RegistryClient refactor: Fixed comments style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39013/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Review Request 39014: RegistryClient refactor: renamed ManifestResponse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Review Request 39015: RegistryClient refactor: expanded abbreviated names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39015/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Review Request 39016: RegistryClient refactor: refactored lambdas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39016/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Review Request 39017: RegistryClient refactor: encapsulated Manifest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 38919: Validation of Docker Image Manifests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 5, 2015, 1:51 p.m.) Review request for mesos, Jojy Varghese and T

Re: Review Request 38963: Added initial draft of networking user-doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38963/ --- (Updated Oct. 5, 2015, 4:44 p.m.) Review request for mesos, Connor Doyle and Ni

Re: Review Request 38963: Added initial draft of networking user-doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38963/ --- (Updated Oct. 5, 2015, 3:55 p.m.) Review request for mesos, Connor Doyle and Ni

Re: Review Request 38963: Added initial draft of networking user-doc.

> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote: > > docs/networking.md, lines 95-96 > > > > > > (And makes it to the scheduler :) Is that worth mentioning here? It's mentioned in the next bullet point :). > On

Re: Review Request 38963: Added initial draft of networking user-doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38963/ --- (Updated Oct. 5, 2015, 3:52 p.m.) Review request for mesos, Connor Doyle and Ni

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- (Updated Oct. 5, 2015, 12:21 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- (Updated Oct. 5, 2015, 12:14 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

> On Oct. 2, 2015, 3:38 p.m., Timothy Chen wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 361 > > > > > > What's invalid about this JSON? Because we have to make sure that we have at least one

Re: Review Request 37024: Exposes mesos version information in components.

> On Oct. 5, 2015, 6:48 p.m., Marco Massenzio wrote: > > src/version/version.cpp, lines 81-82 > > > > > > Minor nit: s/mesos/Apache Mesos and I think you can drop the "This > > endpoint" - "Shows the current version

  1   2   >