Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review103050 --- src/docker/docker.cpp (line 430)

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103049 --- Patch looks great! Reviews applied: [38705, 38883, 39410, 39420]

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review103048 --- Patch looks great! Reviews applied: [39415, 39416, 39417] All tes

Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 17, 2015, 7:40 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 17, 2015, 7:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Oct. 17, 2015, 7:37 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review103045 --- Patch looks great! Reviews applied: [39388] All tests passed. -

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review103042 --- src/common/resources.cpp (line 274)

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

> On Oct. 15, 2015, 5:21 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39345] > > > > Failed command: ./support/apply-review.sh -n -r 39345 > > > > Error: > > 2015-10-15 17:21:02 URL:https://reviews.apache.org/r/39345/diff/raw/ > > [22252/22252] -> "39345.patch" [1] >

Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos Descriptio

Review Request 39416: Document --egress_unique_flow_per_container in docs/configuration.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39416/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos Descriptio

Review Request 39415: Error out when root qdisc already exists

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39415/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos Descriptio

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39180/#review103030 --- Ship it! Please don't include other rebased patches in to your dif

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/#review103031 --- Ship it! Verified that the code was just moved. - Joris Van Remoo

Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39202/#review103033 --- Ship it! 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake

Re: Review Request 39182: Windows: Enable ip_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/#review102170 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/windows

Re: Review Request 39203: CMake: fixed typo in agent include directory configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39203/#review103034 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:29 p.m., Ale

Re: Review Request 39204: Windows: Added support for `stout/os/read.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39204/#review103035 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:29 p.m., Ale

Re: Review Request 39209: Windows: Move ::UUID to stout::UUID to avoid namespace collision.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39209/#review103038 --- Ship it! Changing the summary to reflect the code change. - Joris

Re: Review Request 39207: Windows: Move `write` to its own file, `stout/os/write.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39207/#review103036 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39208/#review103037 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/protobu

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/#review103039 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/wind

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review103043 --- Patch looks great! Reviews applied: [39211, 39018, 39102] All tes

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/ --- (Updated Oct. 17, 2015, 11:18 p.m.) Review request for mesos and Niklas Nielsen

Re: Review Request 39102: Added documentation for JSON resources.

> On Oct. 17, 2015, 8:44 a.m., Guangya Liu wrote: > > Looks good. But we need first make sure the backend code merged first. > > https://reviews.apache.org/r/39018/ Thanks; altered this review to depend on 39018. - Greg --- This is an

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Oct. 17, 2015, 11:05 p.m.) Review request for mesos, Adam B and Neil C

Re: Review Request 39201: Included `stout/check.hpp` in `future.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/#review103032 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:28 p.m., Ale

Re: Review Request 39398: Sync TaskStatus::Reason enumerations in v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39398/#review103029 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 16, 2015, 4:43

Re: Review Request 39330: libprocess: Replaced usage of "volatile" with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39330/#review103028 --- Thanks for follow up with this Neil. Let's simplify the patch with

Re: Review Request 29551: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29551/#review103027 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 14, 2015, 6:31

Re: Review Request 29550: Libprocess: Added "tests" target for make.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29550/#review103026 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 14, 2015, 6:31

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review103024 --- Bad patch! Reviews applied: [39076, 39091, 39092, 39093, 39096, 39

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

> On Oct. 16, 2015, 9:19 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39076, 39091, 39092, 39093, 39096, 39097, 39180] > > > > Failed command: ./support/apply-review.sh -n -r 39180 > > > > Error: > > 2015-10-16 21:19:05 URL:https://reviews.apache.org/r/39180/diff/raw/

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- (Updated Oct. 17, 2015, 6:54 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39380: Windows: Added support for `stout/flags/flags.hpp`.

> On Oct. 16, 2015, 8:15 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp, line 20 > > > > > > Is this addition related? > > > > (It's good to have nevertheless.) Y

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/#review103020 --- Thanks for adding this! Are you looking to also work on docker stor

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review103019 --- Looks good. But we need first make sure the backend code merged fir

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review103018 --- src/common/resources.cpp (line 274)

Re: Review Request 39398: Sync TaskStatus::Reason enumerations in v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39398/#review103016 --- Ship it! Ship It! - Guangya Liu On 十月 16, 2015, 4:43 p.m., Jose