Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review104534 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540,

Re: Review Request 39628: Clear the suppressed flag when deactive a framework

> On Oct. 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? > > Guangya Liu wrote: > I think this is a bug, I tested without my code change, the test also > failed sometimes. Shall we file a bug for this? > > Vinod Kone wrote: >

Re: Review Request 39628: Clear the suppressed flag when deactive a framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/ --- (Updated Oct. 30, 2015, 6:52 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

> On Oct. 26, 2015, 4:22 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 79 > > > > > > s/options/dry_run/ > > > > you can generalize it to 'options' later if there is a need for it. I made

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 30, 2015, 1:55 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Oct. 30, 2015, 6:11 a.m.) Review request for mesos, Artem

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 30, 2015, 1:56 a.m.) Review request for mesos, Joris Van

Re: Review Request 39636: FreeBSD: Add basic support to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/#review104530 --- Patch looks great! Reviews applied: [39634, 39635, 39636] All

Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 30, 2015, 1:54 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39827: Made slave version required in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39827/#review104629 --- Patch looks great! Reviews applied: [39791, 39792, 39827] All

Re: Review Request 39827: Made slave version required in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39827/#review104625 --- Ship it! Looks good, thank you for doing the cleanup.

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

> On Oct. 30, 2015, 9:16 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.cpp, line 190 > > > > > > OK, this is problematic and almost caused us an incident at Twitter. > > > > Mesos is able

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/#review104631 --- Ship it! Ship It! - Ben Mahler On Oct. 14, 2015, 4:06 p.m.,

Re: Review Request 39818: Containerizer launcher: removed SSL environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39818/#review104628 --- src/slave/containerizer/containerizer.cpp (line 270)

Re: Review Request 38941: Moved structs outside RegistryClient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38941/#review104630 --- Ship it!

Re: Review Request 39628: Clear the suppressed flag when deactive a framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review104544 --- Patch looks great! Reviews applied: [39628] All tests passed. -

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review104549 --- Patch looks great! Reviews applied: [38705, 38883, 39410, 39420]

Re: Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39791/#review104621 --- Ship it! Thanks for taking care of this

Review Request 39818: Containerizer launcher: removed SSL environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39818/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos

Re: Review Request 39818: Containerizer launcher: removed SSL environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39818/#review104584 --- Patch looks great! Reviews applied: [39818] All tests passed. -

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review104619 --- src/slave/containerizer/linux_launcher.cpp (line 190)

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/#review104622 --- Hm.. we're still relying on the update uuid, shouldn't we be

Re: Review Request 39155: RegistryClient refactor: removed nested namespace references

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39155/#review104578 --- Hm.. the summary title of this review was a bit confusing for me,