Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review125825 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 45404: Cleaned up a test case in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45404/#review125826 --- Patch looks great! Reviews applied: [45403, 45404] Passed

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review125824 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 44421: Added support for "overlay" keyword.

> On 三月 29, 2016, 4:42 a.m., Cong Wang wrote: > > src/slave/containerizer/mesos/provisioner/backend.cpp, line 50 > > > > > > Why do you need to test overlay fs support in create()? If kernel > > doesn't support

Re: Review Request 45401: Fixed typo in subprocess doxygen comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45401/#review125820 --- Ship it! Ship It! - Jie Yu On March 28, 2016, 9:42 p.m.,

Re: Review Request 45400: Adapted port_mapping with missing subprocess parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45400/#review125819 --- Ship it! Ship It! - Jie Yu On March 28, 2016, 9:41 p.m.,

Re: Review Request 45399: Fixed capitalization of Watchdog enum.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45399/#review125818 --- Can you provide more context for this change? For instance, why

Re: Review Request 45404: Cleaned up a test case in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45404/#review125816 --- Ship it! Ship It! - Jie Yu On March 28, 2016, 10:57 p.m.,

Re: Review Request 44964: Removed unused header includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44964/#review125815 --- Ship it! Ship It! - Jie Yu On March 29, 2016, 12:25 a.m.,

Re: Review Request 44963: Added a missing include to a stout header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44963/#review125814 --- Ship it! Ship It! - Jie Yu On March 17, 2016, 4:41 p.m.,

Re: Review Request 45381: Pass containerizer to ResourceMonitor and ResourceMonitorProcess.

> On 三月 28, 2016, 3:52 p.m., Guangya Liu wrote: > > src/slave/slave.hpp, lines 398-399 > > > > > > A question here: What is the use of this API? > > Jay Guo wrote: > This line of code is leaked from another

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review125804 --- The document here

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review125803 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp

Re: Review Request 42860: Add paths::overlapping to check whether paths are overlapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/#review125801 --- Made a few quick comments. I didn't look at the

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review125802 --- It would be good to have a unit test for the end-to-end behavior

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review125800 --- @jieyu, can you please help check if we can merge this, this can

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review125799 --- src/slave/containerizer/mesos/containerizer.cpp (line 786)

Re: Review Request 42860: Add paths::overlapping to check whether paths are overlapping.

> On March 21, 2016, 5:29 p.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 70 > > > > > > `if (paths.empty()) { ... }` seems like a clearer way to write this. @neic,

Re: Review Request 42860: Add paths::overlapping to check whether paths are overlapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/ --- (Updated March 29, 2016, 2:30 a.m.) Review request for mesos, Benjamin

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated March 29, 2016, 2:30 a.m.) Review request for mesos, Benjamin

Re: Review Request 45381: Pass containerizer to ResourceMonitor and ResourceMonitorProcess.

> On March 28, 2016, 3:52 p.m., Guangya Liu wrote: > > src/slave/slave.hpp, lines 398-399 > > > > > > A question here: What is the use of this API? This line of code is leaked from another implementation. I

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

> On March 28, 2016, 10:23 p.m., Adam B wrote: > > Let's change the UNREACHABLE to an error+unauthorized. Thanks for the review Adam. I updated the review request. Let me know if the change meets the requirements or not. - Yong ---

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/ --- (Updated March 29, 2016, 2:04 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 44974: Added device support in cgroups abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review125782 --- Fix it, then Ship it! Thanks! Kevin and I went over this and

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review125792 --- Ship it! Thanks! Kevin and I made some minor style adjustments

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/ --- (Updated March 29, 2016, 10 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 29, 2016, 10 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125790 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 45067: Updated the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review125780 --- src/examples/long_lived_framework.cpp (lines 39 - 40)

Review Request 45410: Documented when to invoke `send` using the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45410/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4950

Review Request 45409: Added test for `reconnect` functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45409/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4950

Review Request 45408: Introduced a `reconnect` method on the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45408/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4950

Re: Review Request 45401: Fixed typo in subprocess doxygen comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45401/#review125777 --- Ship it! Ship It! - Cong Wang On March 28, 2016, 9:42 p.m.,

Re: Review Request 45399: Fixed capitalization of Watchdog enum.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45399/#review125776 --- Ship it! Ship It! - Cong Wang On March 28, 2016, 9:41 p.m.,

Re: Review Request 45397: Changed name of http-parser enum to 'flags_enum'.

> On March 28, 2016, 9:10 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch, line 10 > > > > > > Do you know why the non-ssl build didn't have a problem with this > > conflict? > >

Re: Review Request 45403: Fixed build breakage with CentOS 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45403/#review125772 --- Ship it! Ship It! - Jie Yu On March 28, 2016, 10:57 p.m.,

Re: Review Request 45381: Pass containerizer to ResourceMonitor and ResourceMonitorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review125770 --- Chatted with BenM on this. I think we should just kill the

Review Request 45403: Fixed build breakage with CentOS 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45403/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 45404: Cleaned up a test case in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45404/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 45008: Moved command scheduler to use the scheduler library.

> On March 28, 2016, 9:39 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 245-266 > > > > > > The semantics of stop() are a bit hard to intuit. > > > > How about we have two methods > > -

Re: Review Request 45008: Moved command scheduler to use the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45008/ --- (Updated March 28, 2016, 10:32 p.m.) Review request for mesos, Guangya Liu and

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125768 --- Let's change the UNREACHABLE to an error+unauthorized.

Re: Review Request 45400: Adapted port_mapping with missing subprocess parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45400/#review125763 --- Ship it! Ship It! - Cong Wang On March 28, 2016, 9:41 p.m.,

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/#review125765 --- Can you set the "depends on" field correctly for this and any

Re: Review Request 45397: Changed name of http-parser enum to 'flags_enum'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45397/ --- (Updated March 28, 2016, 9:58 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45230: Refactored subproces setup functions [1/7].

Only '../configure --with-network-isolator' which unfortunately wasn't the case on neither of the system.. Sorry for the inconvenience, fix is just being tested. On Mon, Mar 28, 2016 at 7:15 PM, Cong Wang wrote: > I am wondering how does it pass your test since you did

Re: Review Request 45398: Added CHANGELOG for python module changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45398/#review125759 --- Can you also update the release guide

Re: Review Request 45397: Changed name of http-parser enum to 'flags_enum'.

> On March 28, 2016, 9:10 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch, line 10 > > > > > > Do you know why the non-ssl build didn't have a problem with this > > conflict? > >

Review Request 45401: Fixed typo in subprocess doxygen comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45401/ --- Review request for mesos. Bugs: MESOS-5049

Review Request 45399: Fixed capitalization of Watchdog enum.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45399/ --- Review request for mesos. Bugs: MESOS-5049

Review Request 45400: Adapted port_mapping with missing subprocess parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45400/ --- Review request for mesos. Bugs: MESOS-5049

Re: Review Request 45230: Refactored subproces setup functions [1/7].

> On March 28, 2016, 5:06 p.m., Cong Wang wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 311 > > > > > > This one breaks build even after all of your 7 patches are committed, > > because

Re: Review Request 45008: Moved command scheduler to use the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45008/#review125753 --- src/cli/execute.cpp (lines 45 - 47)

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

> On March 28, 2016, 5 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 46 > > > > > > When did we start making 'enum' names be in caps? There is an enum 7 > > lines above

Re: Review Request 45230: Refactored subproces setup functions [1/7].

> On March 28, 2016, 5:06 p.m., Cong Wang wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 311 > > > > > > This one breaks build even after all of your 7 patches are committed, > > because

Re: Review Request 45397: Changed name of http-parser enum to 'flags_enum'.

> On March 28, 2016, 9:10 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch, line 10 > > > > > > Do you know why the non-ssl build didn't have a problem with this > > conflict? > >

Re: Review Request 44843: Replace NULL with nullptr.

> On March 26, 2016, 7:10 p.m., Michael Park wrote: > > src/exec/exec.cpp, lines 637-638 > > > > > > This is clearly beyond just a `s/NULL/nullptr`. I assume this is > > `clang-tidy` magic, right? Exactly -

Re: Review Request 45006: Added `devolve` overloads for `v1::TaskStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45006/#review125748 --- Ship it! Ship It! - Vinod Kone On March 18, 2016, 3:27

Re: Review Request 45397: Changed name of http-parser enum to 'flags_enum'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45397/ --- (Updated March 28, 2016, 9:18 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45013: Removed un-needed methods from command scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45013/#review125750 --- Ship it! Ship It! - Vinod Kone On March 18, 2016, 3:27

Re: Review Request 45007: Fixed `using` declaration order in `mesos-execute`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45007/#review125749 --- Ship it! Ship It! - Vinod Kone On March 18, 2016, 3:27

Review Request 45398: Added CHANGELOG for python module changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45398/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 45005: Fixed minor spacing issue in the example test framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45005/#review125747 --- Ship it! Ship It! - Vinod Kone On March 18, 2016, 3:27

Re: Review Request 45004: Fixed a memory leak in the scheduler driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45004/#review125746 --- Ship it! Ship It! - Vinod Kone On March 18, 2016, 3:27

Re: Review Request 45397: Changed name of http-parser enum to 'flags_enum'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45397/#review125745 --- 3rdparty/libprocess/3rdparty/Makefile.am (line 61)

Re: Review Request 45397: Changed name of http-parser enum to 'flags_enum'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45397/ --- (Updated March 28, 2016, 9:08 p.m.) Review request for mesos and Vinod Kone.

Review Request 45397: Changed name of http-parser enum to 'flags_enum'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45397/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 45313: Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45313/ --- (Updated March 28, 2016, 8:57 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 44843: Replace NULL with nullptr.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/ --- (Updated March 28, 2016, 8:42 p.m.) Review request for mesos and Michael Park.

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated March 28, 2016, 8:28 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45311: Added an additional template parameter to 'Try' for typeful error.

> On March 26, 2016, 8:07 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp, line 33 > > > > > > With this default parameter the code has to be changed on every place > > where

Re: Review Request 45310: Removed unnecessary constructors in `Try`.

> On March 26, 2016, 7:43 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp, line 56 > > > > > > Without additional context the reviewer may think that this change will > >

Re: Review Request 41410: Export CFS metrics for docker containers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41410/ --- (Updated March 28, 2016, 7:38 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125725 --- Ship it! Ship It! - Vinod Kone On March 25, 2016, 8:13

Re: Review Request 45369: Upgrade http-parser to 2.6.1 to support PowerPC LE platform [mesos].

Hmm. Look like this broke the SSL build .

Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].

> On March 28, 2016, 7:13 p.m., James Peach wrote: > > Do you also need to regenerate > > ``3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc``? Oh, I see it is in [r44257](https://reviews.apache.org/r/44257). - James ---

Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/#review125716 --- Do you also need to regenerate

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/#review125710 --- Ship it! Ship It! - Jie Yu On March 28, 2016, 6:20 p.m.,

Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/ --- (Updated March 28, 2016, 6:55 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 45368: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45368/ --- (Updated March 28, 2016, 6:54 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review125701 --- Ship it! Ship It! - Vinod Kone On March 28, 2016, 2:09

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PPC LE platform [libprocess].

> On March 4, 2016, 7:37 a.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 68 > > > > > > ditto. > > Zhiwei Chen wrote: > In the real file, there is a table bracket and backslash. >

Re: Review Request 45369: Upgrade http-parser to 2.6.1 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45369/#review125699 --- Ship it! Ship It! - Vinod Kone On March 28, 2016, 6:36

Re: Review Request 45369: Upgrade http-parser to 2.6.1 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45369/ --- (Updated March 28, 2016, 6:36 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review125698 --- Patch looks great! Reviews applied: [43935] Passed command:

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/ --- (Updated March 28, 2016, 6:20 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:43 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 554-572 > > > > > > 2 spaces indent, you can take > > https://github.com/apache/mesos/blob/master/src/master/http.cpp#L482 as >

Re: Review Request 42516: Add support for user-defined networks.

> On March 28, 2016, 3:43 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 554-572 > > > > > > 2 spaces indent, you can take > > https://github.com/apache/mesos/blob/master/src/master/http.cpp#L482 as >

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/#review124445 --- Minor comments. More thorough review once the tests reflect the

Re: Review Request 45386: Fix container destroy provisioning race.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45386/ --- (Updated March 28, 2016, 10:16 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45230: Refactored subproces setup functions [1/7].

I am wondering how does it pass your test since you did `make check` on both Linux and OSX? It fails immediately for me on Linux... On Mon, Mar 28, 2016 at 10:09 AM, Joris Van Remoortere wrote: > Joerg will fix these. > Thanks! > > On Mon, Mar 28, 2016 at 7:06

Re: Review Request 45230: Refactored subproces setup functions [1/7].

Joerg will fix these. Thanks! On Mon, Mar 28, 2016 at 7:06 PM, Cong Wang wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45230/ > 3rdparty/libprocess/include/process/subprocess.hpp >

Re: Review Request 45230: Refactored subproces setup functions [1/7].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45230/#review125677 --- 3rdparty/libprocess/include/process/subprocess.hpp (line 301)

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45232/#review125676 --- 3rdparty/libprocess/include/process/subprocess.hpp (line 46)

Re: Review Request 45245: Added watchdog to 'du' disk isolator process [7/7].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45245/ --- (Updated March 28, 2016, 4:54 p.m.) Review request for mesos and Joris Van

Re: Review Request 45236: Refactored isolator tests to use parentHook [6/7].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45236/ --- (Updated March 28, 2016, 4:53 p.m.) Review request for mesos and Joris Van

  1   2   >